From: Maxime Ripard <maxime.ripard@bootlin.com>
To: "Jernej Škrabec" <jernej.skrabec@siol.net>
Cc: Jagan Teki <jagan@amarulasolutions.com>,
Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents
Date: Fri, 18 May 2018 17:26:51 +0200 [thread overview]
Message-ID: <20180518152651.lfymc3kj7npj5tww@flea> (raw)
In-Reply-To: <4909574.Q3IFWM0xt6@jernej-laptop>
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej Škrabec wrote:
> > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to
> > lookup pll-2 either.
>
> It is highly unlikely this will be higher than 2, at least for this HDMI PHY,
> since it has only 1 bit reserved for parent selection. But since I have to fix
> it, I'll add ">= 2"
If we're only going to have two parents at most, ever, why don't we
had just a single other boolean. This would be less intrusive, and we
wouldn't have to check for those corner cases.
> BTW, I'll resend fixed version of this patch for my R40 HDMI series, since
> there is nothing to hold it back, unlike for this.
Awesome, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents
Date: Fri, 18 May 2018 17:26:51 +0200 [thread overview]
Message-ID: <20180518152651.lfymc3kj7npj5tww@flea> (raw)
In-Reply-To: <4909574.Q3IFWM0xt6@jernej-laptop>
On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej ?krabec wrote:
> > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to
> > lookup pll-2 either.
>
> It is highly unlikely this will be higher than 2, at least for this HDMI PHY,
> since it has only 1 bit reserved for parent selection. But since I have to fix
> it, I'll add ">= 2"
If we're only going to have two parents at most, ever, why don't we
had just a single other boolean. This would be less intrusive, and we
wouldn't have to check for those corner cases.
> BTW, I'll resend fixed version of this patch for my R40 HDMI series, since
> there is nothing to hold it back, unlike for this.
Awesome, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180518/0f026579/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: "Jernej Škrabec" <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>
Cc: Jagan Teki
<jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michael Trimarchi
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents
Date: Fri, 18 May 2018 17:26:51 +0200 [thread overview]
Message-ID: <20180518152651.lfymc3kj7npj5tww@flea> (raw)
In-Reply-To: <4909574.Q3IFWM0xt6@jernej-laptop>
[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]
On Fri, May 18, 2018 at 04:46:41PM +0200, Jernej Škrabec wrote:
> > And this is a bit sloppy, since if phy_clk_num == 3, you won't try to
> > lookup pll-2 either.
>
> It is highly unlikely this will be higher than 2, at least for this HDMI PHY,
> since it has only 1 bit reserved for parent selection. But since I have to fix
> it, I'll add ">= 2"
If we're only going to have two parents at most, ever, why don't we
had just a single other boolean. This would be less intrusive, and we
wouldn't have to check for those corner cases.
> BTW, I'll resend fixed version of this patch for my R40 HDMI series, since
> there is nothing to hold it back, unlike for this.
Awesome, thanks!
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
--
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-18 15:26 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 9:45 [PATCH v2 00/26] arm64: allwinner: Add A64 DE2 HDMI support Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 01/26] dt-bindings: clock: Add compatible for A64 DE2 CCU Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 02/26] arm64: dts: allwinner: a64: Add " Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 03/26] clk: sunxi-ng: Enable DE2_CCU for SUN8I and SUN50I Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 04/26] clk: sunxi-ng: a64: Add minimal rate for video PLLs Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 05/26] drm/sun4i: DE2 mixer: Add index quirk Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 06/26] drm/sun4i: Add support for A64 mixer1 Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 07/26] dt-bindings: display: Add compatible for A64 DE2 tcon1 blocks Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-22 18:10 ` Rob Herring
2018-05-22 18:10 ` Rob Herring
2018-05-22 18:10 ` Rob Herring
2018-05-18 9:45 ` [PATCH v2 08/26] drm/sun4i: Add support for A64 display engine Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 09/26] arm64: dts: allwinner: a64: Add DE2 tcon1 pipeline Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 10/26] drm/sun4i: Enable DE2 Mixer for SUN8I and SUN50I Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 11/26] arm64: defconfig: Enable CONFIG_DRM_SUN4I Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 12/26] drm/sun4i: Add support for multiple DW HDMI PHY clock parents Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 10:01 ` Maxime Ripard
2018-05-18 10:01 ` Maxime Ripard
2018-05-18 10:01 ` Maxime Ripard
2018-05-18 14:46 ` Jernej Škrabec
2018-05-18 14:46 ` Jernej Škrabec
2018-05-18 15:09 ` Sergey Suloev
2018-05-18 15:09 ` Sergey Suloev
2018-05-18 15:15 ` Jernej Škrabec
2018-05-18 15:15 ` Jernej Škrabec
2018-05-18 15:15 ` Jernej Škrabec
2018-05-18 15:21 ` Sergey Suloev
2018-05-18 15:21 ` Sergey Suloev
2018-05-18 15:26 ` Maxime Ripard [this message]
2018-05-18 15:26 ` Maxime Ripard
2018-05-18 15:26 ` Maxime Ripard
2018-05-18 15:34 ` Jernej Škrabec
2018-05-18 15:34 ` Jernej Škrabec
2018-05-18 15:34 ` Jernej Škrabec
2018-05-19 7:11 ` Jernej Škrabec
2018-05-19 7:11 ` Jernej Škrabec
2018-05-19 7:11 ` Jernej Škrabec
2018-05-18 9:45 ` [PATCH v2 13/26] drm/sun4i: Add support for A64 HDMI PHY Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 14/26] dt-bindings: display: Add compatible for A64 HDMI Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-22 18:10 ` Rob Herring
2018-05-22 18:10 ` Rob Herring
2018-05-22 18:10 ` Rob Herring
2018-05-18 9:45 ` [PATCH v2 15/26] dt-bindings: display: Add compatible for A64 HDMI PHY Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 16/26] dt-bindings: clock: sun50i-a64-ccu: Add PLL_VIDEO[0-1] macros Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 14:23 ` Rob Herring
2018-05-18 14:23 ` Rob Herring
2018-05-18 14:23 ` Rob Herring
2018-05-18 9:45 ` [PATCH v2 17/26] arm64: dts: allwinner: a64: Add HDMI support Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 18/26] drm/sun4i: Enable DesignWare HDMI for SUN8I and SUN50I Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 19/26] arm64: dts: allwinner: a64: Add HDMI pipeline Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 20/26] drm: sun4i: add support for HVCC regulator for DWC HDMI glue Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 21/26] arm64: dts: allwinner: a64: bananapi-m64: Enable HDMI output Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 22/26] arm64: dts: allwinner: a64: nanopi-a64: " Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 23/26] arm64: dts: allwinner: a64: orangepi-win: " Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 24/26] arm64: dts: allwinner: a64: a64-olinuxino: " Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 25/26] arm64: dts: allwinner: a64: pine64: " Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` [PATCH v2 26/26] arm64: dts: allwinner: a64: sopine: " Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:45 ` Jagan Teki
2018-05-18 9:59 ` [PATCH v2 00/26] arm64: allwinner: Add A64 DE2 HDMI support Maxime Ripard
2018-05-18 9:59 ` Maxime Ripard
2018-05-18 9:59 ` Maxime Ripard
2018-06-05 12:53 ` [linux-sunxi] " Jagan Teki
2018-06-05 12:53 ` Jagan Teki
2018-06-05 12:53 ` [linux-sunxi] " Jagan Teki
2018-06-05 13:25 ` Maxime Ripard
2018-06-05 13:25 ` Maxime Ripard
2018-06-05 13:25 ` [linux-sunxi] " Maxime Ripard
2018-06-05 13:58 ` Icenowy Zheng
2018-06-05 13:58 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518152651.lfymc3kj7npj5tww@flea \
--to=maxime.ripard@bootlin.com \
--cc=airlied@linux.ie \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.