From: Keith Busch <keith.busch@linux.intel.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@kernel.dk>,
Laurence Oberman <loberman@redhat.com>,
Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/6] nvme: Sync request queues on reset
Date: Fri, 18 May 2018 17:44:08 -0600 [thread overview]
Message-ID: <20180518234408.GA31749@localhost.localdomain> (raw)
In-Reply-To: <20180518223210.GB18334@ming.t460p>
On Sat, May 19, 2018 at 06:32:11AM +0800, Ming Lei wrote:
> This way can't sync timeout reliably, since timeout events can
> come from two NS at the same time, and one may be handled as
> RESET_TIMER, and another one can be handled as EH_HANDLED.
You keep saying that, but the controller state is global to the
controller. It doesn't matter which namespace request_queue started the
reset: every namespaces request queue sees the RESETTING controller state
from the point the syncing occurs, and they don't return RESET_TIMER,
and on top of that, the reset reclaims every single IO command no matter
what namespace request_queue initiated the reset.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH 1/6] nvme: Sync request queues on reset
Date: Fri, 18 May 2018 17:44:08 -0600 [thread overview]
Message-ID: <20180518234408.GA31749@localhost.localdomain> (raw)
In-Reply-To: <20180518223210.GB18334@ming.t460p>
On Sat, May 19, 2018@06:32:11AM +0800, Ming Lei wrote:
> This way can't sync timeout reliably, since timeout events can
> come from two NS at the same time, and one may be handled as
> RESET_TIMER, and another one can be handled as EH_HANDLED.
You keep saying that, but the controller state is global to the
controller. It doesn't matter which namespace request_queue started the
reset: every namespaces request queue sees the RESETTING controller state
from the point the syncing occurs, and they don't return RESET_TIMER,
and on top of that, the reset reclaims every single IO command no matter
what namespace request_queue initiated the reset.
next prev parent reply other threads:[~2018-05-18 23:44 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 16:38 [PATCH 1/6] nvme: Sync request queues on reset Keith Busch
2018-05-18 16:38 ` Keith Busch
2018-05-18 16:38 ` [PATCH 2/6] nvme-pci: Fix queue freeze criteria " Keith Busch
2018-05-18 16:38 ` Keith Busch
2018-05-18 16:38 ` [PATCH 3/6] nvme: Move all IO out of controller reset Keith Busch
2018-05-18 16:38 ` Keith Busch
2018-05-18 23:03 ` Ming Lei
2018-05-18 23:03 ` Ming Lei
2018-05-21 14:22 ` Keith Busch
2018-05-21 14:22 ` Keith Busch
2018-05-21 14:58 ` Ming Lei
2018-05-21 14:58 ` Ming Lei
2018-05-21 15:03 ` Keith Busch
2018-05-21 15:03 ` Keith Busch
2018-05-21 15:34 ` Ming Lei
2018-05-21 15:34 ` Ming Lei
2018-05-21 15:44 ` Keith Busch
2018-05-21 15:44 ` Keith Busch
2018-05-21 16:04 ` Ming Lei
2018-05-21 16:04 ` Ming Lei
2018-05-21 16:23 ` Keith Busch
2018-05-21 16:23 ` Keith Busch
2018-05-22 1:46 ` Ming Lei
2018-05-22 1:46 ` Ming Lei
2018-05-22 14:03 ` Keith Busch
2018-05-22 14:03 ` Keith Busch
2018-05-18 16:38 ` [PATCH 4/6] nvme: Allow reset from CONNECTING state Keith Busch
2018-05-18 16:38 ` Keith Busch
2018-05-18 16:38 ` [PATCH 5/6] nvme-pci: Attempt reset retry for IO failures Keith Busch
2018-05-18 16:38 ` Keith Busch
2018-05-18 16:38 ` [PATCH 6/6] nvme-pci: Rate limit the nvme timeout warnings Keith Busch
2018-05-18 16:38 ` Keith Busch
2018-05-18 22:32 ` [PATCH 1/6] nvme: Sync request queues on reset Ming Lei
2018-05-18 22:32 ` Ming Lei
2018-05-18 23:44 ` Keith Busch [this message]
2018-05-18 23:44 ` Keith Busch
2018-05-19 0:01 ` Ming Lei
2018-05-19 0:01 ` Ming Lei
2018-05-21 14:04 ` Keith Busch
2018-05-21 14:04 ` Keith Busch
2018-05-21 15:25 ` Ming Lei
2018-05-21 15:25 ` Ming Lei
2018-05-21 15:59 ` Keith Busch
2018-05-21 15:59 ` Keith Busch
2018-05-21 16:08 ` Ming Lei
2018-05-21 16:08 ` Ming Lei
2018-05-21 16:25 ` Keith Busch
2018-05-21 16:25 ` Keith Busch
2018-05-22 1:56 ` Ming Lei
2018-05-22 1:56 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518234408.GA31749@localhost.localdomain \
--to=keith.busch@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=loberman@redhat.com \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.