From: Ming Lei <ming.lei@redhat.com>
To: Keith Busch <keith.busch@linux.intel.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Laurence Oberman <loberman@redhat.com>,
Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Keith Busch <keith.busch@intel.com>,
Jianchao Wang <jianchao.w.wang@oracle.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V6 11/11] nvme: pci: support nested EH
Date: Sat, 19 May 2018 07:51:29 +0800 [thread overview]
Message-ID: <20180518235128.GA19799@ming.t460p> (raw)
In-Reply-To: <20180518234500.GB31749@localhost.localdomain>
On Fri, May 18, 2018 at 05:45:00PM -0600, Keith Busch wrote:
> On Sat, May 19, 2018 at 06:26:28AM +0800, Ming Lei wrote:
> > So could we please face to the real issue instead of working around
> > test case?
>
> Yes, that's why I want you to stop referencing the broken test.
Unfortunately I don't care if it is broken or not, and I think
the test case is great because it can expose the real problem.
That is its value!
The reason why I referenced this test is that everyone can reproduce
this real issue easily, that is it.
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH V6 11/11] nvme: pci: support nested EH
Date: Sat, 19 May 2018 07:51:29 +0800 [thread overview]
Message-ID: <20180518235128.GA19799@ming.t460p> (raw)
In-Reply-To: <20180518234500.GB31749@localhost.localdomain>
On Fri, May 18, 2018@05:45:00PM -0600, Keith Busch wrote:
> On Sat, May 19, 2018@06:26:28AM +0800, Ming Lei wrote:
> > So could we please face to the real issue instead of working around
> > test case?
>
> Yes, that's why I want you to stop referencing the broken test.
Unfortunately I don't care if it is broken or not, and I think
the test case is great because it can expose the real problem.
That is its value!
The reason why I referenced this test is that everyone can reproduce
this real issue easily, that is it.
Thanks,
Ming
next prev parent reply other threads:[~2018-05-18 23:51 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 4:03 [PATCH V6 00/11] nvme: pci: fix & improve timeout handling Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 01/11] block: introduce blk_quiesce_timeout() and blk_unquiesce_timeout() Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 02/11] nvme: pci: cover timeout for admin commands running in EH Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-24 15:39 ` Keith Busch
2018-05-24 15:39 ` Keith Busch
2018-05-16 4:03 ` [PATCH V6 03/11] nvme: pci: unquiesce admin queue after controller is shutdown Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 04/11] nvme: pci: set nvmeq->cq_vector after alloc cq/sq Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 05/11] nvme: pci: only wait freezing if queue is frozen Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 06/11] nvme: pci: freeze queue in nvme_dev_disable() in case of error recovery Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 07/11] nvme: pci: prepare for supporting error recovery from resetting context Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 08/11] nvme: pci: move error handling out of nvme_reset_dev() Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 09/11] nvme: pci: don't unfreeze queue until controller state updating succeeds Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 10/11] nvme: core: introduce nvme_force_change_ctrl_state() Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 4:03 ` [PATCH V6 11/11] nvme: pci: support nested EH Ming Lei
2018-05-16 4:03 ` Ming Lei
2018-05-16 14:12 ` Keith Busch
2018-05-16 14:12 ` Keith Busch
2018-05-16 23:10 ` Ming Lei
2018-05-16 23:10 ` Ming Lei
2018-05-17 2:20 ` Keith Busch
2018-05-17 2:20 ` Keith Busch
2018-05-17 8:41 ` Christoph Hellwig
2018-05-17 8:41 ` Christoph Hellwig
2018-05-17 14:20 ` Keith Busch
2018-05-17 14:20 ` Keith Busch
2018-05-17 14:20 ` Keith Busch
2018-05-17 14:23 ` Johannes Thumshirn
2018-05-17 14:23 ` Johannes Thumshirn
2018-05-17 14:23 ` Johannes Thumshirn
2018-05-18 16:28 ` Keith Busch
2018-05-18 16:28 ` Keith Busch
2018-05-18 16:28 ` Keith Busch
2018-05-22 7:35 ` Johannes Thumshirn
2018-05-22 7:35 ` Johannes Thumshirn
2018-05-22 7:35 ` Johannes Thumshirn
2018-05-18 0:20 ` Ming Lei
2018-05-18 0:20 ` Ming Lei
2018-05-18 1:01 ` Ming Lei
2018-05-18 1:01 ` Ming Lei
2018-05-18 13:57 ` Keith Busch
2018-05-18 13:57 ` Keith Busch
2018-05-18 16:58 ` Jens Axboe
2018-05-18 16:58 ` Jens Axboe
2018-05-18 22:26 ` Ming Lei
2018-05-18 22:26 ` Ming Lei
2018-05-18 23:45 ` Keith Busch
2018-05-18 23:45 ` Keith Busch
2018-05-18 23:51 ` Ming Lei [this message]
2018-05-18 23:51 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518235128.GA19799@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jianchao.w.wang@oracle.com \
--cc=keith.busch@intel.com \
--cc=keith.busch@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=loberman@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.