From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: jarkko.sakkinen@linux.intel.com, linux-integrity@vger.kernel.org
Subject: Re: [PATCH] tpm: fix race condition in tpm_common_write()
Date: Tue, 22 May 2018 14:07:24 -0600 [thread overview]
Message-ID: <20180522200723.GE3311@ziepe.ca> (raw)
In-Reply-To: <152701036671.19968.17347263774570787595.stgit@tstruk-mobl1.jf.intel.com>
On Tue, May 22, 2018 at 10:32:46AM -0700, Tadeusz Struk wrote:
> There is a race condition in tpm_common_write function allowing two
> threads on the same /dev/tpm<N>, or two different applications on
> the same /dev/tpmrm<N> to overwrite eachother requests/responses.
>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> ---
> drivers/char/tpm/tpm-dev-common.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
I didn't see any reasn for data_pending to be an atomic, ever use case
is near the buffer_mutex, can you respin this patch to just drop that
completely and only manipulate it within the lock?
Jason
next prev parent reply other threads:[~2018-05-22 20:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 17:32 [PATCH] tpm: fix race condition in tpm_common_write() Tadeusz Struk
2018-05-22 20:07 ` Jason Gunthorpe [this message]
2018-05-22 20:26 ` Tadeusz Struk
2018-05-23 13:23 ` Jarkko Sakkinen
2018-05-23 13:23 ` Jarkko Sakkinen
2018-05-23 17:57 ` Tadeusz Struk
2018-05-23 17:57 ` Tadeusz Struk
2018-05-23 19:41 ` Jason Gunthorpe
2018-05-23 19:41 ` Jason Gunthorpe
2018-05-30 11:01 ` Jarkko Sakkinen
2018-05-30 11:01 ` Jarkko Sakkinen
2018-05-30 11:01 ` Jarkko Sakkinen
2018-05-30 11:01 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2018-08-08 12:35 Jarkko Sakkinen
2018-08-10 14:10 ` Greg KH
2018-08-10 16:44 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522200723.GE3311@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.