From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] tpm: fix race condition in tpm_common_write()
Date: Wed, 23 May 2018 13:41:15 -0600 [thread overview]
Message-ID: <20180523194115.GC8705@ziepe.ca> (raw)
In-Reply-To: <fb9c3d0c-d6fe-25ee-6452-92ade053c75a@intel.com>
On Wed, May 23, 2018 at 10:57:07AM -0700, Tadeusz Struk wrote:
> On 05/23/2018 06:23 AM, Jarkko Sakkinen wrote:
> > Ouch o_O Do you have a fixes tag for this one?
> >
>
> This one is quite tricky.
> The original bug was introduced by abce9ac292e13 (tpm: Propagate error from tpm_transmit to fix a timeout hang)
> and the code back then was in drivers/char/tpm/tpm-interface.c file
No, it has been wrong since before git history started, so just use
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
All the other commits you listed are just moving the bad code around
to new files.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: jgg@ziepe.ca (Jason Gunthorpe)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] tpm: fix race condition in tpm_common_write()
Date: Wed, 23 May 2018 13:41:15 -0600 [thread overview]
Message-ID: <20180523194115.GC8705@ziepe.ca> (raw)
In-Reply-To: <fb9c3d0c-d6fe-25ee-6452-92ade053c75a@intel.com>
On Wed, May 23, 2018 at 10:57:07AM -0700, Tadeusz Struk wrote:
> On 05/23/2018 06:23 AM, Jarkko Sakkinen wrote:
> > Ouch o_O Do you have a fixes tag for this one?
> >
>
> This one is quite tricky.
> The original bug was introduced by abce9ac292e13 (tpm: Propagate error from tpm_transmit to fix a timeout hang)
> and the code back then was in drivers/char/tpm/tpm-interface.c file
No, it has been wrong since before git history started, so just use
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
All the other commits you listed are just moving the bad code around
to new files.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-05-23 19:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 17:32 [PATCH] tpm: fix race condition in tpm_common_write() Tadeusz Struk
2018-05-22 20:07 ` Jason Gunthorpe
2018-05-22 20:26 ` Tadeusz Struk
2018-05-23 13:23 ` Jarkko Sakkinen
2018-05-23 13:23 ` Jarkko Sakkinen
2018-05-23 17:57 ` Tadeusz Struk
2018-05-23 17:57 ` Tadeusz Struk
2018-05-23 19:41 ` Jason Gunthorpe [this message]
2018-05-23 19:41 ` Jason Gunthorpe
2018-05-30 11:01 ` Jarkko Sakkinen
2018-05-30 11:01 ` Jarkko Sakkinen
2018-05-30 11:01 ` Jarkko Sakkinen
2018-05-30 11:01 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2018-08-08 12:35 Jarkko Sakkinen
2018-08-10 14:10 ` Greg KH
2018-08-10 16:44 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523194115.GC8705@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.