All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	syzbot+f116bc1994efe725d51b@syzkaller.appspotmail.com,
	kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	yoshfuji@linux-ipv6.org, dsahern@kernel.org,
	roopa@cumulusnetworks.com, linux-sctp@vger.kernel.org,
	Xin Long <lucien.xin@gmail.com>
Subject: Re: INFO: rcu detected stall in corrupted
Date: Wed, 23 May 2018 23:13:40 +0000	[thread overview]
Message-ID: <20180523231340.GN5488@localhost.localdomain> (raw)
In-Reply-To: <f8d0d282-1e75-d86a-8872-e32b57a6ec14@gmail.com>

On Mon, May 21, 2018 at 11:13:46AM -0700, Eric Dumazet wrote:
> 
> 
> On 05/21/2018 11:09 AM, David Miller wrote:
> > From: syzbot <syzbot+f116bc1994efe725d51b@syzkaller.appspotmail.com>
> > Date: Mon, 21 May 2018 11:05:02 -0700
> > 
> >>  find_match+0x244/0x13a0 net/ipv6/route.c:691
> >>  find_rr_leaf net/ipv6/route.c:729 [inline]
> >>  rt6_select net/ipv6/route.c:779 [inline]
> > 
> > Hmmm, endless loop in find_rr_leaf or similar?
> > 
> 
> 
> I do not think so, this really looks like SCTP specific 
> , we now have dozens of traces all sharing :
> 
>  sctp_transport_route+0xad/0x450 net/sctp/transport.c:293
>  sctp_packet_config+0xb89/0xfd0 net/sctp/output.c:123
>  sctp_outq_flush+0x79c/0x4370 net/sctp/outqueue.c:894
>  sctp_outq_uncork+0x6a/0x80 net/sctp/outqueue.c:776
>  sctp_cmd_interpreter net/sctp/sm_sideeffect.c:1820 [inline]
>  sctp_side_effects net/sctp/sm_sideeffect.c:1220 [inline]
>  sctp_do_sm+0x596/0x7160 net/sctp/sm_sideeffect.c:1191
>  sctp_generate_heartbeat_event+0x218/0x450 net/sctp/sm_sideeffect.c:406
>  call_timer_fn+0x230/0x940 kernel/time/timer.c:1326 
> 
> 
> Some kind of infinite loop.
> 
> When the hrtimer fires, it can point to any code that sits below but does not necessarily have a bug.

Agreed. Xin Long identified the root cause. syzkaller is setting too
aggressive parameters to SCTP RTO, leading to issues with the
heartbeat timer.


WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	syzbot+f116bc1994efe725d51b@syzkaller.appspotmail.com,
	kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com,
	yoshfuji@linux-ipv6.org, dsahern@kernel.org,
	roopa@cumulusnetworks.com, linux-sctp@vger.kernel.org,
	Xin Long <lucien.xin@gmail.com>
Subject: Re: INFO: rcu detected stall in corrupted
Date: Wed, 23 May 2018 20:13:40 -0300	[thread overview]
Message-ID: <20180523231340.GN5488@localhost.localdomain> (raw)
In-Reply-To: <f8d0d282-1e75-d86a-8872-e32b57a6ec14@gmail.com>

On Mon, May 21, 2018 at 11:13:46AM -0700, Eric Dumazet wrote:
> 
> 
> On 05/21/2018 11:09 AM, David Miller wrote:
> > From: syzbot <syzbot+f116bc1994efe725d51b@syzkaller.appspotmail.com>
> > Date: Mon, 21 May 2018 11:05:02 -0700
> > 
> >>  find_match+0x244/0x13a0 net/ipv6/route.c:691
> >>  find_rr_leaf net/ipv6/route.c:729 [inline]
> >>  rt6_select net/ipv6/route.c:779 [inline]
> > 
> > Hmmm, endless loop in find_rr_leaf or similar?
> > 
> 
> 
> I do not think so, this really looks like SCTP specific 
> , we now have dozens of traces all sharing :
> 
>  sctp_transport_route+0xad/0x450 net/sctp/transport.c:293
>  sctp_packet_config+0xb89/0xfd0 net/sctp/output.c:123
>  sctp_outq_flush+0x79c/0x4370 net/sctp/outqueue.c:894
>  sctp_outq_uncork+0x6a/0x80 net/sctp/outqueue.c:776
>  sctp_cmd_interpreter net/sctp/sm_sideeffect.c:1820 [inline]
>  sctp_side_effects net/sctp/sm_sideeffect.c:1220 [inline]
>  sctp_do_sm+0x596/0x7160 net/sctp/sm_sideeffect.c:1191
>  sctp_generate_heartbeat_event+0x218/0x450 net/sctp/sm_sideeffect.c:406
>  call_timer_fn+0x230/0x940 kernel/time/timer.c:1326 
> 
> 
> Some kind of infinite loop.
> 
> When the hrtimer fires, it can point to any code that sits below but does not necessarily have a bug.

Agreed. Xin Long identified the root cause. syzkaller is setting too
aggressive parameters to SCTP RTO, leading to issues with the
heartbeat timer.

  parent reply	other threads:[~2018-05-23 23:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 18:05 INFO: rcu detected stall in corrupted syzbot
2018-05-21 18:09 ` David Miller
2018-05-21 18:13   ` Eric Dumazet
2018-05-21 18:15     ` David Ahern
2018-05-23 23:13     ` Marcelo Ricardo Leitner [this message]
2018-05-23 23:13       ` Marcelo Ricardo Leitner
2018-05-24  9:02       ` Xin Long
2018-05-24  9:02         ` Xin Long
2018-05-26 15:28         ` Dmitry Vyukov
2018-05-26 15:28           ` Dmitry Vyukov
  -- strict thread matches above, loose matches on Subject: below --
2024-03-16  3:25 cheung wall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180523231340.GN5488@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=eric.dumazet@gmail.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=syzbot+f116bc1994efe725d51b@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.