All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	x86@kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits
Date: Fri, 25 May 2018 16:35:32 +0000	[thread overview]
Message-ID: <20180525163532.GA13399@kroah.com> (raw)
In-Reply-To: <20180525162307.GB28900@lst.de>

On Fri, May 25, 2018 at 06:23:07PM +0200, Christoph Hellwig wrote:
> On Fri, May 25, 2018 at 04:50:12PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 25, 2018 at 04:35:06PM +0200, Christoph Hellwig wrote:
> > > Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only 32-bits
> > > even if the device itself supports more.  Add a single bit flag to
> > > struct device (to be moved into the dma extension once we around it)
> > 
> > "once we around it"?  I don't understand, sorry.
> 
> Should be "once we get around it", which in proper grammar should
> probably be "once we get to it".  Anyway, the point is that right
> now struct device is bloated with a lot of fields for dma/iommu
> purposes and we need to clean this up.  It's been on my TODO list
> for a while.

Ah, makes sense, that's fine with me, I'd love to see that get cleaned
up.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	x86@kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits
Date: Fri, 25 May 2018 18:35:32 +0200	[thread overview]
Message-ID: <20180525163532.GA13399@kroah.com> (raw)
In-Reply-To: <20180525162307.GB28900@lst.de>

On Fri, May 25, 2018 at 06:23:07PM +0200, Christoph Hellwig wrote:
> On Fri, May 25, 2018 at 04:50:12PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, May 25, 2018 at 04:35:06PM +0200, Christoph Hellwig wrote:
> > > Various PCI bridges (VIA PCI, Xilinx PCIe) limit DMA to only 32-bits
> > > even if the device itself supports more.  Add a single bit flag to
> > > struct device (to be moved into the dma extension once we around it)
> > 
> > "once we around it"?  I don't understand, sorry.
> 
> Should be "once we get around it", which in proper grammar should
> probably be "once we get to it".  Anyway, the point is that right
> now struct device is bloated with a lot of fields for dma/iommu
> purposes and we need to clean this up.  It's been on my TODO list
> for a while.

Ah, makes sense, that's fine with me, I'd love to see that get cleaned
up.

thanks,

greg k-h

  reply	other threads:[~2018-05-25 16:35 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-25 14:35 refactor 32-bit dma limit quirks Christoph Hellwig
2018-05-25 14:35 ` Christoph Hellwig
2018-05-25 14:35 ` Christoph Hellwig
2018-05-25 14:35 ` [PATCH 1/7] core, dma-direct: add a flag 32-bit dma limits Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-25 14:50   ` Greg Kroah-Hartman
2018-05-25 14:50     ` Greg Kroah-Hartman
2018-05-25 14:50     ` Greg Kroah-Hartman
2018-05-25 16:23     ` Christoph Hellwig
2018-05-25 16:23       ` Christoph Hellwig
2018-05-25 16:23       ` Christoph Hellwig
2018-05-25 16:35       ` Greg Kroah-Hartman [this message]
2018-05-25 16:35         ` Greg Kroah-Hartman
2018-05-25 14:35 ` [PATCH 2/7] ia64: remove the dead iommu_sac_force variable Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-25 14:35 ` [PATCH 3/7] ia64: remove iommu_dma_supported Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-25 14:35 ` [PATCH 4/7] x86: remove a stray reference to pci-nommu.c Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-26 19:23   ` Thomas Gleixner
2018-05-26 19:23     ` Thomas Gleixner
2018-05-25 14:35 ` [PATCH 5/7] x86: remove the experimental forcesac boot option Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-28  6:07   ` Thomas Gleixner
2018-05-28  6:07     ` Thomas Gleixner
2018-05-28  6:07     ` Thomas Gleixner
2018-05-25 14:35 ` [PATCH 6/7] x86: remove the explicit nodac and allowdac option Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-28  6:08   ` Thomas Gleixner
2018-05-28  6:08     ` Thomas Gleixner
2018-05-28  6:08     ` Thomas Gleixner
2018-05-25 14:35 ` [PATCH 7/7] x86: switch the VIA 32-bit DMA quirk to use the struct device flag Christoph Hellwig
2018-05-25 14:35   ` Christoph Hellwig
2018-05-28  6:10   ` Thomas Gleixner
2018-05-28  6:10     ` Thomas Gleixner
2018-05-28  6:10     ` Thomas Gleixner
2018-05-28  6:19     ` Christoph Hellwig
2018-05-28  6:19       ` Christoph Hellwig
2018-05-28  6:19       ` Christoph Hellwig
2018-05-28  6:18       ` Thomas Gleixner
2018-05-28  6:18         ` Thomas Gleixner
2018-05-28  6:18         ` Thomas Gleixner
2018-05-28  6:27         ` Christoph Hellwig
2018-05-28  6:27           ` Christoph Hellwig
2018-05-28  6:27           ` Christoph Hellwig
2018-05-28  6:23           ` Thomas Gleixner
2018-05-28  6:23             ` Thomas Gleixner
2018-05-28  6:23             ` Thomas Gleixner
2018-05-28  8:39             ` Christoph Hellwig
2018-05-28  8:39               ` Christoph Hellwig
2018-05-28  8:39               ` Christoph Hellwig
2018-05-28  8:34               ` Thomas Gleixner
2018-05-28  8:34                 ` Thomas Gleixner
2018-05-28  8:34                 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180525163532.GA13399@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=fenghua.yu@intel.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.