From: olof@lixom.net (Olof Johansson)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/6] arm64: dts: amlogic: Add missing cooling device properties for CPUs
Date: Fri, 25 May 2018 14:10:25 -0700 [thread overview]
Message-ID: <20180525211025.c73zdcdtyuvlewng@localhost> (raw)
In-Reply-To: <2a2eb28da9fecf129f6bc0ab3d3748d9f4d25a29.1527225682.git.viresh.kumar@linaro.org>
On Fri, May 25, 2018 at 11:10:01AM +0530, Viresh Kumar wrote:
> The cooling device properties, like "#cooling-cells" and
> "dynamic-power-coefficient", should either be present for all the CPUs
> of a cluster or none. If these are present only for a subset of CPUs of
> a cluster then things will start falling apart as soon as the CPUs are
> brought online in a different order. For example, this will happen
> because the operating system looks for such properties in the CPU node
> it is trying to bring up, so that it can register a cooling device.
>
> Add such missing properties.
This seems awkward compared to just having one cooling-cells in the /cpus node
instead.
What's it used for? I don't see any properties in the device nodes on meson-gxm
that have any cooling-foo cells in them? So why should #cooling-cells be
needed?
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] arm64: dts: amlogic: Add missing cooling device properties for CPUs
Date: Fri, 25 May 2018 14:10:25 -0700 [thread overview]
Message-ID: <20180525211025.c73zdcdtyuvlewng@localhost> (raw)
In-Reply-To: <2a2eb28da9fecf129f6bc0ab3d3748d9f4d25a29.1527225682.git.viresh.kumar@linaro.org>
On Fri, May 25, 2018 at 11:10:01AM +0530, Viresh Kumar wrote:
> The cooling device properties, like "#cooling-cells" and
> "dynamic-power-coefficient", should either be present for all the CPUs
> of a cluster or none. If these are present only for a subset of CPUs of
> a cluster then things will start falling apart as soon as the CPUs are
> brought online in a different order. For example, this will happen
> because the operating system looks for such properties in the CPU node
> it is trying to bring up, so that it can register a cooling device.
>
> Add such missing properties.
This seems awkward compared to just having one cooling-cells in the /cpus node
instead.
What's it used for? I don't see any properties in the device nodes on meson-gxm
that have any cooling-foo cells in them? So why should #cooling-cells be
needed?
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: arm@kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
ionela.voinescu@arm.com,
Daniel Lezcano <daniel.lezcano@linaro.org>,
chris.redpath@arm.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] arm64: dts: amlogic: Add missing cooling device properties for CPUs
Date: Fri, 25 May 2018 14:10:25 -0700 [thread overview]
Message-ID: <20180525211025.c73zdcdtyuvlewng@localhost> (raw)
In-Reply-To: <2a2eb28da9fecf129f6bc0ab3d3748d9f4d25a29.1527225682.git.viresh.kumar@linaro.org>
On Fri, May 25, 2018 at 11:10:01AM +0530, Viresh Kumar wrote:
> The cooling device properties, like "#cooling-cells" and
> "dynamic-power-coefficient", should either be present for all the CPUs
> of a cluster or none. If these are present only for a subset of CPUs of
> a cluster then things will start falling apart as soon as the CPUs are
> brought online in a different order. For example, this will happen
> because the operating system looks for such properties in the CPU node
> it is trying to bring up, so that it can register a cooling device.
>
> Add such missing properties.
This seems awkward compared to just having one cooling-cells in the /cpus node
instead.
What's it used for? I don't see any properties in the device nodes on meson-gxm
that have any cooling-foo cells in them? So why should #cooling-cells be
needed?
-Olof
next prev parent reply other threads:[~2018-05-25 21:10 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 5:40 [PATCH 0/6] arm64: dts: Add missing cooling device properties for CPUs Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-05-25 5:40 ` [PATCH 1/6] arm64: dts: amlogic: " Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-05-25 21:10 ` Olof Johansson [this message]
2018-05-25 21:10 ` Olof Johansson
2018-05-25 21:10 ` Olof Johansson
2018-05-26 8:37 ` Neil Armstrong
2018-05-26 8:37 ` Neil Armstrong
2018-05-26 8:37 ` Neil Armstrong
2018-05-26 8:37 ` Neil Armstrong
2018-05-28 11:16 ` Viresh Kumar
2018-05-28 11:16 ` Viresh Kumar
2018-05-28 11:16 ` Viresh Kumar
2018-05-28 11:13 ` Viresh Kumar
2018-05-28 11:13 ` Viresh Kumar
2018-05-28 11:13 ` Viresh Kumar
2018-05-28 11:13 ` Viresh Kumar
2018-06-02 8:14 ` Olof Johansson
2018-06-02 8:14 ` Olof Johansson
2018-06-02 8:14 ` Olof Johansson
2018-06-05 4:37 ` Viresh Kumar
2018-06-05 4:37 ` Viresh Kumar
2018-06-05 4:37 ` Viresh Kumar
2018-05-25 5:40 ` [PATCH 2/6] arm64: dts: freescale: " Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-07-03 7:34 ` Shawn Guo
2018-07-03 7:34 ` Shawn Guo
2018-07-03 8:34 ` Viresh Kumar
2018-07-03 8:34 ` Viresh Kumar
2018-07-03 10:08 ` Shawn Guo
2018-07-03 10:08 ` Shawn Guo
2018-05-25 5:40 ` [PATCH 3/6] arm64: dts: hisilicon: " Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-05-26 18:00 ` Wei Xu
2018-05-26 18:00 ` Wei Xu
2018-05-26 18:00 ` Wei Xu
2018-05-26 18:21 ` Wei Xu
2018-05-26 18:21 ` Wei Xu
2018-05-26 18:21 ` Wei Xu
2018-07-18 5:58 ` Viresh Kumar
2018-07-18 5:58 ` Viresh Kumar
2018-07-18 15:32 ` Wei Xu
2018-07-18 15:32 ` Wei Xu
2018-07-18 15:32 ` Wei Xu
2018-05-25 5:40 ` [PATCH 4/6] arm64: dts: mediatek: " Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-07-02 16:56 ` Matthias Brugger
2018-07-02 16:56 ` Matthias Brugger
2018-05-25 5:40 ` [PATCH 5/6] arm64: dts: rockchip: " Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-06-15 11:23 ` Heiko Stübner
2018-06-15 11:23 ` Heiko Stübner
2018-05-25 5:40 ` [PATCH 6/6] arm64: dts: socionext: " Viresh Kumar
2018-05-25 5:40 ` Viresh Kumar
2018-06-01 3:25 ` Masahiro Yamada
2018-06-01 3:25 ` Masahiro Yamada
2018-06-04 7:14 ` Viresh Kumar
2018-06-04 7:14 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180525211025.c73zdcdtyuvlewng@localhost \
--to=olof@lixom.net \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.