All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 6/6] test: dm: Fix wrong aliases property names
Date: Sat, 26 May 2018 13:04:07 +0200	[thread overview]
Message-ID: <20180526110407.GA19851@example.com> (raw)
In-Reply-To: <CAPnjgZ10gTbnfxLMj9wTDjGCetrhJEMKJjRkOj3EkMdixxcgXQ@mail.gmail.com>

Hi Simon,

On Fri, May 25, 2018 at 08:07:37PM -0600, Simon Glass wrote:
> Hi,
> 
> On 24 May 2018 at 16:04, Eugeniu Rosca <roscaeugeniu@gmail.com> wrote:
> > Besides the above, it is not clear to me if your Reviewed-by applies to
> > to this patch partially (since you expressed some concerns) or applies
> > globally, in which case the concerns are not major?
> 
> It means that I've reviewed the patch and I'd like some changes, but
> don't want to review it after you have made those changes, so you
> should add the Reviewed-by tag when doing the next version.
> 
> But in this case your change is correct, so please don't worry. It's
> unfortunate that the uclass name needs a hypen, but I understand why.

Thanks for shedding light both on technical aspects and the review
process itself, which is very helpful.

Regarding the state of the whole patch-set, I think we reached a point
in which all the review comments have been handled. Please, let me know
if you still see any open topics. Otherwise, I will be waiting for
Tom's feedback and if it doesn't come in the next 1-2 weeks, I will send
a friendly reminder.

> Regards,
> Simon

Best regards,
Eugeniu.

  reply	other threads:[~2018-05-26 11:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-19 12:13 [U-Boot] [PATCH v3 1/6] kconfig: re-sync with Linux 4.17-rc4 Eugeniu Rosca
2018-05-19 12:13 ` [U-Boot] [PATCH v3 2/6] board: eets: pdu001: Fix wrong default value in Kconfig Eugeniu Rosca
2018-05-22  8:07   ` Felix Brack
2018-05-22  8:29     ` Eugeniu Rosca
2018-05-31 18:16   ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-05-19 12:13 ` [U-Boot] [PATCH v3 3/6] scripts/dtc: Update to upstream version v1.4.5-6-gc1e55a5513e9 Eugeniu Rosca
2018-05-31 18:16   ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-05-19 12:13 ` [U-Boot] [PATCH v3 4/6] scripts/dtc: Update to upstream version v1.4.6-9-gaadd0b65c987 Eugeniu Rosca
2018-05-31 18:16   ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-05-19 12:13 ` [U-Boot] [PATCH v3 5/6] scripts/dtc: Re-sync with Linux 4.17-rc4 Eugeniu Rosca
2018-05-31 18:16   ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-05-19 12:13 ` [U-Boot] [PATCH v3 6/6] test: dm: Fix wrong aliases property names Eugeniu Rosca
2018-05-22 23:30   ` Simon Glass
2018-05-24 22:04     ` Eugeniu Rosca
2018-05-26  2:07       ` Simon Glass
2018-05-26 11:04         ` Eugeniu Rosca [this message]
2018-05-27  0:53           ` Simon Glass
2018-05-31 18:16   ` [U-Boot] [U-Boot, v3, " Tom Rini
2018-05-21 10:59 ` [U-Boot] [PATCH v3 1/6] kconfig: re-sync with Linux 4.17-rc4 Petr Vorel
2018-05-21 14:29   ` Eugeniu Rosca
2018-05-31 18:16 ` [U-Boot] [U-Boot,v3,1/6] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180526110407.GA19851@example.com \
    --to=roscaeugeniu@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.