From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Felipe Balbi <balbi@kernel.org>,
davem@davemloft.net,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device
Date: Sun, 27 May 2018 07:48:47 +0200 [thread overview]
Message-ID: <20180527054847.GB22105@gmail.com> (raw)
In-Reply-To: <20180526205652.GA25534@kroah.com>
On Sat, May 26, 2018 at 10:56:52PM +0200, Greg Kroah-Hartman wrote:
> On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote:
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>
> I can't take patches without any changelog text. And why would you
> submit a patch over 1000 lines without any?
I'm sorry, obviously not much went well for me yesterday.
The changlelog was "fixup:ed" away and now I noticed that my
patch version history did not follow for v2.
Is it better to send a v3 with updated version history or wait for more
comments?
I'll start review my patches better before sending them.
Thank you for your time and comments.
>
> Please fix.
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Felipe Balbi <balbi@kernel.org>,
davem@davemloft.net,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [1/3] usb: gadget: ccid: add support for USB CCID Gadget Device
Date: Sun, 27 May 2018 07:48:47 +0200 [thread overview]
Message-ID: <20180527054847.GB22105@gmail.com> (raw)
On Sat, May 26, 2018 at 10:56:52PM +0200, Greg Kroah-Hartman wrote:
> On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote:
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>
> I can't take patches without any changelog text. And why would you
> submit a patch over 1000 lines without any?
I'm sorry, obviously not much went well for me yesterday.
The changlelog was "fixup:ed" away and now I noticed that my
patch version history did not follow for v2.
Is it better to send a v3 with updated version history or wait for more
comments?
I'll start review my patches better before sending them.
Thank you for your time and comments.
>
> Please fix.
>
> thanks,
>
> greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Felipe Balbi <balbi@kernel.org>,
davem@davemloft.net,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Ruslan Bilovol <ruslan.bilovol@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device
Date: Sun, 27 May 2018 07:48:47 +0200 [thread overview]
Message-ID: <20180527054847.GB22105@gmail.com> (raw)
In-Reply-To: <20180526205652.GA25534@kroah.com>
On Sat, May 26, 2018 at 10:56:52PM +0200, Greg Kroah-Hartman wrote:
> On Sat, May 26, 2018 at 10:33:59PM +0200, Marcus Folkesson wrote:
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>
> I can't take patches without any changelog text. And why would you
> submit a patch over 1000 lines without any?
I'm sorry, obviously not much went well for me yesterday.
The changlelog was "fixup:ed" away and now I noticed that my
patch version history did not follow for v2.
Is it better to send a v3 with updated version history or wait for more
comments?
I'll start review my patches better before sending them.
Thank you for your time and comments.
>
> Please fix.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2018-05-27 5:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-26 20:33 [PATCH 1/3] usb: gadget: ccid: add support for USB CCID Gadget Device Marcus Folkesson
2018-05-26 20:33 ` Marcus Folkesson
2018-05-26 20:33 ` [1/3] " Marcus Folkesson
2018-05-26 20:34 ` [PATCH 2/3] Documentation: usb: add documentation " Marcus Folkesson
2018-05-26 20:34 ` Marcus Folkesson
2018-05-26 20:34 ` [2/3] " Marcus Folkesson
2018-05-26 20:34 ` [PATCH 3/3] MAINTAINERS: add " Marcus Folkesson
2018-05-26 20:34 ` Marcus Folkesson
2018-05-26 20:34 ` [3/3] " Marcus Folkesson
2018-05-26 20:56 ` [PATCH 1/3] usb: gadget: ccid: add support for " Greg Kroah-Hartman
2018-05-26 20:56 ` Greg Kroah-Hartman
2018-05-26 20:56 ` [1/3] " Greg Kroah-Hartman
2018-05-27 5:48 ` Marcus Folkesson [this message]
2018-05-27 5:48 ` [PATCH 1/3] " Marcus Folkesson
2018-05-27 5:48 ` [1/3] " Marcus Folkesson
2018-05-27 6:39 ` [PATCH 1/3] " Greg Kroah-Hartman
2018-05-27 6:39 ` Greg Kroah-Hartman
2018-05-27 6:39 ` [1/3] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180527054847.GB22105@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=balbi@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=rdunlap@infradead.org \
--cc=ruslan.bilovol@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.