* [Qemu-devel] [PATCH] bochs-display: add missing break
@ 2018-05-25 4:53 Gerd Hoffmann
2018-05-27 9:15 ` Ján Tomko
2018-05-27 20:01 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2018-05-25 4:53 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Fixes: CID 1391291
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/bochs-display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index c33524b558..1187d77576 100644
--- a/hw/display/bochs-display.c
+++ b/hw/display/bochs-display.c
@@ -158,6 +158,7 @@ static int bochs_display_get_mode(BochsDisplayState *s,
/* best effort: support native endianess only */
mode->format = PIXMAN_r5g6b5;
mode->bytepp = 2;
+ break;
case 32:
mode->format = s->big_endian_fb
? PIXMAN_BE_x8r8g8b8
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] bochs-display: add missing break
2018-05-25 4:53 [Qemu-devel] [PATCH] bochs-display: add missing break Gerd Hoffmann
@ 2018-05-27 9:15 ` Ján Tomko
2018-05-27 20:01 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Ján Tomko @ 2018-05-27 9:15 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
On Fri, May 25, 2018 at 06:53:44AM +0200, Gerd Hoffmann wrote:
>Fixes: CID 1391291
>Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>---
> hw/display/bochs-display.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] bochs-display: add missing break
2018-05-25 4:53 [Qemu-devel] [PATCH] bochs-display: add missing break Gerd Hoffmann
2018-05-27 9:15 ` Ján Tomko
@ 2018-05-27 20:01 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-27 20:01 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On 05/25/2018 01:53 AM, Gerd Hoffmann wrote:
> Fixes: CID 1391291
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> hw/display/bochs-display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
> index c33524b558..1187d77576 100644
> --- a/hw/display/bochs-display.c
> +++ b/hw/display/bochs-display.c
> @@ -158,6 +158,7 @@ static int bochs_display_get_mode(BochsDisplayState *s,
> /* best effort: support native endianess only */
> mode->format = PIXMAN_r5g6b5;
> mode->bytepp = 2;
> + break;
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> case 32:
> mode->format = s->big_endian_fb
> ? PIXMAN_BE_x8r8g8b8
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-27 20:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-25 4:53 [Qemu-devel] [PATCH] bochs-display: add missing break Gerd Hoffmann
2018-05-27 9:15 ` Ján Tomko
2018-05-27 20:01 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.