From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 1/2] ARM: imx53: add secure-reg-access support for PMU
Date: Mon, 28 May 2018 15:20:35 +0800 [thread overview]
Message-ID: <20180528072034.GB3143@dragon> (raw)
In-Reply-To: <20180528064131.y5burm5kakiazaq4@earth.universe>
On Mon, May 28, 2018 at 08:41:31AM +0200, Sebastian Reichel wrote:
> > Are you saying this is a very specific setup required by i.MX53 only?
>
> Yes, all other SoCs supported by Linux ARM PMU counters driver can
> just use the registers without having to enable platform specific
> bits first.
>
> > In that case, I can live with it.
>
> What about the DT node? I did not add it, since this is a i.MX53
> specific workaround anyways.
What you are adding here is secure-reg-access property, which has an
defined meaning in PMU binding doc. I'm not really sure if it's
appropriate to use the property as a condition for DBGEN bit setup.
Or can we set up the bit regardless of the property?
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>, Ian Ray <ian.ray@ge.com>,
Nandor Han <nandor.han@ge.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCHv4 1/2] ARM: imx53: add secure-reg-access support for PMU
Date: Mon, 28 May 2018 15:20:35 +0800 [thread overview]
Message-ID: <20180528072034.GB3143@dragon> (raw)
In-Reply-To: <20180528064131.y5burm5kakiazaq4@earth.universe>
On Mon, May 28, 2018 at 08:41:31AM +0200, Sebastian Reichel wrote:
> > Are you saying this is a very specific setup required by i.MX53 only?
>
> Yes, all other SoCs supported by Linux ARM PMU counters driver can
> just use the registers without having to enable platform specific
> bits first.
>
> > In that case, I can live with it.
>
> What about the DT node? I did not add it, since this is a i.MX53
> specific workaround anyways.
What you are adding here is secure-reg-access property, which has an
defined meaning in PMU binding doc. I'm not really sure if it's
appropriate to use the property as a condition for DBGEN bit setup.
Or can we set up the bit regardless of the property?
Shawn
next prev parent reply other threads:[~2018-05-28 7:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 12:39 [PATCHv4 0/2] Improved perf support for imx53/ppd Sebastian Reichel
2018-02-12 12:39 ` Sebastian Reichel
2018-02-12 12:39 ` [PATCHv4 1/2] ARM: imx53: add secure-reg-access support for PMU Sebastian Reichel
2018-02-12 12:39 ` Sebastian Reichel
2018-02-12 12:48 ` Fabio Estevam
2018-02-12 12:48 ` Fabio Estevam
2018-02-24 7:45 ` Shawn Guo
2018-02-24 7:45 ` Shawn Guo
2018-02-26 13:47 ` Sebastian Reichel
2018-02-26 13:47 ` Sebastian Reichel
2018-02-27 1:10 ` Shawn Guo
2018-02-27 1:10 ` Shawn Guo
2018-02-27 10:17 ` Sebastian Reichel
2018-02-27 10:17 ` Sebastian Reichel
2018-05-25 15:45 ` Sebastian Reichel
2018-05-25 15:45 ` Sebastian Reichel
2018-05-28 2:26 ` Shawn Guo
2018-05-28 2:26 ` Shawn Guo
2018-05-28 6:41 ` Sebastian Reichel
2018-05-28 6:41 ` Sebastian Reichel
2018-05-28 7:20 ` Shawn Guo [this message]
2018-05-28 7:20 ` Shawn Guo
2018-05-28 15:50 ` Sebastian Reichel
2018-05-28 15:50 ` Sebastian Reichel
2018-06-18 4:00 ` Fabio Estevam
2018-06-18 4:00 ` Fabio Estevam
2018-02-12 12:39 ` [PATCHv4 2/2] ARM: dts: imx53: PPD: Enable secure-reg-access Sebastian Reichel
2018-02-12 12:39 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528072034.GB3143@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.