All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v4 06/11] iomap: Add write_{begin, end} iomap operations
Date: Mon, 28 May 2018 15:02:06 +0200	[thread overview]
Message-ID: <20180528130206.GA14706@lst.de> (raw)
In-Reply-To: <CAHpGcM+m=Ar=_WO31J3OqdvGPHq3Ozq-QtAYKt0y8WL6+ybWtQ@mail.gmail.com>

On Fri, May 25, 2018 at 07:58:14PM +0200, Andreas Gr?nbacher wrote:
> > The right way to deal with that is to make
> > inline data an explicit iomap type (done in my next posting of the
> > buffer head removal series), and then have iomap_begin find the data,
> > kmap it and return it in the iomap, with iomap_end doing any fixups.
> 
> I see what you mean. How would iomap_write_actor deal with
> IOMAP_INLINE -- just skip iomap_write_begin and iomap_write_end and
> grab the page from the iomap?

I would add a data pointer to struct iomap and pass the data back
from there.  We'll still need most of iomap_write_begin / iomap_write_end,
but just copy the data from the iomap instead of reading it from disk.
Note that the block_write_begin code already handles that case for
the get_blocks path.



WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Dave Chinner <david@fromorbit.com>,
	cluster-devel <cluster-devel@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH v4 06/11] iomap: Add write_{begin,end} iomap operations
Date: Mon, 28 May 2018 15:02:06 +0200	[thread overview]
Message-ID: <20180528130206.GA14706@lst.de> (raw)
In-Reply-To: <CAHpGcM+m=Ar=_WO31J3OqdvGPHq3Ozq-QtAYKt0y8WL6+ybWtQ@mail.gmail.com>

On Fri, May 25, 2018 at 07:58:14PM +0200, Andreas Gr�nbacher wrote:
> > The right way to deal with that is to make
> > inline data an explicit iomap type (done in my next posting of the
> > buffer head removal series), and then have iomap_begin find the data,
> > kmap it and return it in the iomap, with iomap_end doing any fixups.
> 
> I see what you mean. How would iomap_write_actor deal with
> IOMAP_INLINE -- just skip iomap_write_begin and iomap_write_end and
> grab the page from the iomap?

I would add a data pointer to struct iomap and pass the data back
from there.  We'll still need most of iomap_write_begin / iomap_write_end,
but just copy the data from the iomap instead of reading it from disk.
Note that the block_write_begin code already handles that case for
the get_blocks path.

  reply	other threads:[~2018-05-28 13:02 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-14 15:36 [Cluster-devel] [PATCH v4 00/11] gfs2 iomap write support Andreas Gruenbacher
2018-05-14 15:36 ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 01/11] gfs2: Update find_metapath comment Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 02/11] gfs2: hole_size improvement Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 03/11] gfs2: gfs2_stuffed_write_end cleanup Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 04/11] gfs2: Remove ordered write mode handling from gfs2_trans_add_data Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 05/11] gfs2: Iomap cleanups and improvements Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 06/11] iomap: Add write_{begin, end} iomap operations Andreas Gruenbacher
2018-05-14 15:36   ` [PATCH v4 06/11] iomap: Add write_{begin,end} " Andreas Gruenbacher
2018-05-15  1:11   ` [Cluster-devel] [PATCH v4 06/11] iomap: Add write_{begin, end} " Dave Chinner
2018-05-15  1:11     ` [PATCH v4 06/11] iomap: Add write_{begin,end} " Dave Chinner
2018-05-15  7:22     ` [Cluster-devel] [PATCH v4 06/11] iomap: Add write_{begin, end} " Christoph Hellwig
2018-05-15  7:22       ` [PATCH v4 06/11] iomap: Add write_{begin,end} " Christoph Hellwig
2018-05-15  8:16       ` [Cluster-devel] [PATCH v4 06/11] iomap: Add write_{begin, end} " Andreas Gruenbacher
2018-05-15  8:16         ` [PATCH v4 06/11] iomap: Add write_{begin,end} " Andreas Gruenbacher
2018-05-18 16:04         ` [Cluster-devel] [PATCH v4 06/11] iomap: Add write_{begin, end} " Christoph Hellwig
2018-05-18 16:04           ` [PATCH v4 06/11] iomap: Add write_{begin,end} " Christoph Hellwig
2018-05-25 17:58           ` [Cluster-devel] [PATCH v4 06/11] iomap: Add write_{begin, end} " Andreas Grünbacher
2018-05-25 17:58             ` [PATCH v4 06/11] iomap: Add write_{begin,end} " Andreas Grünbacher
2018-05-28 13:02             ` Christoph Hellwig [this message]
2018-05-28 13:02               ` Christoph Hellwig
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 07/11] gfs2: iomap buffered write support Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 08/11] gfs2: gfs2_extent_length cleanup Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 09/11] gfs2: iomap direct I/O support Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-15  7:31   ` [Cluster-devel] " Christoph Hellwig
2018-05-15  7:31     ` Christoph Hellwig
2018-05-16 20:36     ` [Cluster-devel] " Andreas Gruenbacher
2018-05-16 20:36       ` Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 10/11] gfs2: Remove gfs2_write_{begin, end} Andreas Gruenbacher
2018-05-14 15:36   ` [PATCH v4 10/11] gfs2: Remove gfs2_write_{begin,end} Andreas Gruenbacher
2018-05-14 15:36 ` [Cluster-devel] [PATCH v4 11/11] iomap: Complete partial direct I/O writes synchronously Andreas Gruenbacher
2018-05-14 15:36   ` Andreas Gruenbacher
2018-05-15  7:24   ` [Cluster-devel] " Christoph Hellwig
2018-05-15  7:24     ` Christoph Hellwig
2018-05-16 20:27     ` [Cluster-devel] " Andreas Gruenbacher
2018-05-16 20:27       ` Andreas Gruenbacher
2018-05-18 15:56       ` [Cluster-devel] " Christoph Hellwig
2018-05-18 15:56         ` Christoph Hellwig
2018-05-18 18:35         ` [Cluster-devel] " Andreas Grünbacher
2018-05-18 18:35           ` Andreas Grünbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180528130206.GA14706@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.