All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] riscv: pass machine size to sparse
Date: Mon, 28 May 2018 23:11:27 -0700	[thread overview]
Message-ID: <20180529061127.GA20005@infradead.org> (raw)
In-Reply-To: <20180528163505.15698-1-luc.vanoostenryck@gmail.com>

On Mon, May 28, 2018 at 06:35:05PM +0200, Luc Van Oostenryck wrote:
> By default, sparse assumes a 64bit machine when compiled on x86-64
> and 32bit when compiled on anything else.
> 
> This can of course create all sort of problems when this doesn't
> correspond to the target's machine size, like issuing false
> warnings like: 'shift too big (32) for type unsigned long' or
> is 64bit while sparse was compiled on a 32bit machine, or worse,
> to not emit legitimate warnings.
> 
> Fix this by passing the appropriate -m32/-m64 flag to sparse.

Can we please move this to the common Kbuild code using the
CONFIG_64BIT syombol?  This really should not need boiler plate in
every architecture.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	Albert Ou <albert@sifive.com>,
	yamada.masahiro@socionext.com, michal.lkml@markovi.net
Subject: Re: [PATCH] riscv: pass machine size to sparse
Date: Mon, 28 May 2018 23:11:27 -0700	[thread overview]
Message-ID: <20180529061127.GA20005@infradead.org> (raw)
In-Reply-To: <20180528163505.15698-1-luc.vanoostenryck@gmail.com>

On Mon, May 28, 2018 at 06:35:05PM +0200, Luc Van Oostenryck wrote:
> By default, sparse assumes a 64bit machine when compiled on x86-64
> and 32bit when compiled on anything else.
> 
> This can of course create all sort of problems when this doesn't
> correspond to the target's machine size, like issuing false
> warnings like: 'shift too big (32) for type unsigned long' or
> is 64bit while sparse was compiled on a 32bit machine, or worse,
> to not emit legitimate warnings.
> 
> Fix this by passing the appropriate -m32/-m64 flag to sparse.

Can we please move this to the common Kbuild code using the
CONFIG_64BIT syombol?  This really should not need boiler plate in
every architecture.

  reply	other threads:[~2018-05-29  6:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28 16:35 [PATCH] riscv: pass machine size to sparse Luc Van Oostenryck
2018-05-28 16:35 ` Luc Van Oostenryck
2018-05-29  6:11 ` Christoph Hellwig [this message]
2018-05-29  6:11   ` Christoph Hellwig
2018-05-29  6:14   ` Masahiro Yamada
2018-05-29  6:14     ` Masahiro Yamada
2018-05-31 12:09     ` Palmer Dabbelt
2018-05-31 12:09       ` Palmer Dabbelt
2018-05-31 15:35       ` Luc Van Oostenryck
2018-05-31 15:35         ` Luc Van Oostenryck
2018-06-05  1:18         ` Palmer Dabbelt
2018-06-05  1:18           ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529061127.GA20005@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.