From: Greg KH <gregkh@linuxfoundation.org>
To: Oleksandr Shamray <oleksandrs@mellanox.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
openbmc@lists.ozlabs.org, joel@jms.id.au, jiri@resnulli.us,
tklauser@distanz.ch, linux-serial@vger.kernel.org,
vadimp@mellanox.com, system-sw-low-level@mellanox.com,
robh+dt@kernel.org, openocd-devel-owner@lists.sourceforge.net,
linux-api@vger.kernel.org, davem@davemloft.net,
mchehab@kernel.org
Subject: Re: [patch v23 1/4] drivers: jtag: Add JTAG core driver
Date: Tue, 29 May 2018 15:09:48 +0200 [thread overview]
Message-ID: <20180529130948.GC30119@kroah.com> (raw)
In-Reply-To: <1527594545-19870-2-git-send-email-oleksandrs@mellanox.com>
On Tue, May 29, 2018 at 02:49:02PM +0300, Oleksandr Shamray wrote:
> +static int jtag_release(struct inode *inode, struct file *file)
> +{
> + return 0;
> +}
If you do not do anything, then there is no need to have this callback
at all, right?
> +/**
> + * enum jtag_endstate:
> + *
> + * @JTAG_STATE_IDLE: JTAG state machine IDLE state
> + * @JTAG_STATE_PAUSEIR: JTAG state machine PAUSE_IR state
> + * @JTAG_STATE_PAUSEDR: JTAG state machine PAUSE_DR state
> + */
> +enum jtag_endstate {
> + JTAG_STATE_IDLE,
> + JTAG_STATE_PAUSEIR,
> + JTAG_STATE_PAUSEDR,
Be specific with these enums, set them to a value so you know all is
good. Userspace C compilers can be funny at times.
Otherwise, looks really good, nice work.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch v23 1/4] drivers: jtag: Add JTAG core driver
Date: Tue, 29 May 2018 15:09:48 +0200 [thread overview]
Message-ID: <20180529130948.GC30119@kroah.com> (raw)
In-Reply-To: <1527594545-19870-2-git-send-email-oleksandrs@mellanox.com>
On Tue, May 29, 2018 at 02:49:02PM +0300, Oleksandr Shamray wrote:
> +static int jtag_release(struct inode *inode, struct file *file)
> +{
> + return 0;
> +}
If you do not do anything, then there is no need to have this callback
at all, right?
> +/**
> + * enum jtag_endstate:
> + *
> + * @JTAG_STATE_IDLE: JTAG state machine IDLE state
> + * @JTAG_STATE_PAUSEIR: JTAG state machine PAUSE_IR state
> + * @JTAG_STATE_PAUSEDR: JTAG state machine PAUSE_DR state
> + */
> +enum jtag_endstate {
> + JTAG_STATE_IDLE,
> + JTAG_STATE_PAUSEIR,
> + JTAG_STATE_PAUSEDR,
Be specific with these enums, set them to a value so you know all is
good. Userspace C compilers can be funny at times.
Otherwise, looks really good, nice work.
greg k-h
next prev parent reply other threads:[~2018-05-29 13:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 11:49 [patch v23 0/4] JTAG driver introduction Oleksandr Shamray
2018-05-29 11:49 ` Oleksandr Shamray
2018-05-29 11:49 ` [patch v23 1/4] drivers: jtag: Add JTAG core driver Oleksandr Shamray
2018-05-29 11:49 ` Oleksandr Shamray
2018-05-29 13:09 ` Greg KH [this message]
2018-05-29 13:09 ` Greg KH
2018-05-29 11:49 ` [patch v23 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver Oleksandr Shamray
2018-05-29 11:49 ` Oleksandr Shamray
2018-05-29 13:11 ` Greg KH
2018-05-29 13:11 ` Greg KH
2018-05-29 11:49 ` [patch v23 3/4] Documentation: jtag: Add bindings for " Oleksandr Shamray
2018-05-29 11:49 ` Oleksandr Shamray
2018-05-29 11:49 ` [patch v23 4/4] Documentation: jtag: Add ABI documentation Oleksandr Shamray
2018-05-29 11:49 ` Oleksandr Shamray
2018-05-29 13:08 ` Greg KH
2018-05-29 13:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529130948.GC30119@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jiri@resnulli.us \
--cc=joel@jms.id.au \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=oleksandrs@mellanox.com \
--cc=openbmc@lists.ozlabs.org \
--cc=openocd-devel-owner@lists.sourceforge.net \
--cc=robh+dt@kernel.org \
--cc=system-sw-low-level@mellanox.com \
--cc=tklauser@distanz.ch \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.