From: Thierry Reding <thierry.reding@gmail.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused
Date: Tue, 29 May 2018 16:38:20 +0200 [thread overview]
Message-ID: <20180529143820.GD22634@ulmo> (raw)
In-Reply-To: <20180528163243.538de32f@bbrezillon>
[-- Attachment #1.1: Type: text/plain, Size: 1078 bytes --]
On Mon, May 28, 2018 at 04:32:43PM +0200, Boris Brezillon wrote:
> +Thierry
>
> Hi Arnd,
>
> On Fri, 25 May 2018 17:50:15 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > These two functions are unused in some configurations, and using __maybe_unused
> > is the easiest way to shut up the harmless warnings:
> >
> > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' defined but not used [-Werror=unused-function]
> > static int cdns_dsi_suspend(struct device *dev)
> > ^~~~~~~~~~~~~~~~
> > drivers/gpu/drm/bridge/cdns-dsi.c:1340:12: error: 'cdns_dsi_resume' defined but not used [-Werror=unused-function]
> > static int cdns_dsi_resume(struct device *dev)
> >
> > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Hm, I thought such a patch had already been applied by Thierry [1].
>
> [1]https://www.spinics.net/lists/dri-devel/msg174363.html
Yeah, that's in drm-misc-next, but didn't seem to have made it into
linux-next until today.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
David Airlie <airlied@linux.ie>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Eric Anholt <eric@anholt.net>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused
Date: Tue, 29 May 2018 16:38:20 +0200 [thread overview]
Message-ID: <20180529143820.GD22634@ulmo> (raw)
In-Reply-To: <20180528163243.538de32f@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]
On Mon, May 28, 2018 at 04:32:43PM +0200, Boris Brezillon wrote:
> +Thierry
>
> Hi Arnd,
>
> On Fri, 25 May 2018 17:50:15 +0200
> Arnd Bergmann <arnd@arndb.de> wrote:
>
> > These two functions are unused in some configurations, and using __maybe_unused
> > is the easiest way to shut up the harmless warnings:
> >
> > drivers/gpu/drm/bridge/cdns-dsi.c:1353:12: error: 'cdns_dsi_suspend' defined but not used [-Werror=unused-function]
> > static int cdns_dsi_suspend(struct device *dev)
> > ^~~~~~~~~~~~~~~~
> > drivers/gpu/drm/bridge/cdns-dsi.c:1340:12: error: 'cdns_dsi_resume' defined but not used [-Werror=unused-function]
> > static int cdns_dsi_resume(struct device *dev)
> >
> > Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Hm, I thought such a patch had already been applied by Thierry [1].
>
> [1]https://www.spinics.net/lists/dri-devel/msg174363.html
Yeah, that's in drm-misc-next, but didn't seem to have made it into
linux-next until today.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-29 14:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 15:50 [PATCH 1/8] drm/sun4i: mark PM functions as __maybe_unused Arnd Bergmann
2018-05-25 15:50 ` Arnd Bergmann
2018-05-25 15:50 ` Arnd Bergmann
2018-05-25 15:50 ` [PATCH 2/8] drm/amdgpu: fix 32-bit build warning Arnd Bergmann
2018-05-28 9:47 ` Oded Gabbay
2018-05-28 9:47 ` Oded Gabbay
2018-05-25 15:50 ` [PATCH 3/8] drm/xen-front: " Arnd Bergmann
2018-05-29 5:58 ` Oleksandr Andrushchenko
2018-05-29 5:58 ` [Xen-devel] " Oleksandr Andrushchenko
2018-05-29 5:58 ` Oleksandr Andrushchenko
2018-05-29 7:59 ` Arnd Bergmann
2018-05-29 7:59 ` [Xen-devel] " Arnd Bergmann
2018-05-29 7:59 ` Arnd Bergmann
2018-05-25 15:50 ` Arnd Bergmann
2018-05-25 15:50 ` [PATCH 4/8] drm/rcar-du: fix merge conflict for state->alpha Arnd Bergmann
2018-05-25 17:23 ` Laurent Pinchart
2018-05-25 15:50 ` [PATCH 5/8] drm/v3d: add CONFIG_MMU dependency Arnd Bergmann
2018-05-30 19:18 ` Eric Anholt
2018-05-30 19:18 ` Eric Anholt
2018-05-25 15:50 ` [PATCH 6/8] drm/exynos: fix scaler_task_done return type Arnd Bergmann
2018-05-25 15:50 ` Arnd Bergmann
2018-05-25 15:50 ` Arnd Bergmann
2018-05-25 15:50 ` [PATCH 7/8] drm/bridge: fix dependency for lvds-encoder Arnd Bergmann
2018-05-28 7:47 ` Linus Walleij
2018-05-28 7:47 ` Linus Walleij
2018-05-28 8:02 ` Laurent Pinchart
2018-05-28 8:02 ` Laurent Pinchart
2018-05-28 8:06 ` Daniel Vetter
2018-05-28 8:06 ` Daniel Vetter
2018-05-28 11:10 ` Arnd Bergmann
2018-05-28 11:10 ` Arnd Bergmann
2018-05-25 15:50 ` [PATCH 8/8] drm/bridge: cdns: mark PM functions as __maybe_unused Arnd Bergmann
2018-05-28 14:32 ` Boris Brezillon
2018-05-28 14:32 ` Boris Brezillon
2018-05-29 14:38 ` Thierry Reding [this message]
2018-05-29 14:38 ` Thierry Reding
2018-05-28 9:19 ` [PATCH 1/8] drm/sun4i: " Maxime Ripard
2018-05-28 9:19 ` Maxime Ripard
2018-05-28 9:19 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529143820.GD22634@ulmo \
--to=thierry.reding@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=boris.brezillon@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.