All of lore.kernel.org
 help / color / mirror / Atom feed
From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] x86/mm: add TLB purge to free pmd/pte page interfaces
Date: Tue, 29 May 2018 16:44:38 +0200	[thread overview]
Message-ID: <20180529144438.GM18595@8bytes.org> (raw)
In-Reply-To: <20180516233207.1580-4-toshi.kani@hpe.com>

On Wed, May 16, 2018 at 05:32:07PM -0600, Toshi Kani wrote:
>  	pmd = (pmd_t *)pud_page_vaddr(*pud);
> +	pmd_sv = (pmd_t *)__get_free_page(GFP_KERNEL);
> +	if (!pmd_sv)
> +		return 0;

So your code still needs to allocate a full page where a simple
list_head on the stack would do the same job.

Ingo, Thomas, can you please just revert the original broken patch for
now until there is proper fix?

Thanks,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: mingo@redhat.com, tglx@linutronix.de, Toshi Kani <toshi.kani@hpe.com>
Cc: mhocko@suse.com, akpm@linux-foundation.org, hpa@zytor.com,
	cpandya@codeaurora.org, linux-mm@kvack.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 3/3] x86/mm: add TLB purge to free pmd/pte page interfaces
Date: Tue, 29 May 2018 16:44:38 +0200	[thread overview]
Message-ID: <20180529144438.GM18595@8bytes.org> (raw)
In-Reply-To: <20180516233207.1580-4-toshi.kani@hpe.com>

On Wed, May 16, 2018 at 05:32:07PM -0600, Toshi Kani wrote:
>  	pmd = (pmd_t *)pud_page_vaddr(*pud);
> +	pmd_sv = (pmd_t *)__get_free_page(GFP_KERNEL);
> +	if (!pmd_sv)
> +		return 0;

So your code still needs to allocate a full page where a simple
list_head on the stack would do the same job.

Ingo, Thomas, can you please just revert the original broken patch for
now until there is proper fix?

Thanks,

	Joerg

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: mingo@redhat.com, tglx@linutronix.de, Toshi Kani <toshi.kani@hpe.com>
Cc: mhocko@suse.com, akpm@linux-foundation.org, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com, cpandya@codeaurora.org,
	linux-mm@kvack.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 3/3] x86/mm: add TLB purge to free pmd/pte page interfaces
Date: Tue, 29 May 2018 16:44:38 +0200	[thread overview]
Message-ID: <20180529144438.GM18595@8bytes.org> (raw)
In-Reply-To: <20180516233207.1580-4-toshi.kani@hpe.com>

On Wed, May 16, 2018 at 05:32:07PM -0600, Toshi Kani wrote:
>  	pmd = (pmd_t *)pud_page_vaddr(*pud);
> +	pmd_sv = (pmd_t *)__get_free_page(GFP_KERNEL);
> +	if (!pmd_sv)
> +		return 0;

So your code still needs to allocate a full page where a simple
list_head on the stack would do the same job.

Ingo, Thomas, can you please just revert the original broken patch for
now until there is proper fix?

Thanks,

	Joerg

  reply	other threads:[~2018-05-29 14:44 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 23:32 [PATCH v3 0/3] fix free pmd/pte page handlings on x86 Toshi Kani
2018-05-16 23:32 ` Toshi Kani
2018-05-16 23:32 ` [PATCH v3 1/3] x86/mm: disable ioremap free page handling on x86-PAE Toshi Kani
2018-05-16 23:32   ` Toshi Kani
2018-05-16 23:32 ` [PATCH v3 2/3] ioremap: Update pgtable free interfaces with addr Toshi Kani
2018-05-16 23:32   ` Toshi Kani
2018-05-17  6:47   ` Michal Hocko
2018-05-17  6:47     ` Michal Hocko
2018-05-17 14:32     ` Kani, Toshi
2018-05-17 14:32       ` Kani, Toshi
2018-05-16 23:32 ` [PATCH v3 3/3] x86/mm: add TLB purge to free pmd/pte page interfaces Toshi Kani
2018-05-16 23:32   ` Toshi Kani
2018-05-29 14:44   ` Joerg Roedel [this message]
2018-05-29 14:44     ` Joerg Roedel
2018-05-29 14:44     ` Joerg Roedel
2018-05-29 16:10     ` Kani, Toshi
2018-05-29 16:10       ` Kani, Toshi
2018-05-30  4:59       ` joro at 8bytes.org
2018-05-30  4:59         ` joro
2018-05-30 15:39         ` Kani, Toshi
2018-05-30 15:39           ` Kani, Toshi
2018-06-24 13:19 ` [PATCH v3 0/3] fix free pmd/pte page handlings on x86 Thomas Gleixner
2018-06-24 13:19   ` Thomas Gleixner
2018-06-25 14:56   ` Kani, Toshi
2018-06-25 14:56     ` Kani, Toshi
2018-06-25 17:53     ` Michal Hocko
2018-06-25 17:53       ` Michal Hocko
2018-06-25 21:15       ` Kani, Toshi
2018-06-25 21:15         ` Kani, Toshi
2018-06-26  6:35         ` Michal Hocko
2018-06-26  6:35           ` Michal Hocko
2018-06-26  8:45           ` Thomas Gleixner
2018-06-26  8:45             ` Thomas Gleixner
2018-06-26  8:54             ` Michal Hocko
2018-06-26  8:54               ` Michal Hocko
2018-06-26 15:25               ` Kani, Toshi
2018-06-26 15:25                 ` Kani, Toshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529144438.GM18595@8bytes.org \
    --to=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.