From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/amd - Optimize PPR log handling
Date: Tue, 29 May 2018 16:54:05 +0200 [thread overview]
Message-ID: <20180529145405.GN18595@8bytes.org> (raw)
In-Reply-To: <152668031618.108078.8188026193559324640.stgit-ztPFugr8rmfEhiLOc2DLklaTQe2KTcn/@public.gmane.org>
Hey Gary,
On Fri, May 18, 2018 at 04:51:56PM -0500, Gary R Hook wrote:
> Improve the performance of the PPR log polling function (i.e. the
> task of emptying the log) by minimizing MMIO operations and more
> efficiently processing groups of log entries. Cache the head
> pointer, as there's never a reason to read it. Ensure the head
> pointer register is updated every so often, to inform the IOMMU
> that space is available in the log.
>
> Finally, since a single pass may leave logged events unread, use
> an outer loop to repeat until head has caught up to tail.
>
> Signed-off-by: Gary R Hook <gary.hook-5C7GfCeVMHo@public.gmane.org>
Do you have numbers for the performance improvement? How did you test
this patch?
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Gary R Hook <gary.hook@amd.com>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd - Optimize PPR log handling
Date: Tue, 29 May 2018 16:54:05 +0200 [thread overview]
Message-ID: <20180529145405.GN18595@8bytes.org> (raw)
In-Reply-To: <152668031618.108078.8188026193559324640.stgit@wsp141332wss.amd.com>
Hey Gary,
On Fri, May 18, 2018 at 04:51:56PM -0500, Gary R Hook wrote:
> Improve the performance of the PPR log polling function (i.e. the
> task of emptying the log) by minimizing MMIO operations and more
> efficiently processing groups of log entries. Cache the head
> pointer, as there's never a reason to read it. Ensure the head
> pointer register is updated every so often, to inform the IOMMU
> that space is available in the log.
>
> Finally, since a single pass may leave logged events unread, use
> an outer loop to repeat until head has caught up to tail.
>
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
Do you have numbers for the performance improvement? How did you test
this patch?
Regards,
Joerg
next prev parent reply other threads:[~2018-05-29 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 21:51 [PATCH] iommu/amd - Optimize PPR log handling Gary R Hook
2018-05-18 21:51 ` Gary R Hook
[not found] ` <152668031618.108078.8188026193559324640.stgit-ztPFugr8rmfEhiLOc2DLklaTQe2KTcn/@public.gmane.org>
2018-05-29 14:54 ` Joerg Roedel [this message]
2018-05-29 14:54 ` Joerg Roedel
[not found] ` <20180529145405.GN18595-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2018-05-29 17:28 ` Gary R Hook
2018-05-29 17:28 ` Gary R Hook
[not found] ` <223930b9-3df9-813a-6676-68072e4e1bb6-5C7GfCeVMHo@public.gmane.org>
2018-05-30 4:52 ` Joerg Roedel
2018-05-30 4:52 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529145405.GN18595@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=gary.hook-5C7GfCeVMHo@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.