From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>,
laurent.pinchart@ideasonboard.com,
sebastian.reichel@collabora.co.uk
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Pali Rohár" <pali.rohar@gmail.com>,
sre@kernel.org, "kernel list" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, khilman@kernel.org,
ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com,
serge@hallyn.com, abcloriens@gmail.com, clayton@craftyguy.net,
martijn@brixit.nl, sakari.ailus@linux.intel.com,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"Thorsten Leemhuis" <regressions@leemhuis.info>
Subject: Re: v4.17-rc1: regressions on N900, N950
Date: Tue, 29 May 2018 22:45:17 +0200 [thread overview]
Message-ID: <20180529204517.GA6765@amd> (raw)
In-Reply-To: <20180524094705.GA16705@amd>
[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]
Hi!
> > > still results in working touchscreen, removing any of the three fields
> > > breaks it again.
> >
> > I bisected one regression down, see "omapdrm regression in v4.17-rc series"
> > not sure if it covers all the issues being discussed here though.
>
> Reverting 24aac6011f70 fixes screen on n900 in v4.17-rc for me. (But
> strange dependency on tsc2005@0 is still there).
Laurent, your patch looks pretty obvious, but unfortunately breaks
display on Nokia N900.
The patch is pretty big as is, perhaps you have version split to sdi
=> *sdi and then static => dynamic allocation?
Thanks,
Pavel
commit 24aac6011f704d69b5f34514923413f85669f282
Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Tue Feb 13 14:00:47 2018 +0200
drm: omapdrm: sdi: Allocate the sdi private data structure
dynamically
The sdi private data structure is currently stored as a global
variable. While no platform with multiple SDI encoders
currently exists
nor is planned, this doesn't comply with the kernel device
model and
should thus be fixed.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: v4.17-rc1: regressions on N900, N950
Date: Tue, 29 May 2018 22:45:17 +0200 [thread overview]
Message-ID: <20180529204517.GA6765@amd> (raw)
In-Reply-To: <20180524094705.GA16705@amd>
Hi!
> > > still results in working touchscreen, removing any of the three fields
> > > breaks it again.
> >
> > I bisected one regression down, see "omapdrm regression in v4.17-rc series"
> > not sure if it covers all the issues being discussed here though.
>
> Reverting 24aac6011f70 fixes screen on n900 in v4.17-rc for me. (But
> strange dependency on tsc2005 at 0 is still there).
Laurent, your patch looks pretty obvious, but unfortunately breaks
display on Nokia N900.
The patch is pretty big as is, perhaps you have version split to sdi
=> *sdi and then static => dynamic allocation?
Thanks,
Pavel
commit 24aac6011f704d69b5f34514923413f85669f282
Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Tue Feb 13 14:00:47 2018 +0200
drm: omapdrm: sdi: Allocate the sdi private data structure
dynamically
The sdi private data structure is currently stored as a global
variable. While no platform with multiple SDI encoders
currently exists
nor is planned, this doesn't comply with the kernel device
model and
should thus be fixed.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180529/4beb1f9c/attachment.sig>
next prev parent reply other threads:[~2018-05-29 20:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-22 7:42 v4.17-rc1: regressions on N900, N950 Pavel Machek
2018-04-22 7:42 ` Pavel Machek
2018-04-23 20:29 ` Aaro Koskinen
2018-04-23 20:29 ` Aaro Koskinen
2018-04-23 20:29 ` Aaro Koskinen
2018-05-21 21:39 ` Pavel Machek
2018-05-21 21:39 ` Pavel Machek
2018-05-21 21:39 ` Pavel Machek
2018-05-22 8:02 ` Pali Rohár
2018-05-22 8:02 ` Pali Rohár
2018-05-22 19:41 ` Aaro Koskinen
2018-05-22 19:41 ` Aaro Koskinen
2018-05-22 20:58 ` Pavel Machek
2018-05-22 20:58 ` Pavel Machek
2018-05-22 21:56 ` Aaro Koskinen
2018-05-22 21:56 ` Aaro Koskinen
2018-05-23 14:06 ` Pavel Machek
2018-05-23 14:06 ` Pavel Machek
2018-05-23 20:12 ` Pavel Machek
2018-05-23 20:12 ` Pavel Machek
2018-05-23 22:04 ` Tony Lindgren
2018-05-23 22:04 ` Tony Lindgren
2018-05-24 9:23 ` Pavel Machek
2018-05-24 9:23 ` Pavel Machek
2018-05-24 9:47 ` Pavel Machek
2018-05-24 9:47 ` Pavel Machek
2018-05-29 20:45 ` Pavel Machek [this message]
2018-05-29 20:45 ` Pavel Machek
2018-05-29 21:09 ` Sebastian Reichel
2018-05-29 21:09 ` Sebastian Reichel
2018-05-29 22:34 ` Pavel Machek
2018-05-29 22:34 ` Pavel Machek
2018-05-23 22:02 ` Aaro Koskinen
2018-05-23 22:02 ` Aaro Koskinen
2018-05-24 6:25 ` Tomi Valkeinen
2018-05-24 6:25 ` Tomi Valkeinen
2018-05-24 6:25 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180529204517.GA6765@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=clayton@craftyguy.net \
--cc=filip.matijevic.pz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=martijn@brixit.nl \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=regressions@leemhuis.info \
--cc=sakari.ailus@linux.intel.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.