All of lore.kernel.org
 help / color / mirror / Atom feed
From: jacopo mondi <jacopo@jmondi.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] media: arch: sh: migor: Fix TW9910 PDN gpio
Date: Wed, 30 May 2018 14:23:43 +0200	[thread overview]
Message-ID: <20180530122343.GA10472@w540> (raw)
In-Reply-To: <2981239.tGoCg7U0XF@avalon>

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

Hi Laurent, Geert,

On Wed, May 30, 2018 at 02:52:31PM +0300, Laurent Pinchart wrote:
> Hi Geert,
>
> On Wednesday, 30 May 2018 12:30:49 EEST Geert Uytterhoeven wrote:
> > Hi Jacopo,
> >
> > On Wed, May 30, 2018 at 11:13 AM, Jacopo Mondi wrote:
> > > The TW9910 PDN gpio (power down) is listed as active high in the chip
> > > manual. It turns out it is actually active low as when set to physical
> > > level 0 it actually turns the video decoder power off.
> >
> > So the picture "Typical TW9910 External Circuitry" in the datasheet, which
> > ties PDN to GND permanently, is wrong?

Also the definition of PDN pin in TW9910 manual, as reported by Laurent made me
think the pin had to stay in logical state 1 to have the chip powered
down. That's why my initial 'ACTIVE_HIGH' flag. The chip was not
recognized, but I thought it was a local problem of the Migo-R board I
was using.

Then one day I tried inverting the pin active state just to be sure,
and it started being fully operational :/

>
> The SH PTT2 line is connected directory to the TW9910 PDN signal, without any
> inverter on the board. The PDN signal is clearly documented as active-high in
> the TW9910 datasheet. Something is thus weird.

I suspect the 'active high' definition in datasheet is different from
our understanding. Their 'active' means the chip is operational, which
is not what one would expect from a powerdown pin.

>
> Jacopo, is it possible to measure the PDN signal on the board as close as
> possible to the TW9910 to see if it works as expected ?

Not for me. The board is in Japan and my multimeter doesn't have cables
that long, unfortunately.

Thanks
   j

>
> --
> Regards,
>
> Laurent Pinchart
>
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: jacopo mondi <jacopo@jmondi.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Linux-sh list <linux-sh@vger.kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] media: arch: sh: migor: Fix TW9910 PDN gpio
Date: Wed, 30 May 2018 12:23:43 +0000	[thread overview]
Message-ID: <20180530122343.GA10472@w540> (raw)
In-Reply-To: <2981239.tGoCg7U0XF@avalon>

[-- Attachment #1: Type: text/plain, Size: 1695 bytes --]

Hi Laurent, Geert,

On Wed, May 30, 2018 at 02:52:31PM +0300, Laurent Pinchart wrote:
> Hi Geert,
>
> On Wednesday, 30 May 2018 12:30:49 EEST Geert Uytterhoeven wrote:
> > Hi Jacopo,
> >
> > On Wed, May 30, 2018 at 11:13 AM, Jacopo Mondi wrote:
> > > The TW9910 PDN gpio (power down) is listed as active high in the chip
> > > manual. It turns out it is actually active low as when set to physical
> > > level 0 it actually turns the video decoder power off.
> >
> > So the picture "Typical TW9910 External Circuitry" in the datasheet, which
> > ties PDN to GND permanently, is wrong?

Also the definition of PDN pin in TW9910 manual, as reported by Laurent made me
think the pin had to stay in logical state 1 to have the chip powered
down. That's why my initial 'ACTIVE_HIGH' flag. The chip was not
recognized, but I thought it was a local problem of the Migo-R board I
was using.

Then one day I tried inverting the pin active state just to be sure,
and it started being fully operational :/

>
> The SH PTT2 line is connected directory to the TW9910 PDN signal, without any
> inverter on the board. The PDN signal is clearly documented as active-high in
> the TW9910 datasheet. Something is thus weird.

I suspect the 'active high' definition in datasheet is different from
our understanding. Their 'active' means the chip is operational, which
is not what one would expect from a powerdown pin.

>
> Jacopo, is it possible to measure the PDN signal on the board as close as
> possible to the TW9910 to see if it works as expected ?

Not for me. The board is in Japan and my multimeter doesn't have cables
that long, unfortunately.

Thanks
   j

>
> --
> Regards,
>
> Laurent Pinchart
>
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2018-05-30 12:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30  9:13 [PATCH] media: arch: sh: migor: Fix TW9910 PDN gpio Jacopo Mondi
2018-05-30  9:13 ` Jacopo Mondi
2018-05-30  9:30 ` Geert Uytterhoeven
2018-05-30  9:30   ` Geert Uytterhoeven
2018-05-30 11:52   ` Laurent Pinchart
2018-05-30 11:52     ` Laurent Pinchart
2018-05-30 12:23     ` jacopo mondi [this message]
2018-05-30 12:23       ` jacopo mondi
2018-05-30 12:38       ` Laurent Pinchart
2018-05-30 12:38         ` Laurent Pinchart
2018-05-30 12:51         ` jacopo mondi
2018-05-30 12:51           ` jacopo mondi
2018-05-30 11:08 ` Sergei Shtylyov
2018-05-30 11:08   ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530122343.GA10472@w540 \
    --to=jacopo@jmondi.org \
    --cc=dalias@libc.org \
    --cc=geert@linux-m68k.org \
    --cc=hans.verkuil@cisco.com \
    --cc=jacopo+renesas@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.