From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com,
loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com,
anjali.singhai@intel.com
Subject: [virtio-dev] Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework
Date: Thu, 31 May 2018 21:35:59 +0300 [thread overview]
Message-ID: <20180531212356-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180530220635.206ee6d7@shemminger-XPS-13-9360>
On Wed, May 30, 2018 at 10:06:35PM -0400, Stephen Hemminger wrote:
> On Thu, 24 May 2018 09:55:14 -0700
> Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
>
> > Use the registration/notification framework supported by the generic
> > failover infrastructure.
> >
> > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
>
> Why was this merged? It was never signed off by any of the netvsc maintainers,
> and there were still issues unresolved.
>
> There are also namespaces issues I am fixing and this breaks them.
> Will start my patch set with a revert for this. Sorry
As long as you finish the patch set with re-integrating with failover,
that's fine IMHO.
I suspect it's easier to add the code to failover though - namespace
things likely affect virtio as well. Lookup by ID would be an optional
feature for virtio, but probably a useful one - I won't ask you
to add it to virtio but it could be a mode in failover
that virtio will activate down the road. And reducing the number of
times we look cards up based on ID can only be a good thing.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>,
davem@davemloft.net, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
alexander.h.duyck@intel.com, kubakici@wp.pl, jasowang@redhat.com,
loseweigh@gmail.com, jiri@resnulli.us, aaron.f.brown@intel.com,
anjali.singhai@intel.com
Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework
Date: Thu, 31 May 2018 21:35:59 +0300 [thread overview]
Message-ID: <20180531212356-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180530220635.206ee6d7@shemminger-XPS-13-9360>
On Wed, May 30, 2018 at 10:06:35PM -0400, Stephen Hemminger wrote:
> On Thu, 24 May 2018 09:55:14 -0700
> Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
>
> > Use the registration/notification framework supported by the generic
> > failover infrastructure.
> >
> > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
>
> Why was this merged? It was never signed off by any of the netvsc maintainers,
> and there were still issues unresolved.
>
> There are also namespaces issues I am fixing and this breaks them.
> Will start my patch set with a revert for this. Sorry
As long as you finish the patch set with re-integrating with failover,
that's fine IMHO.
I suspect it's easier to add the code to failover though - namespace
things likely affect virtio as well. Lookup by ID would be an optional
feature for virtio, but probably a useful one - I won't ask you
to add it to virtio but it could be a mode in failover
that virtio will activate down the road. And reducing the number of
times we look cards up based on ID can only be a good thing.
--
MST
next prev parent reply other threads:[~2018-05-31 18:36 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 16:55 [virtio-dev] [PATCH net-next v12 0/5] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala
2018-05-24 16:55 ` Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 1/5] net: Introduce generic failover module Sridhar Samudrala
2018-05-24 16:55 ` [virtio-dev] " Sridhar Samudrala
2018-05-24 16:55 ` Sridhar Samudrala
2018-05-25 22:37 ` Stephen Hemminger
2018-05-25 22:37 ` Stephen Hemminger
2018-05-25 23:04 ` [virtio-dev] " Samudrala, Sridhar
2018-05-25 23:04 ` Samudrala, Sridhar
2018-05-26 7:43 ` Jiri Pirko
2018-05-26 7:43 ` Jiri Pirko
2018-05-25 22:38 ` Stephen Hemminger
2018-05-25 23:06 ` Samudrala, Sridhar
2018-05-25 23:06 ` [virtio-dev] " Samudrala, Sridhar
2018-05-25 23:06 ` Samudrala, Sridhar
2018-05-25 23:29 ` Stephen Hemminger
2018-05-25 23:29 ` Stephen Hemminger
2018-05-31 2:52 ` Stephen Hemminger
2018-05-31 2:52 ` Stephen Hemminger
2018-05-31 2:58 ` [virtio-dev] " Samudrala, Sridhar
2018-05-31 2:58 ` Samudrala, Sridhar
2018-05-31 2:58 ` Samudrala, Sridhar
2018-05-25 22:38 ` Stephen Hemminger
2018-05-24 16:55 ` [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala
2018-05-24 16:55 ` [virtio-dev] " Sridhar Samudrala
2018-05-24 16:55 ` Sridhar Samudrala
2018-05-25 22:34 ` Stephen Hemminger
2018-05-25 23:11 ` [virtio-dev] " Samudrala, Sridhar
2018-05-25 23:11 ` Samudrala, Sridhar
2018-05-25 23:28 ` Stephen Hemminger
2018-05-26 7:22 ` Samudrala, Sridhar
2018-05-26 7:22 ` [virtio-dev] " Samudrala, Sridhar
2018-05-26 7:22 ` Samudrala, Sridhar
2018-05-26 7:51 ` Jiri Pirko
2018-05-26 19:22 ` [virtio-dev] " Samudrala, Sridhar
2018-05-26 19:22 ` Samudrala, Sridhar
2018-05-25 23:28 ` Stephen Hemminger
2018-05-31 2:06 ` Stephen Hemminger
2018-05-31 2:06 ` Stephen Hemminger
2018-05-31 3:03 ` [virtio-dev] " Samudrala, Sridhar
2018-05-31 3:03 ` Samudrala, Sridhar
2018-05-31 12:58 ` Stephen Hemminger
2018-05-31 12:58 ` Stephen Hemminger
2018-05-31 17:34 ` Michael S. Tsirkin
2018-05-31 17:34 ` [virtio-dev] " Michael S. Tsirkin
2018-05-31 17:34 ` Michael S. Tsirkin
2018-05-31 18:35 ` Michael S. Tsirkin
2018-05-31 18:35 ` Michael S. Tsirkin [this message]
2018-05-31 18:35 ` Michael S. Tsirkin
2018-05-31 20:41 ` Siwei Liu
2018-05-31 20:41 ` [virtio-dev] " Siwei Liu
2018-05-31 20:41 ` Siwei Liu
2018-05-24 16:55 ` [virtio-dev] [PATCH net-next v12 3/5] net: Introduce net_failover driver Sridhar Samudrala
2018-05-24 16:55 ` Sridhar Samudrala
2018-05-24 16:55 ` Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 4/5] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala
2018-05-24 16:55 ` [virtio-dev] " Sridhar Samudrala
2018-05-24 16:55 ` Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 5/5] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-05-24 16:55 ` [virtio-dev] " Sridhar Samudrala
2018-05-24 16:55 ` Sridhar Samudrala
2018-05-25 17:19 ` [virtio-dev] Re: [PATCH net-next v12 0/5] Enable virtio_net to act as a standby for a passthru device Michael S. Tsirkin
2018-05-25 17:19 ` Michael S. Tsirkin
2018-05-25 17:19 ` Michael S. Tsirkin
2018-05-29 3:00 ` David Miller
2018-05-29 3:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531212356-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aaron.f.brown@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=anjali.singhai@intel.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=loseweigh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.