From: Tiwei Bie <tiwei.bie@intel.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org
Subject: [virtio-dev] Re: [PATCH v2] virtio: update the comments for transport features
Date: Fri, 1 Jun 2018 19:22:50 +0800 [thread overview]
Message-ID: <20180601112250.GA11839@debian> (raw)
In-Reply-To: <20180601131647.5d02da18.cohuck@redhat.com>
On Fri, Jun 01, 2018 at 01:16:47PM +0200, Cornelia Huck wrote:
> On Fri, 1 Jun 2018 18:59:50 +0800
> Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> > The existing comments for transport features are out dated.
>
> s/out dated/outdated/
Thanks for catching this typo!
>
[...]
> > +/*
> > + * Virtio feature bits VIRTIO_TRANSPORT_F_START through
> > + * VIRTIO_TRANSPORT_F_END are reserved for the transport
> > + * being used (e.g. virtio_ring, virtio_pci etc.), the
> > + * rest are per-device feature bits.
> > + */
> > #define VIRTIO_TRANSPORT_F_START 28
> > #define VIRTIO_TRANSPORT_F_END 38
> >
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Thanks for your review!
Best regards,
Tiwei Bie
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: Tiwei Bie <tiwei.bie@intel.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: mst@redhat.com, jasowang@redhat.com, stefanha@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org
Subject: Re: [PATCH v2] virtio: update the comments for transport features
Date: Fri, 1 Jun 2018 19:22:50 +0800 [thread overview]
Message-ID: <20180601112250.GA11839@debian> (raw)
In-Reply-To: <20180601131647.5d02da18.cohuck@redhat.com>
On Fri, Jun 01, 2018 at 01:16:47PM +0200, Cornelia Huck wrote:
> On Fri, 1 Jun 2018 18:59:50 +0800
> Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> > The existing comments for transport features are out dated.
>
> s/out dated/outdated/
Thanks for catching this typo!
>
[...]
> > +/*
> > + * Virtio feature bits VIRTIO_TRANSPORT_F_START through
> > + * VIRTIO_TRANSPORT_F_END are reserved for the transport
> > + * being used (e.g. virtio_ring, virtio_pci etc.), the
> > + * rest are per-device feature bits.
> > + */
> > #define VIRTIO_TRANSPORT_F_START 28
> > #define VIRTIO_TRANSPORT_F_END 38
> >
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Thanks for your review!
Best regards,
Tiwei Bie
next prev parent reply other threads:[~2018-06-01 11:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 10:59 [virtio-dev] [PATCH v2] virtio: update the comments for transport features Tiwei Bie
2018-06-01 10:59 ` Tiwei Bie
2018-06-01 11:16 ` [virtio-dev] " Cornelia Huck
2018-06-01 11:16 ` Cornelia Huck
2018-06-01 11:22 ` Tiwei Bie
2018-06-01 11:22 ` Tiwei Bie [this message]
2018-06-01 11:22 ` Tiwei Bie
2018-06-01 11:16 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601112250.GA11839@debian \
--to=tiwei.bie@intel.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.