* [PATCH] watchdog: orion_wdt: add wdt status init for handle_boot_enabled
@ 2018-05-30 4:59 Maxim Kochetkov
2018-06-01 16:24 ` Guenter Roeck
2018-06-04 1:38 ` Guenter Roeck
0 siblings, 2 replies; 6+ messages in thread
From: Maxim Kochetkov @ 2018-05-30 4:59 UTC (permalink / raw)
To: linux-watchdog
This patch add init of wdt.status for CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
---
--- a/drivers/watchdog/orion_wdt.c.orig 2018-04-19 09:54:12.000000000 +0300
+++ b/drivers/watchdog/orion_wdt.c 2018-05-29 15:00:29.560000000 +0300
@@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
*/
if (!orion_wdt_enabled(&dev->wdt))
orion_wdt_stop(&dev->wdt);
+ else
+ set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
/* Request the IRQ only after the watchdog is disabled */
irq = platform_get_irq(pdev, 0);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] watchdog: orion_wdt: add wdt status init for handle_boot_enabled
2018-05-30 4:59 [PATCH] watchdog: orion_wdt: add wdt status init for handle_boot_enabled Maxim Kochetkov
@ 2018-06-01 16:24 ` Guenter Roeck
2018-06-04 1:38 ` Guenter Roeck
1 sibling, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2018-06-01 16:24 UTC (permalink / raw)
To: Maxim Kochetkov; +Cc: linux-watchdog
On Wed, May 30, 2018 at 07:59:12AM +0300, Maxim Kochetkov wrote:
> This patch add init of wdt.status for CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED
>
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> --- a/drivers/watchdog/orion_wdt.c.orig 2018-04-19 09:54:12.000000000 +0300
> +++ b/drivers/watchdog/orion_wdt.c 2018-05-29 15:00:29.560000000 +0300
> @@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
> */
> if (!orion_wdt_enabled(&dev->wdt))
> orion_wdt_stop(&dev->wdt);
> + else
> + set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
>
> /* Request the IRQ only after the watchdog is disabled */
> irq = platform_get_irq(pdev, 0);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: watchdog: orion_wdt: add wdt status init for handle_boot_enabled
2018-05-30 4:59 [PATCH] watchdog: orion_wdt: add wdt status init for handle_boot_enabled Maxim Kochetkov
2018-06-01 16:24 ` Guenter Roeck
@ 2018-06-04 1:38 ` Guenter Roeck
2018-06-05 4:29 ` Maxim Kochetkov
1 sibling, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2018-06-04 1:38 UTC (permalink / raw)
To: Maxim Kochetkov; +Cc: linux-watchdog
On Wed, May 30, 2018 at 07:59:12AM +0300, Maxim Kochetkov wrote:
> This patch add init of wdt.status for CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED
>
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
I can not get this patch to apply. Can you rebase to mainline and resend,
or at least let us know what you used as base version ?
Thanks,
Guenter
> ---
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --- a/drivers/watchdog/orion_wdt.c.orig 2018-04-19 09:54:12.000000000 +0300
> +++ b/drivers/watchdog/orion_wdt.c 2018-05-29 15:00:29.560000000 +0300
> @@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
> */
> if (!orion_wdt_enabled(&dev->wdt))
> orion_wdt_stop(&dev->wdt);
> + else
> + set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
>
> /* Request the IRQ only after the watchdog is disabled */
> irq = platform_get_irq(pdev, 0);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: watchdog: orion_wdt: add wdt status init for handle_boot_enabled
2018-06-04 1:38 ` Guenter Roeck
@ 2018-06-05 4:29 ` Maxim Kochetkov
2018-06-05 10:58 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Maxim Kochetkov @ 2018-06-05 4:29 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-watchdog
--- linux-4.17/drivers/watchdog/orion_wdt.c.orig 2018-06-04
07:54:05.176000000 +0300
+++ linux-4.17/drivers/watchdog/orion_wdt.c 2018-06-04
08:00:13.156000000 +0300
@@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
*/
if (!orion_wdt_enabled(&dev->wdt))
orion_wdt_stop(&dev->wdt);
+ else
+ set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
/* Request the IRQ only after the watchdog is disabled */
irq = platform_get_irq(pdev, 0);
04.06.2018 04:38, Guenter Roeck wrote:
> On Wed, May 30, 2018 at 07:59:12AM +0300, Maxim Kochetkov wrote:
>> This patch add init of wdt.status for CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED
>>
>> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> I can not get this patch to apply. Can you rebase to mainline and resend,
> or at least let us know what you used as base version ?
>
> Thanks,
> Guenter
>
>> ---
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> --- a/drivers/watchdog/orion_wdt.c.orig 2018-04-19 09:54:12.000000000 +0300
>> +++ b/drivers/watchdog/orion_wdt.c 2018-05-29 15:00:29.560000000 +0300
>> @@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
>> */
>> if (!orion_wdt_enabled(&dev->wdt))
>> orion_wdt_stop(&dev->wdt);
>> + else
>> + set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
>>
>> /* Request the IRQ only after the watchdog is disabled */
>> irq = platform_get_irq(pdev, 0);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: watchdog: orion_wdt: add wdt status init for handle_boot_enabled
2018-06-05 4:29 ` Maxim Kochetkov
@ 2018-06-05 10:58 ` Guenter Roeck
2018-06-05 13:21 ` Maxim Kochetkov
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2018-06-05 10:58 UTC (permalink / raw)
To: Maxim Kochetkov; +Cc: linux-watchdog
On 06/04/2018 09:29 PM, Maxim Kochetkov wrote:
> --- linux-4.17/drivers/watchdog/orion_wdt.c.orig 2018-06-04 07:54:05.176000000 +0300
> +++ linux-4.17/drivers/watchdog/orion_wdt.c 2018-06-04 08:00:13.156000000 +0300
> @@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
> */
> if (!orion_wdt_enabled(&dev->wdt))
> orion_wdt_stop(&dev->wdt);
> + else
> + set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
>
> /* Request the IRQ only after the watchdog is disabled */
> irq = platform_get_irq(pdev, 0);
>
We would need a complete patch to be able to apply it.
Guenter
> 04.06.2018 04:38, Guenter Roeck wrote:
>> On Wed, May 30, 2018 at 07:59:12AM +0300, Maxim Kochetkov wrote:
>>> This patch add init of wdt.status for CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED
>>>
>>> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>> I can not get this patch to apply. Can you rebase to mainline and resend,
>> or at least let us know what you used as base version ?
>>
>> Thanks,
>> Guenter
>>
>>> ---
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>>> --- a/drivers/watchdog/orion_wdt.c.orig 2018-04-19 09:54:12.000000000 +0300
>>> +++ b/drivers/watchdog/orion_wdt.c 2018-05-29 15:00:29.560000000 +0300
>>> @@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
>>> */
>>> if (!orion_wdt_enabled(&dev->wdt))
>>> orion_wdt_stop(&dev->wdt);
>>> + else
>>> + set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
>>>
>>> /* Request the IRQ only after the watchdog is disabled */
>>> irq = platform_get_irq(pdev, 0);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: watchdog: orion_wdt: add wdt status init for handle_boot_enabled
2018-06-05 10:58 ` Guenter Roeck
@ 2018-06-05 13:21 ` Maxim Kochetkov
0 siblings, 0 replies; 6+ messages in thread
From: Maxim Kochetkov @ 2018-06-05 13:21 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-watchdog
This patch add init of wdt.status for CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED
Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
---
--- linux-4.17/drivers/watchdog/orion_wdt.c.orig 2018-06-04
07:54:05.176000000 +0300
+++ linux-4.17/drivers/watchdog/orion_wdt.c 2018-06-04
08:00:13.156000000 +0300
@@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
*/
if (!orion_wdt_enabled(&dev->wdt))
orion_wdt_stop(&dev->wdt);
+ else
+ set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
/* Request the IRQ only after the watchdog is disabled */
irq = platform_get_irq(pdev, 0);
05.06.2018 13:58, Guenter Roeck wrote:
> On 06/04/2018 09:29 PM, Maxim Kochetkov wrote:
>> --- linux-4.17/drivers/watchdog/orion_wdt.c.orig 2018-06-04
>> 07:54:05.176000000 +0300
>> +++ linux-4.17/drivers/watchdog/orion_wdt.c 2018-06-04
>> 08:00:13.156000000 +0300
>> @@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
>> */
>> if (!orion_wdt_enabled(&dev->wdt))
>> orion_wdt_stop(&dev->wdt);
>> + else
>> + set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
>>
>> /* Request the IRQ only after the watchdog is disabled */
>> irq = platform_get_irq(pdev, 0);
>>
>
>
> We would need a complete patch to be able to apply it.
>
> Guenter
>
>> 04.06.2018 04:38, Guenter Roeck wrote:
>>> On Wed, May 30, 2018 at 07:59:12AM +0300, Maxim Kochetkov wrote:
>>>> This patch add init of wdt.status for
>>>> CONFIG_WATCHDOG_HANDLE_BOOT_ENABLED
>>>>
>>>> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
>>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> I can not get this patch to apply. Can you rebase to mainline and
>>> resend,
>>> or at least let us know what you used as base version ?
>>>
>>> Thanks,
>>> Guenter
>>>
>>>> ---
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe
>>>> linux-watchdog" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>
>>>> --- a/drivers/watchdog/orion_wdt.c.orig 2018-04-19
>>>> 09:54:12.000000000 +0300
>>>> +++ b/drivers/watchdog/orion_wdt.c 2018-05-29 15:00:29.560000000
>>>> +0300
>>>> @@ -581,6 +581,8 @@ static int orion_wdt_probe(struct platfo
>>>> */
>>>> if (!orion_wdt_enabled(&dev->wdt))
>>>> orion_wdt_stop(&dev->wdt);
>>>> + else
>>>> + set_bit(WDOG_HW_RUNNING, &dev->wdt.status);
>>>>
>>>> /* Request the IRQ only after the watchdog is disabled */
>>>> irq = platform_get_irq(pdev, 0);
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-05 13:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-30 4:59 [PATCH] watchdog: orion_wdt: add wdt status init for handle_boot_enabled Maxim Kochetkov
2018-06-01 16:24 ` Guenter Roeck
2018-06-04 1:38 ` Guenter Roeck
2018-06-05 4:29 ` Maxim Kochetkov
2018-06-05 10:58 ` Guenter Roeck
2018-06-05 13:21 ` Maxim Kochetkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.