All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
	ARM <linux-arm-kernel@lists.infradead.org>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Tony Lindgren <tony@atomide.com>
Subject: Re: linux-next: manual merge of the regulator tree with the arm-soc tree
Date: Mon, 4 Jun 2018 11:46:42 +0100	[thread overview]
Message-ID: <20180604104642.GC7536@sirena.org.uk> (raw)
In-Reply-To: <2564792.sYBGPVz9u3@z50>

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

On Fri, Jun 01, 2018 at 12:49:53AM +0200, Janusz Krzysztofik wrote:

> I confirm the fix by Stephen works for me, however, the conflicting patch by 
> Linus breaks things a bit.

> Lookup tables added to board files use function name "enable" while the 
> regulator uses NULL. As a result, GPIO descriptor is not matched and not 
> assigned to the regulator which ends up running with no control over GPIO pin.

> Either the regulator driver should use the function name "enable" or that name 
> should be removed from lookup tables.

I'll revert this one as well :(

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next: manual merge of the regulator tree with the arm-soc tree
Date: Mon, 4 Jun 2018 11:46:42 +0100	[thread overview]
Message-ID: <20180604104642.GC7536@sirena.org.uk> (raw)
In-Reply-To: <2564792.sYBGPVz9u3@z50>

On Fri, Jun 01, 2018 at 12:49:53AM +0200, Janusz Krzysztofik wrote:

> I confirm the fix by Stephen works for me, however, the conflicting patch by 
> Linus breaks things a bit.

> Lookup tables added to board files use function name "enable" while the 
> regulator uses NULL. As a result, GPIO descriptor is not matched and not 
> assigned to the regulator which ends up running with no control over GPIO pin.

> Either the regulator driver should use the function name "enable" or that name 
> should be removed from lookup tables.

I'll revert this one as well :(
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180604/ab8c1fa9/attachment.sig>

  reply	other threads:[~2018-06-04 10:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30  5:07 linux-next: manual merge of the regulator tree with the arm-soc tree Stephen Rothwell
2018-05-30  5:07 ` Stephen Rothwell
2018-05-30  7:29 ` Linus Walleij
2018-05-30  7:29   ` Linus Walleij
2018-05-31 22:49   ` Janusz Krzysztofik
2018-05-31 22:49     ` Janusz Krzysztofik
2018-06-04 10:46     ` Mark Brown [this message]
2018-06-04 10:46       ` Mark Brown
2018-06-11 11:49       ` Linus Walleij
2018-06-11 11:49         ` Linus Walleij
2018-05-30 20:52 ` Janusz Krzysztofik
2018-05-30 20:52   ` Janusz Krzysztofik
  -- strict thread matches above, loose matches on Subject: below --
2019-02-18  1:56 Stephen Rothwell
2019-02-18  1:56 ` Stephen Rothwell
2019-03-05 22:27 ` Stephen Rothwell
2019-03-05 22:27   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180604104642.GC7536@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=arnd@arndb.de \
    --cc=jmkrzyszt@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=sfr@canb.auug.org.au \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.