[LTP] LTP CVE "cve-2011-2183" failed on x86_64, arm32 beaglebone x15

[LTP] LTP CVE "cve-2011-2183" failed on x86_64, arm32 beaglebone x15

[Naresh Kamboju]

LTP CVE "cve-2011-2183" failed on x86_64, (arm32) beaglebone x15.

Please check the history here,
https://qa-reports.linaro.org/lkft/linux-mainline-oe/tests/ltp-cve-tests/cve-2011-2183

Test log:
----------
tst_test.c:980: INFO: Timeout per run is 0h 15m 00s
ksm05.c:98: CONF: KSM configuration is not enabled
safe_file_ops.c:238: WARN: Failed to open FILE
'/sys/kernel/mm/ksm/run' at ksm05.c:110
Summary:
passed   0
failed   0
skipped  0
warnings 1

Analysis:
The required config is not set on x86_64 and arm32 x15 device.
# CONFIG_KSM is not set
This config should be enabled.

Bug report:
LKFT: LTP: CVE cve-2011-2183 test failed on x86_64 and arm32 x15 devices
https://bugs.linaro.org/show_bug.cgi?id=3857

Best regards
Naresh Kamboju

[LTP] LTP CVE "cve-2011-2183" failed on x86_64, arm32 beaglebone x15

[Cyril Hrubis]

Hi!
> LTP CVE "cve-2011-2183" failed on x86_64, (arm32) beaglebone x15.
> 
> Please check the history here,
> https://qa-reports.linaro.org/lkft/linux-mainline-oe/tests/ltp-cve-tests/cve-2011-2183
> 
> Test log:
> ----------
> tst_test.c:980: INFO: Timeout per run is 0h 15m 00s
> ksm05.c:98: CONF: KSM configuration is not enabled
> safe_file_ops.c:238: WARN: Failed to open FILE
> '/sys/kernel/mm/ksm/run' at ksm05.c:110

That is an obvious bug in the test, the value of run should be restored
only if we managed to change it.


We should do at least:

diff --git a/testcases/kernel/mem/ksm/ksm05.c b/testcases/kernel/mem/ksm/ksm05.c
index f3bfbf4fa..6deaa8440 100644
--- a/testcases/kernel/mem/ksm/ksm05.c
+++ b/testcases/kernel/mem/ksm/ksm05.c
@@ -107,7 +107,8 @@ static void setup(void)
 static void cleanup(void)
 {
        /* restore /sys/kernel/mm/ksm/run value */
-       FILE_PRINTF(PATH_KSM "run", "%d", ksm_run_orig);
+       if (!access(PATH_KSM, F_OK))
+               FILE_PRINTF(PATH_KSM "run", "%d", ksm_run_orig);
 }
 
 static struct tst_test test = {

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] LTP CVE "cve-2011-2183" failed on x86_64, arm32 beaglebone x15

[Cyril Hrubis]

Hi!
> That is an obvious bug in the test, the value of run should be restored
> only if we managed to change it.

I've pushed a slightly different patch that fixes the issue:

https://github.com/linux-test-project/ltp/commit/ffc8005a002ecc6f0d70675f7dee79cd481acffc

Thanks for the report.

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] LTP CVE "cve-2011-2183" failed on x86_64, arm32 beaglebone x15

[Naresh Kamboju]

On 4 June 2018 at 18:02, Cyril Hrubis <chrubis@suse.cz> wrote:
> Hi!
>> That is an obvious bug in the test, the value of run should be restored
>> only if we managed to change it.
>
> I've pushed a slightly different patch that fixes the issue:
>
> https://github.com/linux-test-project/ltp/commit/ffc8005a002ecc6f0d70675f7dee79cd481acffc
>
> Thanks for the report.

Thanks for the quick patch.
Happy testing :)

- Naresh

>
> --
> Cyril Hrubis
> chrubis@suse.cz