From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, armbru@redhat.com, imammedo@redhat.com
Subject: [Qemu-devel] [PATCH 3/6] hmp: Restrict auto-complete in preconfig
Date: Tue, 5 Jun 2018 13:26:33 +0100 [thread overview]
Message-ID: <20180605122636.33654-4-dgilbert@redhat.com> (raw)
In-Reply-To: <20180605122636.33654-1-dgilbert@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Don't show the commands that aren't available.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
monitor.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 7d1709c225..9b29787a52 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3950,12 +3950,17 @@ static void monitor_find_completion_by_table(Monitor *mon,
cmdname = args[0];
readline_set_completion_index(mon->rs, strlen(cmdname));
for (cmd = cmd_table; cmd->name != NULL; cmd++) {
- cmd_completion(mon, cmdname, cmd->name);
+ if (!runstate_check(RUN_STATE_PRECONFIG) ||
+ cmd_can_preconfig(cmd)) {
+ cmd_completion(mon, cmdname, cmd->name);
+ }
}
} else {
/* find the command */
for (cmd = cmd_table; cmd->name != NULL; cmd++) {
- if (compare_cmd(args[0], cmd->name)) {
+ if (compare_cmd(args[0], cmd->name) &&
+ (!runstate_check(RUN_STATE_PRECONFIG) ||
+ cmd_can_preconfig(cmd))) {
break;
}
}
--
2.17.0
next prev parent reply other threads:[~2018-06-05 12:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 12:26 [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode Dr. David Alan Gilbert (git)
2018-06-05 12:26 ` [Qemu-devel] [PATCH 1/6] hmp: Add flag for preconfig commands Dr. David Alan Gilbert (git)
2018-06-07 8:50 ` Peter Xu
2018-06-07 12:14 ` Markus Armbruster
2018-06-07 12:18 ` Dr. David Alan Gilbert
2018-06-05 12:26 ` [Qemu-devel] [PATCH 2/6] hmp: Allow help on " Dr. David Alan Gilbert (git)
2018-06-07 8:51 ` Peter Xu
2018-06-05 12:26 ` Dr. David Alan Gilbert (git) [this message]
2018-06-07 8:52 ` [Qemu-devel] [PATCH 3/6] hmp: Restrict auto-complete in preconfig Peter Xu
2018-06-05 12:26 ` [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig Dr. David Alan Gilbert (git)
2018-06-07 8:49 ` Peter Xu
2018-06-07 12:22 ` Markus Armbruster
2018-06-07 13:45 ` Dr. David Alan Gilbert
2018-06-07 15:12 ` Markus Armbruster
2018-06-07 15:28 ` Dr. David Alan Gilbert
2018-06-08 5:56 ` Markus Armbruster
2018-06-08 8:18 ` Dr. David Alan Gilbert
2018-06-08 9:30 ` Igor Mammedov
2018-06-08 16:51 ` Markus Armbruster
2018-06-08 17:18 ` Dr. David Alan Gilbert
2018-06-07 15:08 ` Igor Mammedov
2018-06-08 5:41 ` Markus Armbruster
2018-06-07 9:39 ` Igor Mammedov
2018-06-05 12:26 ` [Qemu-devel] [PATCH 5/6] hmp: add exit_preconfig Dr. David Alan Gilbert (git)
2018-06-07 8:53 ` Peter Xu
2018-06-05 12:26 ` [Qemu-devel] [PATCH 6/6] hmp: Allow HMP in preconfig state again Dr. David Alan Gilbert (git)
2018-06-07 8:56 ` Peter Xu
2018-06-07 8:54 ` [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode Peter Xu
2018-06-07 9:00 ` Dr. David Alan Gilbert
2018-06-07 9:05 ` Peter Xu
2018-06-07 9:45 ` Igor Mammedov
2018-06-07 10:02 ` Peter Xu
2018-06-07 9:48 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605122636.33654-4-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.