Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Markus Armbruster (armbru@redhat.com) wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
> > On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git) wrote:
> >> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >> 
> >> Allow a bunch of the info commands to be used in preconfig.
> >> Could probably add most of them.
> >
> > I guess some of them may not work yet during preconfig.  E.g.:
> >
> > $ ./x86_64-softmmu/qemu-system-x86_64 -preconfig -monitor stdio
> > QEMU 2.12.50 monitor - type 'help' for more information
> > (qemu) info mtree
> > address-space: memory
> >   0000000000000000-ffffffffffffffff (prio 0, i/o): system
> >
> > address-space: I/O
> >   0000000000000000-000000000000ffff (prio 0, i/o): io
> >
> > But it's fine to enable that I guess.
> >
> > (Which "info" command would you want to use during preconfig?)
> >
> >> 
> >> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> > Reviewed-by: Peter Xu <peterx@redhat.com>
> 
> The reason for having -preconfig is us despairing of making -S do the
> right thing.  We'd have to *understand* the tangled mess that is our
> startup, and rearrange it so QMP becomes available early enough for
> configuring NUMA (and other things), yet late enough for everything to
> work.
> 
> -preconfig is a cheap hack to avoid this headache, by bypassing almost
> all of "everything".
> 
> Now you bring back some of "everything".  Dangerous.  You better show it
> actually works.  Until you do:
> 
> NAK

Well I did test each command in here to make sure it didn't
crash/produce complete junk; but here's the output with the v2 of this
patch that Igor R-b:

[dgilbert@dgilbert-t530 try]$ ./x86_64-softmmu/qemu-system-x86_64 -nographic -preconfig

(qemu) 
(qemu) 
(qemu) help info
info chardev  -- show the character devices
info history  -- show the command line history
info hotpluggable-cpus  -- Show information about hotpluggable CPUs
info iothreads  -- show iothreads
info memdev  -- show memory backends
info name  -- show the current VM name
info numa  -- show NUMA information
info qom-tree [path] -- show QOM composition tree
info status  -- show the current VM status (running|paused)
info usbhost  -- show host USB devices
info uuid  -- show the current VM UUID
info version  -- show the version of QEMU
(qemu) info chardev
serial0: filename=mux
serial0-base: filename=stdio
parallel0: filename=null
(qemu) info history
0: 'help info'
1: 'info chardev'
2: 'info history'
(qemu) info hotpluggable-cpus 
Hotpluggable CPUs:
  type: "qemu64-x86_64-cpu"
  vcpus_count: "1"
  CPUInstance Properties:
    socket-id: "0"
    core-id: "0"
    thread-id: "0"
(qemu) info iothreads
(qemu) info memdev

(qemu) info name
(qemu) info numa
0 nodes
(qemu) info qom-tree 
/machine (pc-i440fx-3.0-machine)
  /peripheral (container)
  /peripheral-anon (container)
  /unattached (container)
    /system[0] (qemu:memory-region)
    /io[0] (qemu:memory-region)
(qemu) info status
VM status: paused (preconfig)
(qemu) info usbhost 
  Bus 2, Addr 3, Port 1.5, Speed 1.5 Mb/s
    Class 00: USB device 093a:2510
  Bus 1, Addr 3, Port 1.6, Speed 480 Mb/s
    Class ef: USB device 5986:02d2
  Bus 3, Addr 2, Port 1, Speed 1.5 Mb/s
    Class 00: USB device 0d3d:0001
(qemu) info uuid
00000000-0000-0000-0000-000000000000
(qemu) info version
2.12.50v2.12.0-1074-gfbb4dcae3a
(qemu) 

Dave

--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK