All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: Re: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities
Date: Tue, 5 Jun 2018 10:42:05 -0600	[thread overview]
Message-ID: <20180605164205.GA21034@linux.intel.com> (raw)
In-Reply-To: <20180605182243-mutt-send-email-mst@kernel.org>

On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote:
> On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote:
> > Add a machine command line option to allow the user to control the Platform
> > Capabilities Structure in the virtualized NFIT.  This Platform Capabilities
> > Structure was added in ACPI 6.2 Errata A.
> > 
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> 
> I tried playing with it and encoding the capabilities is
> quite awkward.
> 
> Can we add bits for specific capabilities instead of nvdimm-cap?
> 
> How about:
> 
> "cpu-flush-on-power-loss-cap"
> "memory-flush-on-power-loss-cap"
> "byte-addressable-mirroring-cap"

Hmmm...I don't like that as much because:

a) It's very verbose.  Looking at my current qemu command line few other
   options require that many characters, and you'd commonly be defining more
   than one of these for a given VM.

b) It means that the QEMU will need to be updated if/when new flags are added,
   because we'll have to have new options for each flag.  The current
   implementation is more future-proof because you can specify any flags
   value you want.

However, if you feel strongly about this, I'll make the change.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, Haozhong Zhang <haozhong.zhang@intel.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	"Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Subject: Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities
Date: Tue, 5 Jun 2018 10:42:05 -0600	[thread overview]
Message-ID: <20180605164205.GA21034@linux.intel.com> (raw)
In-Reply-To: <20180605182243-mutt-send-email-mst@kernel.org>

On Tue, Jun 05, 2018 at 06:25:27PM +0300, Michael S. Tsirkin wrote:
> On Mon, May 21, 2018 at 10:32:02AM -0600, Ross Zwisler wrote:
> > Add a machine command line option to allow the user to control the Platform
> > Capabilities Structure in the virtualized NFIT.  This Platform Capabilities
> > Structure was added in ACPI 6.2 Errata A.
> > 
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> 
> I tried playing with it and encoding the capabilities is
> quite awkward.
> 
> Can we add bits for specific capabilities instead of nvdimm-cap?
> 
> How about:
> 
> "cpu-flush-on-power-loss-cap"
> "memory-flush-on-power-loss-cap"
> "byte-addressable-mirroring-cap"

Hmmm...I don't like that as much because:

a) It's very verbose.  Looking at my current qemu command line few other
   options require that many characters, and you'd commonly be defining more
   than one of these for a given VM.

b) It means that the QEMU will need to be updated if/when new flags are added,
   because we'll have to have new options for each flag.  The current
   implementation is more future-proof because you can specify any flags
   value you want.

However, if you feel strongly about this, I'll make the change.

  reply	other threads:[~2018-06-05 16:42 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 16:31 [qemu PATCH v4 0/4] support NFIT platform capabilities Ross Zwisler
2018-05-21 16:31 ` [Qemu-devel] " Ross Zwisler
2018-05-21 16:32 ` [qemu PATCH v4 1/4] nvdimm: fix typo in label-size definition Ross Zwisler
2018-05-21 16:32   ` [Qemu-devel] " Ross Zwisler
2018-05-21 16:32 ` [qemu PATCH v4 2/4] tests/.gitignore: add entry for generated file Ross Zwisler
2018-05-21 16:32   ` [Qemu-devel] " Ross Zwisler
2018-05-21 16:41   ` Eric Blake
2018-05-21 16:41     ` Eric Blake
2018-05-21 17:32     ` Philippe Mathieu-Daudé
2018-05-21 17:32       ` Philippe Mathieu-Daudé
2018-05-21 18:29       ` Eric Blake
2018-05-21 18:29         ` Eric Blake
2018-05-21 16:32 ` [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities Ross Zwisler
2018-05-21 16:32   ` [Qemu-devel] " Ross Zwisler
2018-06-05 15:25   ` Michael S. Tsirkin
2018-06-05 15:25     ` [Qemu-devel] " Michael S. Tsirkin
2018-06-05 16:42     ` Ross Zwisler [this message]
2018-06-05 16:42       ` Ross Zwisler
2018-06-05 18:15       ` Dan Williams
2018-06-05 18:15         ` [Qemu-devel] " Dan Williams
2018-06-05 18:37         ` Michael S. Tsirkin
2018-06-05 18:37           ` [Qemu-devel] " Michael S. Tsirkin
2018-06-05 22:07           ` Ross Zwisler
2018-06-05 22:07             ` [Qemu-devel] " Ross Zwisler
2018-06-05 22:21             ` Dan Williams
2018-06-05 22:21               ` [Qemu-devel] " Dan Williams
2018-06-06 16:50               ` Ross Zwisler
2018-06-06 16:50                 ` [Qemu-devel] " Ross Zwisler
2018-06-06 17:00                 ` Ross Zwisler
2018-06-06 17:00                   ` [Qemu-devel] " Ross Zwisler
2018-06-06 17:08                   ` Ross Zwisler
2018-06-06 17:08                     ` [Qemu-devel] " Ross Zwisler
2018-06-06 19:06                     ` Michael S. Tsirkin
2018-06-06 19:06                       ` [Qemu-devel] " Michael S. Tsirkin
2018-06-12 11:55                       ` Igor Mammedov
2018-06-12 11:55                         ` Igor Mammedov
2018-06-06 19:04                   ` Michael S. Tsirkin
2018-06-06 19:04                     ` [Qemu-devel] " Michael S. Tsirkin
2018-06-06 19:07                 ` Michael S. Tsirkin
2018-06-06 19:07                   ` [Qemu-devel] " Michael S. Tsirkin
2018-06-06 23:20               ` Elliott, Robert (Persistent Memory)
2018-06-06 23:20                 ` [Qemu-devel] " Elliott, Robert (Persistent Memory)
2018-06-06 23:40                 ` Dan Williams
2018-06-06 23:40                   ` [Qemu-devel] " Dan Williams
2018-06-07 15:29                   ` Michael S. Tsirkin
2018-06-07 15:29                     ` [Qemu-devel] " Michael S. Tsirkin
2018-06-07 15:30                 ` Michael S. Tsirkin
2018-06-07 15:30                   ` [Qemu-devel] " Michael S. Tsirkin
2018-05-21 16:32 ` [qemu PATCH v4 4/4] ACPI testing: test " Ross Zwisler
2018-05-21 16:32   ` [Qemu-devel] " Ross Zwisler
2018-05-25 17:51 ` [qemu PATCH v4 0/4] support " Michael S. Tsirkin
2018-05-25 17:51   ` [Qemu-devel] " Michael S. Tsirkin
2018-05-31 22:03   ` Ross Zwisler
2018-05-31 22:03     ` [Qemu-devel] " Ross Zwisler
2018-05-29 19:54 ` Ross Zwisler
2018-05-29 19:54   ` [Qemu-devel] " Ross Zwisler
2018-06-01  5:11   ` Elliott, Robert (Persistent Memory)
2018-06-01  5:11     ` [Qemu-devel] " Elliott, Robert (Persistent Memory)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180605164205.GA21034@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.