From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@intel.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()
Date: Thu, 7 Jun 2018 13:24:40 +0200 [thread overview]
Message-ID: <20180607112440.GA10915@lst.de> (raw)
In-Reply-To: <20180607082944.41676-1-hare@suse.de>
On Thu, Jun 07, 2018 at 10:29:44AM +0200, Hannes Reinecke wrote:
> blk_partition_remap() will only clear bi_partno if an actual remapping
> has happened. But flush request et al don't have an actual size, so
> the remapping doesn't happen and bi_partno is never cleared.
> So for stacked devices blk_partition_remap() will be called on each level.
> If (as is the case for native nvme multipathing) one of the lower-level
> devices do _not_support partitioning a spurious I/O error is generated.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCHv2] block: always set partition number to '0' in blk_partition_remap()
Date: Thu, 7 Jun 2018 13:24:40 +0200 [thread overview]
Message-ID: <20180607112440.GA10915@lst.de> (raw)
In-Reply-To: <20180607082944.41676-1-hare@suse.de>
On Thu, Jun 07, 2018@10:29:44AM +0200, Hannes Reinecke wrote:
> blk_partition_remap() will only clear bi_partno if an actual remapping
> has happened. But flush request et al don't have an actual size, so
> the remapping doesn't happen and bi_partno is never cleared.
> So for stacked devices blk_partition_remap() will be called on each level.
> If (as is the case for native nvme multipathing) one of the lower-level
> devices do _not_support partitioning a spurious I/O error is generated.
>
> Signed-off-by: Hannes Reinecke <hare at suse.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
next prev parent reply other threads:[~2018-06-07 11:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 8:29 [PATCHv2] block: always set partition number to '0' in blk_partition_remap() Hannes Reinecke
2018-06-07 8:29 ` Hannes Reinecke
2018-06-07 8:31 ` Johannes Thumshirn
2018-06-07 8:31 ` Johannes Thumshirn
2018-06-07 8:42 ` Sagi Grimberg
2018-06-07 8:42 ` Sagi Grimberg
2018-06-07 11:24 ` Christoph Hellwig [this message]
2018-06-07 11:24 ` Christoph Hellwig
2018-06-07 12:56 ` Jens Axboe
2018-06-07 12:56 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607112440.GA10915@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.