Re: [PATCH] multiboot2: clarify usage of the address tag

["Roger Pau Monné" <roger.pau@citrix.com>]

On Wed, Jun 06, 2018 at 07:28:20PM +0200, Daniel Kiper wrote:
> On Tue, Jun 05, 2018 at 11:55:36AM +0200, Roger Pau Monne wrote:
> > Add a note to spell out that if the address tag is not present the
> > file should be loaded using the elf header.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > ---
> > Cc: Daniel Kiper <daniel.kiper@oracle.com>
> > Cc: xen-devel@lists.xenproject.org
> > ---
> >  doc/multiboot.texi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/doc/multiboot.texi b/doc/multiboot.texi
> > index 2e2d7e74a..196f9c17a 100644
> > --- a/doc/multiboot.texi
> > +++ b/doc/multiboot.texi
> > @@ -509,6 +509,12 @@ assumes that no bss segment is present.
> >
> >  @end table
> >
> > +Note: This information does not need to be provided if the kernel
> > +image is in elf format, but it must be provided if the image is in
> 
> s/elf/@sc{elf}/
> 
> > +a.out format or in some other format. Compliant boot loaders must be
> > +able to load images that are either in elf format or contain the
> 
> Ditto.
> 
> > +address tag embedded in the Multiboot header.
> 
> s/Multiboot/Multiboot2/
> 
> I think that it is also worth mentioning that the address tag has
> preference over relevant data provided in ELF header.
> 
> Additionally, may I ask you to provide similar patch for Multiboot spec?
> You can find it in multiboot branch. Please look for "The address fields
> of Multiboot header" paragraph.

Multiboot1 already has such paragraph in the "3.1.2 The magic fields
of Multiboot header" section.

Thanks, Roger.