From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh@kernel.org>,
linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtc: pxa: fix probe function
Date: Thu, 07 Jun 2018 18:11:24 +0000 [thread overview]
Message-ID: <20180607181124.GC10521@piout.net> (raw)
In-Reply-To: <20180607082909.iyukeclgrb3dtjsy@kili.mountain>
On 07/06/2018 11:29:09+0300, Dan Carpenter wrote:
> This patch is from static analysis and I don't have the hardware to
> to test it. I think the test is reversed so now the probe function
> will return success early and the last part of the function is dead
> code.
>
> Fixes: 3cdf4ad9633e ("rtc: pxa: convert to use shared sa1100 functions")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied, thanks.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh@kernel.org>,
linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rtc: pxa: fix probe function
Date: Thu, 7 Jun 2018 20:11:24 +0200 [thread overview]
Message-ID: <20180607181124.GC10521@piout.net> (raw)
In-Reply-To: <20180607082909.iyukeclgrb3dtjsy@kili.mountain>
On 07/06/2018 11:29:09+0300, Dan Carpenter wrote:
> This patch is from static analysis and I don't have the hardware to
> to test it. I think the test is reversed so now the probe function
> will return success early and the last part of the function is dead
> code.
>
> Fixes: 3cdf4ad9633e ("rtc: pxa: convert to use shared sa1100 functions")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Applied, thanks.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-06-07 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 8:29 [PATCH] rtc: pxa: fix probe function Dan Carpenter
2018-06-07 8:29 ` Dan Carpenter
2018-06-07 18:11 ` Alexandre Belloni [this message]
2018-06-07 18:11 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607181124.GC10521@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.