All of lore.kernel.org
 help / color / mirror / Atom feed
From: mathieu.poirier@linaro.org (Mathieu Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/20] coresight: dts: Document usage of graph bindings
Date: Fri, 8 Jun 2018 14:30:09 -0600	[thread overview]
Message-ID: <20180608203009.GF30587@xps15> (raw)
In-Reply-To: <1528235011-30691-8-git-send-email-suzuki.poulose@arm.com>

On Tue, Jun 05, 2018 at 10:43:18PM +0100, Suzuki K Poulose wrote:
> Before we update the bindings, document the current graph bindings
> and usage of additional properties.
> 
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> ---
>  .../devicetree/bindings/arm/coresight.txt          | 31 +++++++++++++++++++---
>  1 file changed, 27 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index 9aa30a1..ed6b555 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -52,9 +52,7 @@ its hardware characteristcs.
>  	  clocks the core of that coresight component. The latter clock
>  	  is optional.
>  
> -	* port or ports: The representation of the component's port
> -	  layout using the generic DT graph presentation found in
> -	  "bindings/graph.txt".
> +	* port or ports: see "Graph bindings for Coresight" below.
>  
>  * Additional required properties for System Trace Macrocells (STM):
>  	* reg: along with the physical base address and length of the register
> @@ -71,7 +69,7 @@ its hardware characteristcs.
>  	  AMBA markee):
>  		- "arm,coresight-replicator"
>  
> -	* port or ports: same as above.
> +	* port or ports: see "Graph bindings for Coresight" below.
>  
>  * Optional properties for ETM/PTMs:
>  
> @@ -90,6 +88,31 @@ its hardware characteristcs.
>  	* arm,scatter-gather: boolean. Indicates that the TMC-ETR can safely
>  	  use the SG mode on this system.
>  
> +Graph bindings for Coresight
> +-------------------------------
> +
> +Coresight components are interconnected to create a data path for the flow of
> +trace data generated from the "sources" to their collection points "sink".
> +Each coresight component must describe the "input" and "output" connections.
> +The connections must be described via generic DT graph bindings as described
> +by the "bindings/graph.txt", where each "port" along with an "endpoint"
> +component represents a hardware port and the connection.
> +
> +Since it is possible to have multiple connections for any coresight component
> +with a specific direction of data flow, each connection must define the
> +following properties to uniquely identify the connection details.
> +
> + * Direction of the data flow w.r.t the component :
> +   Each input port must have the following property defined at the "endpoint"
> +   for the port.
> +	"slave-mode"
> +
> + * Hardware Port number at the component:
> +     -  The hardware port number is assumed to be the address of the "port"
> +         component.
> +
> +
> +
>  Example:
>  
>  1. Sinks
> -- 
> 2.7.4
> 

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org,
	frowand.list@gmail.com, mark.rutland@arm.com,
	sudeep.holla@arm.com, arm@kernel.org,
	linux-kernel@vger.kernel.org, matt.sealey@arm.com,
	john.horley@arm.com, charles.garcia-tobin@arm.com,
	coresight@lists.linaro.org, devicetree@vger.kernel.org,
	mike.leach@linaro.org
Subject: Re: [PATCH 07/20] coresight: dts: Document usage of graph bindings
Date: Fri, 8 Jun 2018 14:30:09 -0600	[thread overview]
Message-ID: <20180608203009.GF30587@xps15> (raw)
In-Reply-To: <1528235011-30691-8-git-send-email-suzuki.poulose@arm.com>

On Tue, Jun 05, 2018 at 10:43:18PM +0100, Suzuki K Poulose wrote:
> Before we update the bindings, document the current graph bindings
> and usage of additional properties.
> 
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> ---
>  .../devicetree/bindings/arm/coresight.txt          | 31 +++++++++++++++++++---
>  1 file changed, 27 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index 9aa30a1..ed6b555 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -52,9 +52,7 @@ its hardware characteristcs.
>  	  clocks the core of that coresight component. The latter clock
>  	  is optional.
>  
> -	* port or ports: The representation of the component's port
> -	  layout using the generic DT graph presentation found in
> -	  "bindings/graph.txt".
> +	* port or ports: see "Graph bindings for Coresight" below.
>  
>  * Additional required properties for System Trace Macrocells (STM):
>  	* reg: along with the physical base address and length of the register
> @@ -71,7 +69,7 @@ its hardware characteristcs.
>  	  AMBA markee):
>  		- "arm,coresight-replicator"
>  
> -	* port or ports: same as above.
> +	* port or ports: see "Graph bindings for Coresight" below.
>  
>  * Optional properties for ETM/PTMs:
>  
> @@ -90,6 +88,31 @@ its hardware characteristcs.
>  	* arm,scatter-gather: boolean. Indicates that the TMC-ETR can safely
>  	  use the SG mode on this system.
>  
> +Graph bindings for Coresight
> +-------------------------------
> +
> +Coresight components are interconnected to create a data path for the flow of
> +trace data generated from the "sources" to their collection points "sink".
> +Each coresight component must describe the "input" and "output" connections.
> +The connections must be described via generic DT graph bindings as described
> +by the "bindings/graph.txt", where each "port" along with an "endpoint"
> +component represents a hardware port and the connection.
> +
> +Since it is possible to have multiple connections for any coresight component
> +with a specific direction of data flow, each connection must define the
> +following properties to uniquely identify the connection details.
> +
> + * Direction of the data flow w.r.t the component :
> +   Each input port must have the following property defined at the "endpoint"
> +   for the port.
> +	"slave-mode"
> +
> + * Hardware Port number at the component:
> +     -  The hardware port number is assumed to be the address of the "port"
> +         component.
> +
> +
> +
>  Example:
>  
>  1. Sinks
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-06-08 20:30 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 21:43 [PATCH 00/20] coresight: Update device tree bindings Suzuki K Poulose
2018-06-05 21:43 ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 01/20] coresight: Fix memory leak in coresight_register Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-06  6:44   ` Arvind Yadav
2018-06-06  6:44     ` Arvind Yadav
2018-06-06 10:16     ` Suzuki K Poulose
2018-06-06 10:16       ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 02/20] coresight: of: Fix refcounting for graph nodes Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 19:55   ` Mathieu Poirier
2018-06-08 19:55     ` Mathieu Poirier
2018-06-11  9:18     ` Suzuki K Poulose
2018-06-11  9:18       ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 03/20] coresight: Fix remote endpoint parsing Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 20:05   ` Mathieu Poirier
2018-06-08 20:05     ` Mathieu Poirier
2018-06-08 20:05     ` Mathieu Poirier
2018-06-05 21:43 ` [PATCH 04/20] coresight: Cleanup platform description data Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 19:41   ` Mathieu Poirier
2018-06-08 19:41     ` Mathieu Poirier
2018-06-05 21:43 ` [PATCH 05/20] coresight: platform: Cleanup coresight connection handling Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 20:18   ` Mathieu Poirier
2018-06-08 20:18     ` Mathieu Poirier
2018-06-05 21:43 ` [PATCH 06/20] coresight: Handle errors in finding input/output ports Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 20:24   ` Mathieu Poirier
2018-06-08 20:24     ` Mathieu Poirier
2018-06-05 21:43 ` [PATCH 07/20] coresight: dts: Document usage of graph bindings Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 20:30   ` Mathieu Poirier [this message]
2018-06-08 20:30     ` Mathieu Poirier
2018-06-05 21:43 ` [PATCH 08/20] coresight: dts: Cleanup device tree " Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 21:22   ` Mathieu Poirier
2018-06-08 21:22     ` Mathieu Poirier
2018-06-11  9:22     ` Suzuki K Poulose
2018-06-11  9:22       ` Suzuki K Poulose
2018-06-11 16:52       ` Mathieu Poirier
2018-06-11 16:52         ` Mathieu Poirier
2018-06-11 16:55         ` Suzuki K Poulose
2018-06-11 16:55           ` Suzuki K Poulose
2018-06-11 21:51           ` Mathieu Poirier
2018-06-11 21:51             ` Mathieu Poirier
2018-06-05 21:43 ` [PATCH 09/20] coresight: dts: Define new bindings for direction of data flow Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 21:39   ` Mathieu Poirier
2018-06-08 21:39     ` Mathieu Poirier
2018-06-05 21:43 ` [PATCH 10/20] dts: juno: Update coresight bindings for hw port Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-08 21:49   ` Mathieu Poirier
2018-06-08 21:49     ` Mathieu Poirier
2018-06-08 21:52     ` Mathieu Poirier
2018-06-08 21:52       ` Mathieu Poirier
2018-06-12  9:50       ` Suzuki K Poulose
2018-06-12  9:50         ` Suzuki K Poulose
2018-06-12 10:42       ` Sudeep Holla
2018-06-12 10:42         ` Sudeep Holla
2018-06-05 21:43 ` [PATCH 11/20] dts: hisilicon: Update coresight bindings for hw ports Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 12/20] dts: spreadtrum: " Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 13/20] dts: qcom: " Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 14/20] dts: arm: hisilicon: Update coresight bindings for hardware port Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 15/20] dts: arm: imx7{d, s}: Update coresight binding for hardware ports Suzuki K Poulose
2018-06-05 21:43   ` [PATCH 15/20] dts: arm: imx7{d,s}: " Suzuki K Poulose
2018-06-19  2:12   ` Shawn Guo
2018-06-19  2:12     ` Shawn Guo
2018-06-19 10:35     ` Stefan Agner
2018-06-19 10:35       ` Stefan Agner
2018-06-19 14:57     ` Mathieu Poirier
2018-06-19 14:57       ` Mathieu Poirier
2018-06-05 21:43 ` [PATCH 16/20] dts: arm: omap: Update coresight bindings " Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-07-03  7:09   ` Tony Lindgren
2018-07-03  7:09     ` Tony Lindgren
2018-07-03  7:59     ` Suzuki K Poulose
2018-07-03  7:59       ` Suzuki K Poulose
2018-07-03  8:12       ` Tony Lindgren
2018-07-03  8:12         ` Tony Lindgren
2018-06-05 21:43 ` [PATCH 17/20] dts: arm: qcom: " Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 18/20] dts: sama5d2: " Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-19 21:24   ` Alexandre Belloni
2018-06-19 21:24     ` Alexandre Belloni
2018-06-20  9:44     ` Suzuki K Poulose
2018-06-20  9:44       ` Suzuki K Poulose
2018-06-20 10:53       ` Alexandre Belloni
2018-06-20 10:53         ` Alexandre Belloni
2018-06-05 21:43 ` [PATCH 19/20] dts: ste-dbx5x0: Update coresight bindings for hardware port Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-26  9:30   ` Linus Walleij
2018-06-26  9:30     ` Linus Walleij
2018-06-26  9:31     ` Suzuki K Poulose
2018-06-26  9:31       ` Suzuki K Poulose
2018-06-05 21:43 ` [PATCH 20/20] dts: tc2: Update coresight bindings for hardware ports Suzuki K Poulose
2018-06-05 21:43   ` Suzuki K Poulose
2018-06-20  9:53 ` [PATCH 00/20] coresight: Update device tree bindings Suzuki K Poulose
2018-06-20  9:53   ` Suzuki K Poulose
2018-06-20  9:53   ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180608203009.GF30587@xps15 \
    --to=mathieu.poirier@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.