From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] net: emaclite: Fix MDIO bus unregister bug
Date: Wed, 13 Jun 2018 09:23:01 +0200 [thread overview]
Message-ID: <20180613072301.GC24314@lunn.ch> (raw)
In-Reply-To: <1528871719-1681-3-git-send-email-radhey.shyam.pandey@xilinx.com>
On Wed, Jun 13, 2018 at 12:05:17PM +0530, Radhey Shyam Pandey wrote:
> Since 'has_mdio' flag is not used,sequence insmod->rmmod-> insmod
> leads to failure as MDIO unregister doesn't happen in .remove().
> Fix it by checking MII bus pointer instead.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Cc: davem@davemloft.net, michal.simek@xilinx.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] net: emaclite: Fix MDIO bus unregister bug
Date: Wed, 13 Jun 2018 09:23:01 +0200 [thread overview]
Message-ID: <20180613072301.GC24314@lunn.ch> (raw)
In-Reply-To: <1528871719-1681-3-git-send-email-radhey.shyam.pandey@xilinx.com>
On Wed, Jun 13, 2018 at 12:05:17PM +0530, Radhey Shyam Pandey wrote:
> Since 'has_mdio' flag is not used,sequence insmod->rmmod-> insmod
> leads to failure as MDIO unregister doesn't happen in .remove().
> Fix it by checking MII bus pointer instead.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2018-06-13 7:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 6:35 [PATCH 0/4] emaclite bug fixes and code cleanup Radhey Shyam Pandey
2018-06-13 6:35 ` Radhey Shyam Pandey
2018-06-13 6:35 ` [PATCH 1/4] net: emaclite: Fix position of lp->mii_bus assignment Radhey Shyam Pandey
2018-06-13 6:35 ` Radhey Shyam Pandey
2018-06-13 7:21 ` Andrew Lunn
2018-06-13 7:21 ` Andrew Lunn
2018-06-13 6:35 ` [PATCH 2/4] net: emaclite: Fix MDIO bus unregister bug Radhey Shyam Pandey
2018-06-13 6:35 ` Radhey Shyam Pandey
2018-06-13 7:23 ` Andrew Lunn [this message]
2018-06-13 7:23 ` Andrew Lunn
2018-06-13 6:35 ` [PATCH 3/4] net: emaclite: Remove unused 'has_mdio' flag Radhey Shyam Pandey
2018-06-13 6:35 ` Radhey Shyam Pandey
2018-06-13 7:23 ` Andrew Lunn
2018-06-13 7:23 ` Andrew Lunn
2018-06-13 6:35 ` [PATCH 4/4] net: emaclite: Remove xemaclite_mdio_setup return check Radhey Shyam Pandey
2018-06-13 6:35 ` Radhey Shyam Pandey
2018-06-13 7:29 ` Andrew Lunn
2018-06-13 7:29 ` Andrew Lunn
2018-06-13 16:02 ` Radhey Shyam Pandey
2018-06-13 16:02 ` Radhey Shyam Pandey
2018-06-15 0:08 ` [PATCH 0/4] emaclite bug fixes and code cleanup David Miller
2018-06-15 0:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613072301.GC24314@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.