From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Parth Y Shah <sparth1292@gmail.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Fixed an indentation error
Date: Wed, 13 Jun 2018 14:36:15 +0200 [thread overview]
Message-ID: <20180613123615.GA29104@kroah.com> (raw)
On Wed, Jun 13, 2018 at 05:55:10PM +0530, Parth Y Shah wrote:
> Signed-off-by: Parth Y Shah <sparth1292@gmail.com>
> ---
> drivers/usb/gadget/configfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index efba66c..0675b4a 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
> list_move_tail(&f->list, &cfg->func_list);
> if (f->unbind) {
> dev_dbg(&gi->cdev.gadget->dev,
> - "unbind function '%s'/%p\n",
> - f->name, f);
> + "unbind function '%s'/%p\n",
> + f->name, f);
I see no "error" with the original code here, please explain why this
needs to be changed.
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Parth Y Shah <sparth1292@gmail.com>
Cc: balbi@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed an indentation error
Date: Wed, 13 Jun 2018 14:36:15 +0200 [thread overview]
Message-ID: <20180613123615.GA29104@kroah.com> (raw)
In-Reply-To: <1528892710-14928-1-git-send-email-sparth1292@gmail.com>
On Wed, Jun 13, 2018 at 05:55:10PM +0530, Parth Y Shah wrote:
> Signed-off-by: Parth Y Shah <sparth1292@gmail.com>
> ---
> drivers/usb/gadget/configfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index efba66c..0675b4a 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
> list_move_tail(&f->list, &cfg->func_list);
> if (f->unbind) {
> dev_dbg(&gi->cdev.gadget->dev,
> - "unbind function '%s'/%p\n",
> - f->name, f);
> + "unbind function '%s'/%p\n",
> + f->name, f);
I see no "error" with the original code here, please explain why this
needs to be changed.
thanks,
greg k-h
next reply other threads:[~2018-06-13 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 12:36 Greg Kroah-Hartman [this message]
2018-06-13 12:36 ` [PATCH] Fixed an indentation error Greg KH
-- strict thread matches above, loose matches on Subject: below --
2018-06-14 6:42 [v2] Fixed a checkpatch error Greg Kroah-Hartman
2018-06-14 6:42 ` [PATCH v2] " Greg KH
2018-06-14 6:32 [v2] " Parth Y Shah
2018-06-14 6:32 ` [PATCH v2] " Parth Y Shah
2018-06-13 12:32 Fixed an indentation error Joe Perches
2018-06-13 12:32 ` [PATCH] " Joe Perches
2018-06-13 12:25 Parth Y Shah
2018-06-13 12:25 ` [PATCH] " Parth Y Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613123615.GA29104@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sparth1292@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.