From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Vignesh R <vigneshr@ti.com>, Tero Kristo <t-kristo@ti.com>,
Russell King <linux@armlinux.org.uk>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [RFC PATCH 5/6] arm64: dts: ti: Add Support for AM654 SoC
Date: Thu, 14 Jun 2018 05:38:05 -0700 [thread overview]
Message-ID: <20180614123805.GF112168@atomide.com> (raw)
In-Reply-To: <20180607233853.p7iw7nlxxuyi66og@kahuna>
Hi,
Some comments on the ranges below.
* Nishanth Menon <nm@ti.com> [180607 16:41]:
> + soc0: soc0 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
I suggest you leave out the soc0, that's not real. Just make
the cbass@0 the top level interconnect. It can then provide
ranges to mcu interconnect which can provide ranges to the wkup
interconnect. So just model it after what's in the hardware :)
I found the following ranges based on a quick look at the TRM,
they could be split further if needed for power domains for
genpd for example.
main covers
0x0000000000 - 0x5402000000
main provides at least the following ranges for mcu
0x0028380000 - 0x002bc00000
0x0040080000 - 0x0041c80000
0x0045100000 - 0x0045180000
0x0045600000 - 0x0045640000
0x0045810000 - 0x0045860000
0x0045950000 - 0x0045950400
0x0045a50000 - 0x0045a50400
0x0045b04000 - 0x0045b06400
0x0045d10000 - 0x0045d24000
0x0046000000 - 0x0060000000
0x0400000000 - 0x0800000000
0x4c3c020000 - 0x4c3c030000
0x4c3e000000 - 0x4c3e040000
0x5400000000 - 0x5402000000
then mcu provides the following ranges for wkup
0x0042000000 - 0x0044410020
0x0045000000 - 0x0045030000
0x0045080000 - 0x00450a0000
0x0045808000 - 0x0045808800
0x0045b00000 - 0x0045b02400
This based on looking at "figure 1-1. device top-level
block diagram" and the memory map in TRM.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 5/6] arm64: dts: ti: Add Support for AM654 SoC
Date: Thu, 14 Jun 2018 05:38:05 -0700 [thread overview]
Message-ID: <20180614123805.GF112168@atomide.com> (raw)
In-Reply-To: <20180607233853.p7iw7nlxxuyi66og@kahuna>
Hi,
Some comments on the ranges below.
* Nishanth Menon <nm@ti.com> [180607 16:41]:
> + soc0: soc0 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
I suggest you leave out the soc0, that's not real. Just make
the cbass at 0 the top level interconnect. It can then provide
ranges to mcu interconnect which can provide ranges to the wkup
interconnect. So just model it after what's in the hardware :)
I found the following ranges based on a quick look at the TRM,
they could be split further if needed for power domains for
genpd for example.
main covers
0x0000000000 - 0x5402000000
main provides at least the following ranges for mcu
0x0028380000 - 0x002bc00000
0x0040080000 - 0x0041c80000
0x0045100000 - 0x0045180000
0x0045600000 - 0x0045640000
0x0045810000 - 0x0045860000
0x0045950000 - 0x0045950400
0x0045a50000 - 0x0045a50400
0x0045b04000 - 0x0045b06400
0x0045d10000 - 0x0045d24000
0x0046000000 - 0x0060000000
0x0400000000 - 0x0800000000
0x4c3c020000 - 0x4c3c030000
0x4c3e000000 - 0x4c3e040000
0x5400000000 - 0x5402000000
then mcu provides the following ranges for wkup
0x0042000000 - 0x0044410020
0x0045000000 - 0x0045030000
0x0045080000 - 0x00450a0000
0x0045808000 - 0x0045808800
0x0045b00000 - 0x0045b02400
This based on looking at "figure 1-1. device top-level
block diagram" and the memory map in TRM.
Regards,
Tony
next prev parent reply other threads:[~2018-06-14 12:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <=<20180605060125.9518-1-nm@ti.com>
2018-06-05 6:05 ` [RFC PATCH 5/6] arm64: dts: ti: Add Support for AM654 SoC Nishanth Menon
2018-06-05 6:05 ` Nishanth Menon
2018-06-05 6:05 ` Nishanth Menon
2018-06-05 6:05 ` [RFC PATCH 6/6] arm64: dts: ti: Add support for AM654 EVM base board Nishanth Menon
2018-06-05 6:05 ` Nishanth Menon
2018-06-05 6:05 ` Nishanth Menon
2018-06-05 14:05 ` [RFC PATCH 5/6] arm64: dts: ti: Add Support for AM654 SoC Rob Herring
2018-06-05 14:05 ` Rob Herring
2018-06-05 14:14 ` Tony Lindgren
2018-06-05 14:14 ` Tony Lindgren
2018-06-07 23:38 ` Nishanth Menon
2018-06-07 23:38 ` Nishanth Menon
2018-06-07 23:38 ` Nishanth Menon
2018-06-14 12:38 ` Tony Lindgren [this message]
2018-06-14 12:38 ` Tony Lindgren
2018-06-14 13:04 ` Nishanth Menon
2018-06-14 13:04 ` Nishanth Menon
2018-06-14 13:04 ` Nishanth Menon
2018-06-15 5:01 ` Tony Lindgren
2018-06-15 5:01 ` Tony Lindgren
2018-06-15 5:01 ` Tony Lindgren
2018-06-15 13:38 ` Sekhar Nori
2018-06-15 13:38 ` Sekhar Nori
2018-06-15 13:38 ` Sekhar Nori
2018-08-20 14:21 ` Tony Lindgren
2018-08-20 14:21 ` Tony Lindgren
2018-08-08 6:31 ` Kishon Vijay Abraham I
2018-08-08 6:31 ` Kishon Vijay Abraham I
2018-08-08 6:31 ` Kishon Vijay Abraham I
2018-08-20 14:31 ` Tony Lindgren
2018-08-20 14:31 ` Tony Lindgren
2018-08-27 3:02 ` Kishon Vijay Abraham I
2018-08-27 3:02 ` Kishon Vijay Abraham I
2018-08-27 3:02 ` Kishon Vijay Abraham I
2018-08-27 15:55 ` Tony Lindgren
2018-08-27 15:55 ` Tony Lindgren
2018-08-28 1:22 ` Nishanth Menon
2018-08-28 1:22 ` Nishanth Menon
2018-08-28 1:22 ` Nishanth Menon
2018-08-28 3:39 ` Kishon Vijay Abraham I
2018-08-28 3:39 ` Kishon Vijay Abraham I
2018-08-28 3:39 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614123805.GF112168@atomide.com \
--to=tony@atomide.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=t-kristo@ti.com \
--cc=vigneshr@ti.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.