* [PATCH] drm/i915/selftests: Initialise request to silence a compiler
@ 2018-06-14 12:49 Chris Wilson
2018-06-14 13:10 ` Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2018-06-14 12:49 UTC (permalink / raw)
To: intel-gfx
With an old (4.7.3 on 32bit) gcc, it emits a warning for
In file included from drivers/gpu/drm/i915/i915_request.c:1425:0:
drivers/gpu/drm/i915/selftests/i915_request.c: In function ‘live_nop_request’:
drivers/gpu/drm/i915/selftests/i915_request.c:380:21: error: ‘request’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
Silence it by just setting it to NULL on initialisation.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
index f5d00332bb31..63cd9486cc13 100644
--- a/drivers/gpu/drm/i915/selftests/i915_request.c
+++ b/drivers/gpu/drm/i915/selftests/i915_request.c
@@ -342,9 +342,9 @@ static int live_nop_request(void *arg)
mutex_lock(&i915->drm.struct_mutex);
for_each_engine(engine, i915, id) {
- IGT_TIMEOUT(end_time);
- struct i915_request *request;
+ struct i915_request *request = NULL;
unsigned long n, prime;
+ IGT_TIMEOUT(end_time);
ktime_t times[2] = {};
err = begin_live_test(&t, i915, __func__, engine->name);
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/selftests: Initialise request to silence a compiler
2018-06-14 12:49 [PATCH] drm/i915/selftests: Initialise request to silence a compiler Chris Wilson
@ 2018-06-14 13:10 ` Ville Syrjälä
2018-06-14 13:55 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-14 16:58 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2018-06-14 13:10 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Thu, Jun 14, 2018 at 01:49:23PM +0100, Chris Wilson wrote:
> With an old (4.7.3 on 32bit) gcc, it emits a warning for
>
> In file included from drivers/gpu/drm/i915/i915_request.c:1425:0:
> drivers/gpu/drm/i915/selftests/i915_request.c: In function ‘live_nop_request’:
> drivers/gpu/drm/i915/selftests/i915_request.c:380:21: error: ‘request’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> Silence it by just setting it to NULL on initialisation.
Looks harmeless
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index f5d00332bb31..63cd9486cc13 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -342,9 +342,9 @@ static int live_nop_request(void *arg)
> mutex_lock(&i915->drm.struct_mutex);
>
> for_each_engine(engine, i915, id) {
> - IGT_TIMEOUT(end_time);
> - struct i915_request *request;
> + struct i915_request *request = NULL;
> unsigned long n, prime;
> + IGT_TIMEOUT(end_time);
> ktime_t times[2] = {};
>
> err = begin_live_test(&t, i915, __func__, engine->name);
> --
> 2.17.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/selftests: Initialise request to silence a compiler
2018-06-14 12:49 [PATCH] drm/i915/selftests: Initialise request to silence a compiler Chris Wilson
2018-06-14 13:10 ` Ville Syrjälä
@ 2018-06-14 13:55 ` Patchwork
2018-06-14 16:58 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-06-14 13:55 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Initialise request to silence a compiler
URL : https://patchwork.freedesktop.org/series/44752/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4314 -> Patchwork_9301 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44752/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9301 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_chamelium@dp-edid-read:
fi-kbl-7500u: PASS -> FAIL (fdo#103841)
==== Possible fixes ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#105128) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-cnl-psr: FAIL (fdo#100368) -> PASS
fi-cnl-y3: DMESG-WARN (fdo#104951) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
== Participating hosts (44 -> 39) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4314 -> Patchwork_9301
CI_DRM_4314: 2f4a101babe898ba750fa274dc90db1ede57d59c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4518: e4908004547b63131352fbc0ddcdb1d3d55480e0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9301: 9a78f2b75b0e09b3ccb954e1ef72820a01bd3932 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9a78f2b75b0e drm/i915/selftests: Initialise request to silence a compiler
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9301/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/selftests: Initialise request to silence a compiler
2018-06-14 12:49 [PATCH] drm/i915/selftests: Initialise request to silence a compiler Chris Wilson
2018-06-14 13:10 ` Ville Syrjälä
2018-06-14 13:55 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-06-14 16:58 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-06-14 16:58 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Initialise request to silence a compiler
URL : https://patchwork.freedesktop.org/series/44752/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4314_full -> Patchwork_9301_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9301_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9301_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9301_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mocs_settings@mocs-rc6-bsd2:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9301_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-glk: NOTRUN -> FAIL (fdo#105347)
igt@drv_selftest@live_hangcheck:
shard-apl: PASS -> DMESG-FAIL (fdo#106560)
igt@drv_selftest@mock_scatterlist:
shard-glk: NOTRUN -> DMESG-WARN (fdo#103667)
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-glk: NOTRUN -> FAIL (fdo#103158) +2
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
shard-glk: PASS -> FAIL (fdo#105703)
igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
shard-glk: PASS -> FAIL (fdo#106509, fdo#105454)
igt@kms_fbcon_fbt@fbc-suspend:
shard-snb: PASS -> DMESG-WARN (fdo#102365)
igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
shard-hsw: PASS -> FAIL (fdo#103060)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: NOTRUN -> FAIL (fdo#105363)
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: PASS -> FAIL (fdo#104724) +1
igt@prime_vgem@coherency-gtt:
shard-glk: NOTRUN -> FAIL (fdo#100587)
==== Warnings ====
igt@drv_selftest@live_gtt:
shard-kbl: FAIL (fdo#105347) -> INCOMPLETE (fdo#103665)
fdo#100587 https://bugs.freedesktop.org/show_bug.cgi?id=100587
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103667 https://bugs.freedesktop.org/show_bug.cgi?id=103667
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4314 -> Patchwork_9301
CI_DRM_4314: 2f4a101babe898ba750fa274dc90db1ede57d59c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4518: e4908004547b63131352fbc0ddcdb1d3d55480e0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9301: 9a78f2b75b0e09b3ccb954e1ef72820a01bd3932 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9301/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-14 16:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-14 12:49 [PATCH] drm/i915/selftests: Initialise request to silence a compiler Chris Wilson
2018-06-14 13:10 ` Ville Syrjälä
2018-06-14 13:55 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-14 16:58 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.