From: Eduardo Habkost <ehabkost@redhat.com>
To: Babu Moger <babu.moger@amd.com>
Cc: geoff@hostfission.com, kvm@vger.kernel.org, mst@redhat.com,
kash@tripleback.net, mtosatti@redhat.com, qemu-devel@nongnu.org,
pbonzini@redhat.com, rth@twiddle.net
Subject: Re: [PATCH v14 4/6] cpus: Add new function topology_supports_topoext
Date: Thu, 14 Jun 2018 15:42:07 -0300 [thread overview]
Message-ID: <20180614184207.GX7451@localhost.localdomain> (raw)
In-Reply-To: <1528939107-17193-5-git-send-email-babu.moger@amd.com>
On Wed, Jun 13, 2018 at 09:18:25PM -0400, Babu Moger wrote:
> Add new function topology_supports_topoext to verify
> if we can support topoext feature. Will be used to enable/disable
> topoext feature.
>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> accel/tcg/user-exec-stub.c | 5 +++++
> cpus.c | 13 +++++++++++++
> include/qom/cpu.h | 9 +++++++++
> 3 files changed, 27 insertions(+)
>
x86-specific code doesn't belong to arch-independent code. Why
not keep it in target/i386/cpu.c like before?
--
Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com>
To: Babu Moger <babu.moger@amd.com>
Cc: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com,
rth@twiddle.net, mtosatti@redhat.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org, kash@tripleback.net, geoff@hostfission.com
Subject: Re: [Qemu-devel] [PATCH v14 4/6] cpus: Add new function topology_supports_topoext
Date: Thu, 14 Jun 2018 15:42:07 -0300 [thread overview]
Message-ID: <20180614184207.GX7451@localhost.localdomain> (raw)
In-Reply-To: <1528939107-17193-5-git-send-email-babu.moger@amd.com>
On Wed, Jun 13, 2018 at 09:18:25PM -0400, Babu Moger wrote:
> Add new function topology_supports_topoext to verify
> if we can support topoext feature. Will be used to enable/disable
> topoext feature.
>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> accel/tcg/user-exec-stub.c | 5 +++++
> cpus.c | 13 +++++++++++++
> include/qom/cpu.h | 9 +++++++++
> 3 files changed, 27 insertions(+)
>
x86-specific code doesn't belong to arch-independent code. Why
not keep it in target/i386/cpu.c like before?
--
Eduardo
next prev parent reply other threads:[~2018-06-14 18:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 1:18 [PATCH v14 0/6] i386: Enable TOPOEXT to support hyperthreading on AMD CPU Babu Moger
2018-06-14 1:18 ` [Qemu-devel] " Babu Moger
2018-06-14 1:18 ` [PATCH v14 1/6] i386: Set TOPOEXT unconditionally for comapatibility Babu Moger
2018-06-14 1:18 ` [Qemu-devel] " Babu Moger
2018-06-14 2:21 ` Eduardo Habkost
2018-06-14 2:21 ` [Qemu-devel] " Eduardo Habkost
2018-06-14 13:24 ` Moger, Babu
2018-06-14 13:24 ` [Qemu-devel] " Moger, Babu
2018-06-14 1:18 ` [PATCH v14 2/6] i386: Enable TOPOEXT feature on AMD EPYC CPU Babu Moger
2018-06-14 1:18 ` [Qemu-devel] " Babu Moger
2018-06-14 18:40 ` Eduardo Habkost
2018-06-14 18:40 ` [Qemu-devel] " Eduardo Habkost
2018-06-14 20:41 ` Moger, Babu
2018-06-14 20:41 ` [Qemu-devel] " Moger, Babu
2018-06-14 23:16 ` Moger, Babu
2018-06-14 23:16 ` [Qemu-devel] " Moger, Babu
2018-06-14 1:18 ` [PATCH v14 3/6] i386: Disable TOPOEXT feature on pc-2.12 Babu Moger
2018-06-14 1:18 ` [Qemu-devel] " Babu Moger
2018-06-14 18:40 ` Eduardo Habkost
2018-06-14 18:40 ` [Qemu-devel] " Eduardo Habkost
2018-06-14 20:41 ` Moger, Babu
2018-06-14 20:41 ` [Qemu-devel] " Moger, Babu
2018-06-14 1:18 ` [PATCH v14 4/6] cpus: Add new function topology_supports_topoext Babu Moger
2018-06-14 1:18 ` [Qemu-devel] " Babu Moger
2018-06-14 18:42 ` Eduardo Habkost [this message]
2018-06-14 18:42 ` Eduardo Habkost
2018-06-14 1:18 ` [PATCH v14 5/6] i386: Disable TOPOEXT feature if it cannot be supported Babu Moger
2018-06-14 1:18 ` [Qemu-devel] " Babu Moger
2018-06-14 19:13 ` Eduardo Habkost
2018-06-14 19:13 ` [Qemu-devel] " Eduardo Habkost
2018-06-14 22:18 ` Moger, Babu
2018-06-14 22:18 ` [Qemu-devel] " Moger, Babu
2018-06-14 23:09 ` Moger, Babu
2018-06-14 23:09 ` [Qemu-devel] " Moger, Babu
2018-06-15 14:09 ` Moger, Babu
2018-06-15 14:09 ` [Qemu-devel] " Moger, Babu
2018-06-14 1:18 ` [PATCH v14 6/6] i386: Remove generic SMT thread check Babu Moger
2018-06-14 1:18 ` [Qemu-devel] " Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180614184207.GX7451@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=babu.moger@amd.com \
--cc=geoff@hostfission.com \
--cc=kash@tripleback.net \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.