From: Steven Rostedt <rostedt@goodmis.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Alan Stern <stern@rowland.harvard.edu>,
Ming Lei <ming.lei@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
USB list <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
Sebastian Sewior <bigeasy@linutronix.de>
Subject: usb: don't offload isochronous urb completions to ksoftirq
Date: Fri, 15 Jun 2018 17:13:29 -0400 [thread overview]
Message-ID: <20180615171329.05f7e4de@vmware.local.home> (raw)
On Fri, 15 Jun 2018 17:05:01 -0400 (EDT)
Mikulas Patocka <mpatocka@redhat.com> wrote:
> I don't think that threaded interrupt handlers are a good idea.
>
> There are existing tools such as rtkit in Linux distributions that
> increase the priority of audio applications to real time. And if rtkit
> increases the priority of audio player or audio server above the priority
> of the interrupt thread that handles the soundcard - sound playback is
> screwed.
>
> You would have to set the priority of the interrupt thread to the highest
> real-time priority - and in such a case, the interrupt thread is no
> different than a hard-irq handler.
Perhaps rtkit et.al. should be updated to know about interrupt threads.
It's pretty trivial to know about them and that can easily be
automated. The only problem is to keep the irq thread higher than the
audio server. And we always tell people to never put a thread to the
maximum priority unless they had a damn good reason to do so.
-- Steve
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Alan Stern <stern@rowland.harvard.edu>,
Ming Lei <ming.lei@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
USB list <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
Sebastian Sewior <bigeasy@linutronix.de>
Subject: Re: High-priority softirqs [was: [PATCH] usb: don't offload isochronous urb completions to ksoftirq]
Date: Fri, 15 Jun 2018 17:13:29 -0400 [thread overview]
Message-ID: <20180615171329.05f7e4de@vmware.local.home> (raw)
In-Reply-To: <alpine.LRH.2.02.1806151658000.24974@file01.intranet.prod.int.rdu2.redhat.com>
On Fri, 15 Jun 2018 17:05:01 -0400 (EDT)
Mikulas Patocka <mpatocka@redhat.com> wrote:
> I don't think that threaded interrupt handlers are a good idea.
>
> There are existing tools such as rtkit in Linux distributions that
> increase the priority of audio applications to real time. And if rtkit
> increases the priority of audio player or audio server above the priority
> of the interrupt thread that handles the soundcard - sound playback is
> screwed.
>
> You would have to set the priority of the interrupt thread to the highest
> real-time priority - and in such a case, the interrupt thread is no
> different than a hard-irq handler.
Perhaps rtkit et.al. should be updated to know about interrupt threads.
It's pretty trivial to know about them and that can easily be
automated. The only problem is to keep the irq thread higher than the
audio server. And we always tell people to never put a thread to the
maximum priority unless they had a damn good reason to do so.
-- Steve
next reply other threads:[~2018-06-15 21:13 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 21:13 Steven Rostedt [this message]
2018-06-15 21:13 ` High-priority softirqs [was: [PATCH] usb: don't offload isochronous urb completions to ksoftirq] Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2018-06-15 21:05 usb: don't offload isochronous urb completions to ksoftirq Mikulas Patocka
2018-06-15 21:05 ` High-priority softirqs [was: [PATCH] usb: don't offload isochronous urb completions to ksoftirq] Mikulas Patocka
2018-06-15 20:54 usb: don't offload isochronous urb completions to ksoftirq Alan Stern
2018-06-15 20:54 ` High-priority softirqs [was: [PATCH] usb: don't offload isochronous urb completions to ksoftirq] Alan Stern
2018-06-15 17:40 usb: don't offload isochronous urb completions to ksoftirq Sebastian Andrzej Siewior
2018-06-15 17:40 ` High-priority softirqs [was: [PATCH] usb: don't offload isochronous urb completions to ksoftirq] Sebastian Sewior
2018-06-15 17:34 usb: don't offload isochronous urb completions to ksoftirq Steven Rostedt
2018-06-15 17:34 ` High-priority softirqs [was: [PATCH] usb: don't offload isochronous urb completions to ksoftirq] Steven Rostedt
2018-06-15 17:28 usb: don't offload isochronous urb completions to ksoftirq Thomas Gleixner
2018-06-15 17:28 ` High-priority softirqs [was: [PATCH] usb: don't offload isochronous urb completions to ksoftirq] Thomas Gleixner
2018-06-15 17:17 usb: don't offload isochronous urb completions to ksoftirq Alan Stern
2018-06-15 17:17 ` High-priority softirqs [was: [PATCH] usb: don't offload isochronous urb completions to ksoftirq] Alan Stern
2018-06-15 16:46 usb: don't offload isochronous urb completions to ksoftirq Steven Rostedt
2018-06-15 16:46 ` [PATCH] " Steven Rostedt
2018-06-15 16:41 Mikulas Patocka
2018-06-15 16:41 ` [PATCH] " Mikulas Patocka
2018-06-14 22:35 Steven Rostedt
2018-06-14 22:35 ` [PATCH] " Steven Rostedt
2018-06-14 22:23 Mikulas Patocka
2018-06-14 22:23 ` [PATCH] " Mikulas Patocka
2018-06-13 22:31 Steven Rostedt
2018-06-13 22:31 ` [PATCH] " Steven Rostedt
2018-06-13 19:30 Mikulas Patocka
2018-06-13 19:30 ` [PATCH] " Mikulas Patocka
2018-06-13 18:54 Alan Stern
2018-06-13 18:54 ` [PATCH] " Alan Stern
2018-06-13 16:35 Mikulas Patocka
2018-06-13 16:35 ` [PATCH] " Mikulas Patocka
2018-06-13 14:13 Alan Stern
2018-06-13 14:13 ` [PATCH] " Alan Stern
2018-06-13 13:57 Mikulas Patocka
2018-06-13 13:57 ` [PATCH] " Mikulas Patocka
2018-06-12 20:06 Alan Stern
2018-06-12 20:06 ` [PATCH] " Alan Stern
2018-06-12 19:03 Mikulas Patocka
2018-06-12 19:03 ` [PATCH] " Mikulas Patocka
2018-06-12 18:50 Mikulas Patocka
2018-06-12 18:50 ` [PATCH] " Mikulas Patocka
2018-06-12 18:44 Alan Stern
2018-06-12 18:44 ` [PATCH] " Alan Stern
2018-06-12 17:52 Greg Kroah-Hartman
2018-06-12 17:52 ` [PATCH] " Greg Kroah-Hartman
2018-06-12 17:19 Mikulas Patocka
2018-06-12 17:19 ` [PATCH] " Mikulas Patocka
2018-06-12 16:38 Alan Stern
2018-06-12 16:38 ` [PATCH] " Alan Stern
2018-06-12 16:03 Mikulas Patocka
2018-06-12 16:03 ` [PATCH] " Mikulas Patocka
2018-06-12 15:11 Alan Stern
2018-06-12 15:11 ` [PATCH] " Alan Stern
2018-06-12 14:44 Mikulas Patocka
2018-06-12 14:44 ` [PATCH] " Mikulas Patocka
2018-06-12 14:38 Alan Stern
2018-06-12 14:38 ` [PATCH] " Alan Stern
2018-06-12 14:29 Mikulas Patocka
2018-06-12 14:29 ` [PATCH] " Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615171329.05f7e4de@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.