All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] modem-manager: update package prompt name
Date: Fri, 15 Jun 2018 21:37:54 +0200	[thread overview]
Message-ID: <20180615193753.GB27644@x230> (raw)
In-Reply-To: <20180615193133.77D7188705@busybox.osuosl.org>

Hi Baruch, Thomas,

> commit: https://git.buildroot.net/buildroot/commit/?id=de46ba290d2152261e29ef5339d8ea4adbbaf132
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

> Rename the prompt string for consistency with the package directory
> name.

> Cc: Aleksander Morgado <aleksander@aleksander.es>
> Cc: Carlos Santos <casantos@datacom.com.br>
> Cc: Petr Vorel <petr.vorel@gmail.com>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> Acked-by: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/modem-manager/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index 226f82f4f6..c4c723776d 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -1,5 +1,5 @@
>  config BR2_PACKAGE_MODEM_MANAGER
> -	bool "modemmanager"
> +	bool "modem-manager"
Sorry I should have thought twice before acking this.
It's not that important, but better would be to call it ModemManager, as that's its name.
And network-manager (called now networkmanager) as NetworkManager...

Kind regards,
Petr

  reply	other threads:[~2018-06-15 19:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15 19:33 [Buildroot] [git commit] modem-manager: update package prompt name Thomas Petazzoni
2018-06-15 19:37 ` Petr Vorel [this message]
2018-06-15 19:44   ` Petr Vorel
2018-06-15 20:33   ` Thomas Petazzoni
2018-06-15 21:23     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615193753.GB27644@x230 \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.