From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] modem-manager: update package prompt name
Date: Fri, 15 Jun 2018 21:44:16 +0200 [thread overview]
Message-ID: <20180615194415.GC27644@x230> (raw)
In-Reply-To: <20180615193753.GB27644@x230>
Hi Baruch, Thomas,
> > commit: https://git.buildroot.net/buildroot/commit/?id=de46ba290d2152261e29ef5339d8ea4adbbaf132
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> > Rename the prompt string for consistency with the package directory
> > name.
> > config BR2_PACKAGE_MODEM_MANAGER
> > - bool "modemmanager"
> > + bool "modem-manager"
> Sorry I should have thought twice before acking this.
> It's not that important, but better would be to call it ModemManager, as that's its name.
> And network-manager (called now networkmanager) as NetworkManager...
OK, bool is supposed to be lower case, than it's ok. although it looks a bit
unusual. Maybe I'm too used to Debian package names (modemmanager vs. network-manager).
Kind regards,
Petr
next prev parent reply other threads:[~2018-06-15 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 19:33 [Buildroot] [git commit] modem-manager: update package prompt name Thomas Petazzoni
2018-06-15 19:37 ` Petr Vorel
2018-06-15 19:44 ` Petr Vorel [this message]
2018-06-15 20:33 ` Thomas Petazzoni
2018-06-15 21:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615194415.GC27644@x230 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.