From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 00/19] arm64: invoke syscalls with pt_regs
Date: Mon, 18 Jun 2018 13:02:51 +0100 [thread overview]
Message-ID: <20180618120310.39527-1-mark.rutland@arm.com> (raw)
This series reworks arm64's syscall handling to minimize the propagation
of user-controlled register values into speculated code paths. As with
x86 [1], a wrapper is generated for each syscall, which extracts the
argument from a struct pt_regs. During kernel entry from userspace,
registers are zeroed.
The arm64 kernel code directly invokes some syscalls which the x86 code
doesn't, so I've added ksys_* wrappers for these, following the x86
example. The rest of the series is arm64-specific.
I've pushed the series out to my arm64/syscall-regs branch [2] on
kernel.org.
Since v1 [3]:
* Rebase atop of arm64 for-next/core (for SSBD conflicts)
* Move ksys_personality logic into <linux/syscalls.h>
* Move kcompat_sys_* wrappers to <linux/compat.h>
* Fix scno bounds check to use unsigned comparison
* Fix sve_user_reset() call in el0_svc_handler()
* Add BUILD_BUG() to the !CONFIG_ARM64_SVE stubs
* Accumulate acked-by / reviewed-by tags
Since v2 [4]:
* Rebase to v4.18-rc1
* Take upper 32 RES0 bits of SCTLR_ELx into account
* Accumulate acks
Thanks,
Mark.
[1] https://lkml.kernel.org/r/20180330093720.6780-1-linux at dominikbrodowski.net
[2] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
[3] https://lkml.kernel.org/r/20180514094640.27569-1-mark.rutland at arm.com
[4] https://lkml.kernel.org/r/20180601112441.37810-1-mark.rutland at arm.com
Mark Rutland (19):
arm64: consistently use unsigned long for thread flags
arm64: move SCTLR_EL{1,2} assertions to <asm/sysreg.h>
arm64: introduce sysreg_clear_set()
arm64: kill config_sctlr_el1()
arm64: kill change_cpacr()
arm64: move sve_user_{enable,disable} to <asm/fpsimd.h>
arm64: remove sigreturn wrappers
arm64: convert raw syscall invocation to C
arm64: convert syscall trace logic to C
arm64: convert native/compat syscall entry to C
arm64: don't reload GPRs after apply_ssbd
arm64: zero GPRs upon entry from EL0
kernel: add ksys_personality()
kernel: add kcompat_sys_{f,}statfs64()
arm64: remove in-kernel call to sys_personality()
arm64: use {COMPAT,}SYSCALL_DEFINE0 for sigreturn
arm64: use SYSCALL_DEFINE6() for mmap
arm64: convert compat wrappers to C
arm64: implement syscall wrappers
arch/arm64/Kconfig | 1 +
arch/arm64/include/asm/fpsimd.h | 17 +++-
arch/arm64/include/asm/syscall_wrapper.h | 80 +++++++++++++++++
arch/arm64/include/asm/sysreg.h | 39 +++++----
arch/arm64/include/asm/unistd32.h | 26 +++---
arch/arm64/kernel/Makefile | 5 +-
arch/arm64/kernel/armv8_deprecated.c | 8 +-
arch/arm64/kernel/cpu_errata.c | 3 +-
arch/arm64/kernel/entry.S | 145 ++++---------------------------
arch/arm64/kernel/entry32.S | 121 --------------------------
arch/arm64/kernel/fpsimd.c | 19 ----
arch/arm64/kernel/signal.c | 5 +-
arch/arm64/kernel/signal32.c | 6 +-
arch/arm64/kernel/sys.c | 19 ++--
arch/arm64/kernel/sys32.c | 127 ++++++++++++++++++++++++---
arch/arm64/kernel/syscall.c | 114 ++++++++++++++++++++++++
arch/arm64/kernel/traps.c | 4 +-
arch/arm64/mm/fault.c | 2 +-
fs/statfs.c | 14 ++-
include/linux/compat.h | 11 +++
include/linux/syscalls.h | 11 +++
21 files changed, 441 insertions(+), 336 deletions(-)
create mode 100644 arch/arm64/include/asm/syscall_wrapper.h
delete mode 100644 arch/arm64/kernel/entry32.S
create mode 100644 arch/arm64/kernel/syscall.c
--
2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com
Cc: dave.martin@arm.com, hch@infradead.org, james.morse@arm.com,
linux@dominikbrodowski.net, linux-fsdevel@vger.kernel.org,
marc.zyngier@arm.com, mark.rutland@arm.com,
viro@zeniv.linux.org.uk
Subject: [PATCHv3 00/19] arm64: invoke syscalls with pt_regs
Date: Mon, 18 Jun 2018 13:02:51 +0100 [thread overview]
Message-ID: <20180618120310.39527-1-mark.rutland@arm.com> (raw)
This series reworks arm64's syscall handling to minimize the propagation
of user-controlled register values into speculated code paths. As with
x86 [1], a wrapper is generated for each syscall, which extracts the
argument from a struct pt_regs. During kernel entry from userspace,
registers are zeroed.
The arm64 kernel code directly invokes some syscalls which the x86 code
doesn't, so I've added ksys_* wrappers for these, following the x86
example. The rest of the series is arm64-specific.
I've pushed the series out to my arm64/syscall-regs branch [2] on
kernel.org.
Since v1 [3]:
* Rebase atop of arm64 for-next/core (for SSBD conflicts)
* Move ksys_personality logic into <linux/syscalls.h>
* Move kcompat_sys_* wrappers to <linux/compat.h>
* Fix scno bounds check to use unsigned comparison
* Fix sve_user_reset() call in el0_svc_handler()
* Add BUILD_BUG() to the !CONFIG_ARM64_SVE stubs
* Accumulate acked-by / reviewed-by tags
Since v2 [4]:
* Rebase to v4.18-rc1
* Take upper 32 RES0 bits of SCTLR_ELx into account
* Accumulate acks
Thanks,
Mark.
[1] https://lkml.kernel.org/r/20180330093720.6780-1-linux@dominikbrodowski.net
[2] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
[3] https://lkml.kernel.org/r/20180514094640.27569-1-mark.rutland@arm.com
[4] https://lkml.kernel.org/r/20180601112441.37810-1-mark.rutland@arm.com
Mark Rutland (19):
arm64: consistently use unsigned long for thread flags
arm64: move SCTLR_EL{1,2} assertions to <asm/sysreg.h>
arm64: introduce sysreg_clear_set()
arm64: kill config_sctlr_el1()
arm64: kill change_cpacr()
arm64: move sve_user_{enable,disable} to <asm/fpsimd.h>
arm64: remove sigreturn wrappers
arm64: convert raw syscall invocation to C
arm64: convert syscall trace logic to C
arm64: convert native/compat syscall entry to C
arm64: don't reload GPRs after apply_ssbd
arm64: zero GPRs upon entry from EL0
kernel: add ksys_personality()
kernel: add kcompat_sys_{f,}statfs64()
arm64: remove in-kernel call to sys_personality()
arm64: use {COMPAT,}SYSCALL_DEFINE0 for sigreturn
arm64: use SYSCALL_DEFINE6() for mmap
arm64: convert compat wrappers to C
arm64: implement syscall wrappers
arch/arm64/Kconfig | 1 +
arch/arm64/include/asm/fpsimd.h | 17 +++-
arch/arm64/include/asm/syscall_wrapper.h | 80 +++++++++++++++++
arch/arm64/include/asm/sysreg.h | 39 +++++----
arch/arm64/include/asm/unistd32.h | 26 +++---
arch/arm64/kernel/Makefile | 5 +-
arch/arm64/kernel/armv8_deprecated.c | 8 +-
arch/arm64/kernel/cpu_errata.c | 3 +-
arch/arm64/kernel/entry.S | 145 ++++---------------------------
arch/arm64/kernel/entry32.S | 121 --------------------------
arch/arm64/kernel/fpsimd.c | 19 ----
arch/arm64/kernel/signal.c | 5 +-
arch/arm64/kernel/signal32.c | 6 +-
arch/arm64/kernel/sys.c | 19 ++--
arch/arm64/kernel/sys32.c | 127 ++++++++++++++++++++++++---
arch/arm64/kernel/syscall.c | 114 ++++++++++++++++++++++++
arch/arm64/kernel/traps.c | 4 +-
arch/arm64/mm/fault.c | 2 +-
fs/statfs.c | 14 ++-
include/linux/compat.h | 11 +++
include/linux/syscalls.h | 11 +++
21 files changed, 441 insertions(+), 336 deletions(-)
create mode 100644 arch/arm64/include/asm/syscall_wrapper.h
delete mode 100644 arch/arm64/kernel/entry32.S
create mode 100644 arch/arm64/kernel/syscall.c
--
2.11.0
next reply other threads:[~2018-06-18 12:02 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 12:02 Mark Rutland [this message]
2018-06-18 12:02 ` [PATCHv3 00/19] arm64: invoke syscalls with pt_regs Mark Rutland
2018-06-18 12:02 ` [PATCHv3 01/19] arm64: consistently use unsigned long for thread flags Mark Rutland
2018-06-18 12:02 ` Mark Rutland
2018-06-19 10:49 ` Catalin Marinas
2018-06-19 10:49 ` Catalin Marinas
2018-06-19 11:19 ` Mark Rutland
2018-06-19 11:19 ` Mark Rutland
2018-06-18 12:02 ` [PATCHv3 02/19] arm64: move SCTLR_EL{1, 2} assertions to <asm/sysreg.h> Mark Rutland
2018-06-18 12:02 ` [PATCHv3 02/19] arm64: move SCTLR_EL{1,2} " Mark Rutland
2018-06-19 11:02 ` [PATCHv3 02/19] arm64: move SCTLR_EL{1, 2} " Catalin Marinas
2018-06-19 11:02 ` Catalin Marinas
2018-06-19 11:48 ` [PATCHv3 02/19] arm64: move SCTLR_EL{1,2} " Mark Rutland
2018-06-19 11:48 ` Mark Rutland
2018-06-18 12:02 ` [PATCHv3 03/19] arm64: introduce sysreg_clear_set() Mark Rutland
2018-06-18 12:02 ` Mark Rutland
2018-06-19 11:44 ` Catalin Marinas
2018-06-19 11:44 ` Catalin Marinas
2018-06-19 11:47 ` Marc Zyngier
2018-06-19 11:47 ` Marc Zyngier
2018-06-18 12:02 ` [PATCHv3 04/19] arm64: kill config_sctlr_el1() Mark Rutland
2018-06-18 12:02 ` Mark Rutland
2018-06-19 11:44 ` Catalin Marinas
2018-06-19 11:44 ` Catalin Marinas
2018-06-18 12:02 ` [PATCHv3 05/19] arm64: kill change_cpacr() Mark Rutland
2018-06-18 12:02 ` Mark Rutland
2018-06-19 11:45 ` Catalin Marinas
2018-06-19 11:45 ` Catalin Marinas
2018-06-18 12:02 ` [PATCHv3 06/19] arm64: move sve_user_{enable, disable} to <asm/fpsimd.h> Mark Rutland
2018-06-18 12:02 ` [PATCHv3 06/19] arm64: move sve_user_{enable,disable} " Mark Rutland
2018-06-19 12:00 ` [PATCHv3 06/19] arm64: move sve_user_{enable, disable} " Catalin Marinas
2018-06-19 12:00 ` Catalin Marinas
2018-06-19 12:19 ` Dave Martin
2018-06-19 12:19 ` Dave Martin
2018-06-18 12:02 ` [PATCHv3 07/19] arm64: remove sigreturn wrappers Mark Rutland
2018-06-18 12:02 ` Mark Rutland
2018-06-19 12:47 ` Catalin Marinas
2018-06-19 12:47 ` Catalin Marinas
2018-06-18 12:02 ` [PATCHv3 08/19] arm64: convert raw syscall invocation to C Mark Rutland
2018-06-18 12:02 ` Mark Rutland
2018-06-19 13:33 ` Catalin Marinas
2018-06-19 13:33 ` Catalin Marinas
2018-06-19 14:21 ` Catalin Marinas
2018-06-19 14:21 ` Catalin Marinas
2018-06-19 14:48 ` Mark Rutland
2018-06-19 14:48 ` Mark Rutland
2018-06-19 14:55 ` Catalin Marinas
2018-06-19 14:55 ` Catalin Marinas
2018-06-19 14:58 ` Mark Rutland
2018-06-19 14:58 ` Mark Rutland
2018-06-18 12:03 ` [PATCHv3 09/19] arm64: convert syscall trace logic " Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 14:32 ` Catalin Marinas
2018-06-19 14:32 ` Catalin Marinas
2018-06-19 15:14 ` Mark Rutland
2018-06-19 15:14 ` Mark Rutland
2018-06-18 12:03 ` [PATCHv3 10/19] arm64: convert native/compat syscall entry " Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 12:18 ` Dave Martin
2018-06-19 12:18 ` Dave Martin
2018-06-19 13:15 ` Mark Rutland
2018-06-19 13:15 ` Mark Rutland
2018-06-20 9:21 ` Dave Martin
2018-06-20 9:21 ` Dave Martin
2018-06-19 15:20 ` Catalin Marinas
2018-06-19 15:20 ` Catalin Marinas
2018-06-18 12:03 ` [PATCHv3 11/19] arm64: don't reload GPRs after apply_ssbd Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 15:23 ` Catalin Marinas
2018-06-19 15:23 ` Catalin Marinas
2018-06-18 12:03 ` [PATCHv3 12/19] arm64: zero GPRs upon entry from EL0 Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 15:24 ` Catalin Marinas
2018-06-19 15:24 ` Catalin Marinas
2018-06-18 12:03 ` [PATCHv3 13/19] kernel: add ksys_personality() Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 15:45 ` Catalin Marinas
2018-06-19 15:45 ` Catalin Marinas
2018-06-19 15:53 ` Mark Rutland
2018-06-19 15:53 ` Mark Rutland
2018-06-18 12:03 ` [PATCHv3 14/19] kernel: add kcompat_sys_{f,}statfs64() Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-18 12:03 ` [PATCHv3 15/19] arm64: remove in-kernel call to sys_personality() Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 15:46 ` Catalin Marinas
2018-06-19 15:46 ` Catalin Marinas
2018-06-18 12:03 ` [PATCHv3 16/19] arm64: use {COMPAT,}SYSCALL_DEFINE0 for sigreturn Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 15:48 ` [PATCHv3 16/19] arm64: use {COMPAT, }SYSCALL_DEFINE0 " Catalin Marinas
2018-06-19 15:48 ` [PATCHv3 16/19] arm64: use {COMPAT,}SYSCALL_DEFINE0 " Catalin Marinas
2018-06-18 12:03 ` [PATCHv3 17/19] arm64: use SYSCALL_DEFINE6() for mmap Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 15:50 ` Catalin Marinas
2018-06-19 15:50 ` Catalin Marinas
2018-06-18 12:03 ` [PATCHv3 18/19] arm64: convert compat wrappers to C Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 15:51 ` Catalin Marinas
2018-06-19 15:51 ` Catalin Marinas
2018-06-18 12:03 ` [PATCHv3 19/19] arm64: implement syscall wrappers Mark Rutland
2018-06-18 12:03 ` Mark Rutland
2018-06-19 16:13 ` Catalin Marinas
2018-06-19 16:13 ` Catalin Marinas
2018-06-19 15:38 ` [PATCHv3 00/19] arm64: invoke syscalls with pt_regs Mark Rutland
2018-06-19 15:38 ` Mark Rutland
2018-06-19 16:14 ` Catalin Marinas
2018-06-19 16:14 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180618120310.39527-1-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.