[Cluster-devel] [PATCH v9 2/5] gfs2: iomap buffered write support

[Christoph Hellwig <hch@lst.de>]

> +/*
> + * Copyright (C) 2017 Red Hat, Inc.  All rights reserved.
> + *
> + * This copyrighted material is made available to anyone wishing to use,
> + * modify, copy, or redistribute it subject to the terms and conditions
> + * of the GNU General Public License version 2.
> + */

Replace with an SPDX tag, please.

> +static int gfs2_iomap_begin_write(struct inode *inode, loff_t pos, loff_t length,

overly long line.

> +		gfs2_write_calc_reserv(ip, iomap->length, &data_blocks, &ind_blocks);

plus a few more down the function.

> +	if (iocb->ki_flags & IOCB_DIRECT)
> +		return generic_file_write_iter(iocb, from);

This looks odd, as generic_file_write_iter duplicate the code
below to a large extent, but it's probably ok.

> @@ -754,7 +786,7 @@ static int fallocate_chunk(struct inode *inode, loff_t offset, loff_t len,
>  		if (error)
>  			goto out;
>  		offset = iomap.offset + iomap.length;
> -		if (iomap.type != IOMAP_HOLE)
> +		if (!(iomap.flags & IOMAP_F_NEW))
>  			continue;

shouldn't this be a separate patch?