From: Matthias Kaehlcke <mka@chromium.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Add machine_real_restart() to the noreturn list
Date: Tue, 19 Jun 2018 11:01:40 -0700 [thread overview]
Message-ID: <20180619180140.GA169030@google.com> (raw)
In-Reply-To: <791712792aa4431bdd55bf1beb33a169ddf3b4a2.1529423255.git.jpoimboe@redhat.com>
On Tue, Jun 19, 2018 at 10:47:50AM -0500, Josh Poimboeuf wrote:
> machine_real_restart() is annotated as '__noreturn", so add it to the
> objtool noreturn list. This fixes the following warning with clang and
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y:
>
> arch/x86/kernel/reboot.o: warning: objtool: native_machine_emergency_restart() falls through to next function machine_power_off()
>
> Reported-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Thanks!
next prev parent reply other threads:[~2018-06-19 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 15:47 [PATCH] objtool: Add machine_real_restart() to the noreturn list Josh Poimboeuf
2018-06-19 18:01 ` Matthias Kaehlcke [this message]
2018-06-20 0:33 ` [tip:core/urgent] " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619180140.GA169030@google.com \
--to=mka@chromium.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.