* [PATCH] objtool: Add machine_real_restart() to the noreturn list
@ 2018-06-19 15:47 Josh Poimboeuf
2018-06-19 18:01 ` Matthias Kaehlcke
2018-06-20 0:33 ` [tip:core/urgent] " tip-bot for Josh Poimboeuf
0 siblings, 2 replies; 3+ messages in thread
From: Josh Poimboeuf @ 2018-06-19 15:47 UTC (permalink / raw)
To: x86; +Cc: linux-kernel, Matthias Kaehlcke
machine_real_restart() is annotated as '__noreturn", so add it to the
objtool noreturn list. This fixes the following warning with clang and
CONFIG_CC_OPTIMIZE_FOR_SIZE=y:
arch/x86/kernel/reboot.o: warning: objtool: native_machine_emergency_restart() falls through to next function machine_power_off()
Reported-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
tools/objtool/check.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 1f226f22ad75..fb63e2ca0ecc 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -164,6 +164,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func,
"lbug_with_loc",
"fortify_panic",
"usercopy_abort",
+ "machine_real_restart",
};
if (func->bind == STB_WEAK)
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] objtool: Add machine_real_restart() to the noreturn list
2018-06-19 15:47 [PATCH] objtool: Add machine_real_restart() to the noreturn list Josh Poimboeuf
@ 2018-06-19 18:01 ` Matthias Kaehlcke
2018-06-20 0:33 ` [tip:core/urgent] " tip-bot for Josh Poimboeuf
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2018-06-19 18:01 UTC (permalink / raw)
To: Josh Poimboeuf; +Cc: x86, linux-kernel
On Tue, Jun 19, 2018 at 10:47:50AM -0500, Josh Poimboeuf wrote:
> machine_real_restart() is annotated as '__noreturn", so add it to the
> objtool noreturn list. This fixes the following warning with clang and
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y:
>
> arch/x86/kernel/reboot.o: warning: objtool: native_machine_emergency_restart() falls through to next function machine_power_off()
>
> Reported-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:core/urgent] objtool: Add machine_real_restart() to the noreturn list
2018-06-19 15:47 [PATCH] objtool: Add machine_real_restart() to the noreturn list Josh Poimboeuf
2018-06-19 18:01 ` Matthias Kaehlcke
@ 2018-06-20 0:33 ` tip-bot for Josh Poimboeuf
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Josh Poimboeuf @ 2018-06-20 0:33 UTC (permalink / raw)
To: linux-tip-commits; +Cc: tglx, linux-kernel, mka, hpa, mingo, jpoimboe
Commit-ID: 684fb246578b9e81fc7b4ca5c71eae22edb650b2
Gitweb: https://git.kernel.org/tip/684fb246578b9e81fc7b4ca5c71eae22edb650b2
Author: Josh Poimboeuf <jpoimboe@redhat.com>
AuthorDate: Tue, 19 Jun 2018 10:47:50 -0500
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 20 Jun 2018 02:10:37 +0200
objtool: Add machine_real_restart() to the noreturn list
machine_real_restart() is annotated as '__noreturn", so add it to the
objtool noreturn list. This fixes the following warning with clang and
CONFIG_CC_OPTIMIZE_FOR_SIZE=y:
arch/x86/kernel/reboot.o: warning: objtool: native_machine_emergency_restart() falls through to next function machine_power_off()
Reported-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Link: https://lkml.kernel.org/r/791712792aa4431bdd55bf1beb33a169ddf3b4a2.1529423255.git.jpoimboe@redhat.com
---
tools/objtool/check.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 38047c6aa575..f4a25bd1871f 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -164,6 +164,7 @@ static int __dead_end_function(struct objtool_file *file, struct symbol *func,
"lbug_with_loc",
"fortify_panic",
"usercopy_abort",
+ "machine_real_restart",
};
if (func->bind == STB_WEAK)
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-20 0:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-19 15:47 [PATCH] objtool: Add machine_real_restart() to the noreturn list Josh Poimboeuf
2018-06-19 18:01 ` Matthias Kaehlcke
2018-06-20 0:33 ` [tip:core/urgent] " tip-bot for Josh Poimboeuf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.