From: Peter Zijlstra <peterz@infradead.org>
To: Nadav Amit <namit@vmware.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Alok Kataria <akataria@vmware.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v5 6/9] x86: prevent inline distortion by paravirt ops
Date: Wed, 20 Jun 2018 12:10:21 +0200 [thread overview]
Message-ID: <20180620101021.GA2530@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180619194854.69486-7-namit@vmware.com>
On Tue, Jun 19, 2018 at 12:48:51PM -0700, Nadav Amit wrote:
> +#define paravirt_alt \
> + "PARAVIRT_CALL type=\"%c[paravirt_typenum]\"" \
> + " clobber=\"%c[paravirt_clobber]\"" \
> + " pv_opptr=\"%c[paravirt_opptr]\""
That wants to be:
+ " pv_opptr=\"%c[paravirt_opptr]\";"
And other than that I would suggest: 's/paravirt_alt/paravirt_call/g'.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Nadav Amit <namit@vmware.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Alok Kataria <akataria@vmware.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v5 6/9] x86: prevent inline distortion by paravirt ops
Date: Wed, 20 Jun 2018 12:10:21 +0200 [thread overview]
Message-ID: <20180620101021.GA2530@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180619194854.69486-7-namit@vmware.com>
On Tue, Jun 19, 2018 at 12:48:51PM -0700, Nadav Amit wrote:
> +#define paravirt_alt \
> + "PARAVIRT_CALL type=\"%c[paravirt_typenum]\"" \
> + " clobber=\"%c[paravirt_clobber]\"" \
> + " pv_opptr=\"%c[paravirt_opptr]\""
That wants to be:
+ " pv_opptr=\"%c[paravirt_opptr]\";"
And other than that I would suggest: 's/paravirt_alt/paravirt_call/g'.
next prev parent reply other threads:[~2018-06-20 10:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 19:48 [PATCH v5 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-06-19 19:48 ` Nadav Amit
2018-06-19 19:48 ` [PATCH v5 1/9] Makefile: Prepare for using macros for inline asm Nadav Amit
2018-06-19 19:48 ` Nadav Amit
2018-06-19 19:48 ` [PATCH v5 2/9] x86: objtool: use asm macro for better compiler decisions Nadav Amit
2018-06-19 19:48 ` Nadav Amit
2018-06-19 19:48 ` [PATCH v5 3/9] x86: refcount: prevent gcc distortions Nadav Amit
2018-06-19 19:48 ` [PATCH v5 4/9] x86: alternatives: macrofy locks for better inlining Nadav Amit
2018-06-19 19:48 ` [PATCH v5 5/9] x86: bug: prevent gcc distortions Nadav Amit
2018-06-19 19:48 ` [PATCH v5 6/9] x86: prevent inline distortion by paravirt ops Nadav Amit
2018-06-20 5:05 ` kbuild test robot
2018-06-20 5:05 ` kbuild test robot
2018-06-20 10:10 ` Peter Zijlstra [this message]
2018-06-20 10:10 ` Peter Zijlstra
2018-06-19 19:48 ` [PATCH v5 7/9] x86: extable: use macros instead of inline assembly Nadav Amit
2018-06-19 19:48 ` [PATCH v5 8/9] x86: cpufeature: " Nadav Amit
2018-06-19 19:48 ` [PATCH v5 9/9] x86: jump-labels: " Nadav Amit
2018-06-20 13:06 ` Peter Zijlstra
2018-06-20 10:11 ` [PATCH v5 0/9] x86: macrofying inline asm for better compilation Peter Zijlstra
2018-06-20 10:11 ` Peter Zijlstra
2018-06-20 16:47 ` Nadav Amit
2018-06-20 16:47 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620101021.GA2530@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akataria@vmware.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.