From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] arm64: dts: ti: Add Support for AM654 SoC
Date: Wed, 20 Jun 2018 22:37:54 -0700 [thread overview]
Message-ID: <20180621053754.GD112168@atomide.com> (raw)
In-Reply-To: <20180619194253.27288-4-nm@ti.com>
* Nishanth Menon <nm@ti.com> [180619 19:46]:
> + cbass_main: cbass at 100000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x00100000 0x00 0x00100000 0x00020000>, /* ctrl mmr */
> + <0x00600000 0x00 0x00600000 0x00001100>, /* GPIO */
> + <0x00900000 0x00 0x00900000 0x00012000>, /* serdes */
> + <0x01000000 0x00 0x01000000 0x0af02400>, /* Most peripherals */
> + <0x30800000 0x00 0x30800000 0x0bc00000>, /* MAIN NAVSS */
> + /* MCUSS Range */
> + <0x28380000 0x00 0x28380000 0x03880000>,
> + <0x40200000 0x00 0x40200000 0x00900100>,
> + <0x42040000 0x00 0x42040000 0x03ac2400>,
> + <0x45100000 0x00 0x45100000 0x00c24000>,
> + <0x46000000 0x00 0x46000000 0x00200000>,
> + <0x47000000 0x00 0x47000000 0x00068400>;
> +
> + cbass_mcu: cbass at 28380000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x28380000 0x28380000 0x03880000>, /* MCU NAVSS*/
> + <0x40200000 0x40200000 0x00900100>, /* First peripheral window */
> + <0x42040000 0x42040000 0x03ac2400>, /* WKUP */
> + <0x45100000 0x45100000 0x00c24000>, /* MMRs, remaining NAVSS */
> + <0x46000000 0x46000000 0x00200000>, /* CPSW */
> + <0x47000000 0x47000000 0x00068400>; /* OSPI space 1 */
> +
> + cbass_wakeup: cbass at 42040000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + /* WKUP Basic peripherals */
> + ranges = <0x42040000 0x42040000 0x03ac2400>;
> + };
> + };
> + };
> +};
You should use cbass_main: interconnect at 1000000 and so on here.
Other than that looks good to me, thanks for updating it.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Santosh Shilimkar <ssantosh@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tero Kristo <t-kristo@ti.com>, Sekhar Nori <nsekhar@ti.com>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 3/5] arm64: dts: ti: Add Support for AM654 SoC
Date: Wed, 20 Jun 2018 22:37:54 -0700 [thread overview]
Message-ID: <20180621053754.GD112168@atomide.com> (raw)
In-Reply-To: <20180619194253.27288-4-nm@ti.com>
* Nishanth Menon <nm@ti.com> [180619 19:46]:
> + cbass_main: cbass@100000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x00100000 0x00 0x00100000 0x00020000>, /* ctrl mmr */
> + <0x00600000 0x00 0x00600000 0x00001100>, /* GPIO */
> + <0x00900000 0x00 0x00900000 0x00012000>, /* serdes */
> + <0x01000000 0x00 0x01000000 0x0af02400>, /* Most peripherals */
> + <0x30800000 0x00 0x30800000 0x0bc00000>, /* MAIN NAVSS */
> + /* MCUSS Range */
> + <0x28380000 0x00 0x28380000 0x03880000>,
> + <0x40200000 0x00 0x40200000 0x00900100>,
> + <0x42040000 0x00 0x42040000 0x03ac2400>,
> + <0x45100000 0x00 0x45100000 0x00c24000>,
> + <0x46000000 0x00 0x46000000 0x00200000>,
> + <0x47000000 0x00 0x47000000 0x00068400>;
> +
> + cbass_mcu: cbass@28380000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x28380000 0x28380000 0x03880000>, /* MCU NAVSS*/
> + <0x40200000 0x40200000 0x00900100>, /* First peripheral window */
> + <0x42040000 0x42040000 0x03ac2400>, /* WKUP */
> + <0x45100000 0x45100000 0x00c24000>, /* MMRs, remaining NAVSS */
> + <0x46000000 0x46000000 0x00200000>, /* CPSW */
> + <0x47000000 0x47000000 0x00068400>; /* OSPI space 1 */
> +
> + cbass_wakeup: cbass@42040000 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + /* WKUP Basic peripherals */
> + ranges = <0x42040000 0x42040000 0x03ac2400>;
> + };
> + };
> + };
> +};
You should use cbass_main: interconnect@1000000 and so on here.
Other than that looks good to me, thanks for updating it.
Regards,
Tony
next prev parent reply other threads:[~2018-06-21 5:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 19:42 [PATCH 0/5] arm64: Initial support Texas Instrument's AM654 Platform Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` [PATCH 1/5] dt-bindings: arm: ti: Add bindings for AM654 SoC Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` [PATCH 2/5] arm64: Add support for TI's K3 Multicore SoC architecture Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` [PATCH 3/5] arm64: dts: ti: Add Support for AM654 SoC Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-21 5:37 ` Tony Lindgren [this message]
2018-06-21 5:37 ` Tony Lindgren
2018-06-21 11:36 ` Nishanth Menon
2018-06-21 11:36 ` Nishanth Menon
2018-06-21 11:36 ` Nishanth Menon
2018-06-19 19:42 ` [PATCH 4/5] soc: ti: Add Support for AM654 SoC config option Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` [PATCH 5/5] arm64: dts: ti: Add support for AM654 EVM base board Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-19 19:42 ` Nishanth Menon
2018-06-21 5:40 ` [PATCH 0/5] arm64: Initial support Texas Instrument's AM654 Platform Tony Lindgren
2018-06-21 5:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621053754.GD112168@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.