Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Jun 21, 2018 at 01:27:02PM +0200, Markus Armbruster wrote:
> Forgot tests/qapi-schema/test-qapi.py, as usual.  To be squashed in:
> 
> diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py
> index 4512a41504..abbc9c7830 100644
> --- a/tests/qapi-schema/test-qapi.py
> +++ b/tests/qapi-schema/test-qapi.py
> @@ -33,8 +33,8 @@ class QAPISchemaTestVisitor(QAPISchemaVisitor):
>          if base:
>              print('    base %s' % base.name)
>          for m in members:
> -            print('    member %s: %s optional=%s' % \
> -                  (m.name, m.type.name, m.optional))
> +            print('    member %s: %s optional=%s'
> +                  % (m.name, m.type.name, m.optional))
>          self._print_variants(variants)
>  
>      def visit_alternate_type(self, name, info, variants):
> @@ -43,10 +43,11 @@ class QAPISchemaTestVisitor(QAPISchemaVisitor):
>  
>      def visit_command(self, name, info, arg_type, ret_type, gen,
>                        success_response, boxed, allow_oob, allow_preconfig):
> -        print('command %s %s -> %s' % \
> -              (name, arg_type and arg_type.name, ret_type and ret_type.name))
> -        print('   gen=%s success_response=%s boxed=%s oob=%s preconfig=%s' % \
> -              (gen, success_response, boxed, allow_oob, allow_preconfig))
> +        print('command %s %s -> %s'
> +              % (name, arg_type and arg_type.name,
> +                 ret_type and ret_type.name))
> +        print('   gen=%s success_response=%s boxed=%s oob=%s preconfig=%s'
> +              % (gen, success_response, boxed, allow_oob, allow_preconfig))
>  
>      def visit_event(self, name, info, arg_type, boxed):
>          print('event %s %s' % (name, arg_type and arg_type.name))

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|