From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints
Date: Thu, 21 Jun 2018 13:27:02 +0200 [thread overview]
Message-ID: <871sd0nzw9.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20180621083551.775-1-armbru@redhat.com> (Markus Armbruster's message of "Thu, 21 Jun 2018 10:35:51 +0200")
Forgot tests/qapi-schema/test-qapi.py, as usual. To be squashed in:
diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py
index 4512a41504..abbc9c7830 100644
--- a/tests/qapi-schema/test-qapi.py
+++ b/tests/qapi-schema/test-qapi.py
@@ -33,8 +33,8 @@ class QAPISchemaTestVisitor(QAPISchemaVisitor):
if base:
print(' base %s' % base.name)
for m in members:
- print(' member %s: %s optional=%s' % \
- (m.name, m.type.name, m.optional))
+ print(' member %s: %s optional=%s'
+ % (m.name, m.type.name, m.optional))
self._print_variants(variants)
def visit_alternate_type(self, name, info, variants):
@@ -43,10 +43,11 @@ class QAPISchemaTestVisitor(QAPISchemaVisitor):
def visit_command(self, name, info, arg_type, ret_type, gen,
success_response, boxed, allow_oob, allow_preconfig):
- print('command %s %s -> %s' % \
- (name, arg_type and arg_type.name, ret_type and ret_type.name))
- print(' gen=%s success_response=%s boxed=%s oob=%s preconfig=%s' % \
- (gen, success_response, boxed, allow_oob, allow_preconfig))
+ print('command %s %s -> %s'
+ % (name, arg_type and arg_type.name,
+ ret_type and ret_type.name))
+ print(' gen=%s success_response=%s boxed=%s oob=%s preconfig=%s'
+ % (gen, success_response, boxed, allow_oob, allow_preconfig))
def visit_event(self, name, info, arg_type, boxed):
print('event %s %s' % (name, arg_type and arg_type.name))
--
2.17.1
next prev parent reply other threads:[~2018-06-21 11:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 8:35 [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints Markus Armbruster
2018-06-21 9:18 ` Daniel P. Berrangé
2018-06-21 11:23 ` Markus Armbruster
2018-06-21 11:40 ` Daniel P. Berrangé
2018-06-21 11:27 ` Markus Armbruster [this message]
2018-06-21 11:41 ` Daniel P. Berrangé
2018-06-21 11:40 ` Philippe Mathieu-Daudé
2018-07-09 7:07 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871sd0nzw9.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.