From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: speck@linutronix.de
Subject: [MODERATED] Re: [PATCH v2.1 4/6] [PATCH v2.1 4/6] Patch #4
Date: Thu, 21 Jun 2018 09:56:43 -0400 [thread overview]
Message-ID: <20180621135643.GD28543@char.US.ORACLE.com> (raw)
In-Reply-To: <20180621084310.GS2494@hirez.programming.kicks-ass.net>
On Thu, Jun 21, 2018 at 10:43:10AM +0200, speck for Peter Zijlstra wrote:
> On Wed, Jun 20, 2018 at 04:43:00PM -0400, speck for konrad.wilk_at_oracle.com wrote:
> > x86/KVM: Warn user if KVM is loaded SMT and L1TF CPU bug being present.
> >
> > If the L1TF CPU bug is present we allow the KVM module to be loaded
> > as the major of users that use Linux and KVM have trusted guests
> > and do not want a broken setup.
>
> Why on module load? Doesn't the module get loaded unconditionally? My
> desktop seems to have it loaded and I'm pretty sure i've never used KVM
> on it.
>
> Would it not make more sense to do this in kvm_create_vm() ? Then only
> people actually using KVM get to deal with it.
Excellent suggestion. Let me see about that. Did the text sound scary enough
or should I notch it up with more scary warnings?
next prev parent reply other threads:[~2018-06-21 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 20:43 [MODERATED] [PATCH v2.1 4/6] [PATCH v2.1 4/6] Patch #4 konrad.wilk
2018-06-21 8:43 ` [MODERATED] " Peter Zijlstra
2018-06-21 13:56 ` Konrad Rzeszutek Wilk [this message]
2018-06-21 17:19 ` Paolo Bonzini
2018-06-21 11:53 ` Paolo Bonzini
2018-06-21 23:05 ` Andi Kleen
2018-06-22 9:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621135643.GD28543@char.US.ORACLE.com \
--to=konrad.wilk@oracle.com \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.