From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v4 1/2] kvm: support -overcommit cpu-pm=on|off
Date: Fri, 22 Jun 2018 21:42:39 +0300 [thread overview]
Message-ID: <20180622214216-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180622182236.GA7451@localhost.localdomain>
On Fri, Jun 22, 2018 at 03:22:36PM -0300, Eduardo Habkost wrote:
> On Fri, Jun 22, 2018 at 03:31:48AM +0300, Michael S. Tsirkin wrote:
> > With this flag, kvm allows guest to control host CPU power state. This
> > increases latency for other processes using same host CPU in an
> > unpredictable way, but if decreases idle entry/exit times for the
> > running VCPU, so to use it QEMU needs a hint about whether host CPU is
> > overcommitted, hence the flag name.
>
> The flag name in the code below is still "-dedicated".
Weird, somehow got the wrong patch sent.
Will repost the fixed one now
> [...]
> > +static QemuOptsList qemu_dedicated_opts = {
> > + .name = "dedicated",
> [...]
> > + case QEMU_OPTION_dedicated:
> > + opts = qemu_opts_parse_noisily(qemu_find_opts("dedicated"),
> > + optarg, false);
> [...]
> > +DEF("dedicated", HAS_ARG, QEMU_OPTION_dedicated,
> > + "-dedicated [mem-lock=on|off][cpu-pm=on|off]\n"
> > + " run qemu with realtime features\n"
> > + " mem-lock=on|off controls memory lock support (default: off)\n"
> > + " cpu-pm=on|off controls cpu power management (default: off)\n",
> > + QEMU_ARCH_ALL)
> > +STEXI
> > +@item -dedicated mem-lock=on|off
> > +@item -dedicated cpu-pm=on|off
> > +@findex -dedicated
> > +Run qemu using dedicated host resources.
> > +Locking qemu and guest memory can be enabled via @option{mem-lock=on}
> > +(disabled by default). This is equivalent to @option{realtime}.
> > +Guest ability to manage power state of host cpus (increasing latency for other
> > +processes on the same host cpu, but decreasing latency for guest)
> > +can be enabled via @option{cpu-pm=on} (disabled by default).
> > +ETEXI
> [...]
>
> --
> Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH v4 1/2] kvm: support -overcommit cpu-pm=on|off
Date: Fri, 22 Jun 2018 21:42:39 +0300 [thread overview]
Message-ID: <20180622214216-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180622182236.GA7451@localhost.localdomain>
On Fri, Jun 22, 2018 at 03:22:36PM -0300, Eduardo Habkost wrote:
> On Fri, Jun 22, 2018 at 03:31:48AM +0300, Michael S. Tsirkin wrote:
> > With this flag, kvm allows guest to control host CPU power state. This
> > increases latency for other processes using same host CPU in an
> > unpredictable way, but if decreases idle entry/exit times for the
> > running VCPU, so to use it QEMU needs a hint about whether host CPU is
> > overcommitted, hence the flag name.
>
> The flag name in the code below is still "-dedicated".
Weird, somehow got the wrong patch sent.
Will repost the fixed one now
> [...]
> > +static QemuOptsList qemu_dedicated_opts = {
> > + .name = "dedicated",
> [...]
> > + case QEMU_OPTION_dedicated:
> > + opts = qemu_opts_parse_noisily(qemu_find_opts("dedicated"),
> > + optarg, false);
> [...]
> > +DEF("dedicated", HAS_ARG, QEMU_OPTION_dedicated,
> > + "-dedicated [mem-lock=on|off][cpu-pm=on|off]\n"
> > + " run qemu with realtime features\n"
> > + " mem-lock=on|off controls memory lock support (default: off)\n"
> > + " cpu-pm=on|off controls cpu power management (default: off)\n",
> > + QEMU_ARCH_ALL)
> > +STEXI
> > +@item -dedicated mem-lock=on|off
> > +@item -dedicated cpu-pm=on|off
> > +@findex -dedicated
> > +Run qemu using dedicated host resources.
> > +Locking qemu and guest memory can be enabled via @option{mem-lock=on}
> > +(disabled by default). This is equivalent to @option{realtime}.
> > +Guest ability to manage power state of host cpus (increasing latency for other
> > +processes on the same host cpu, but decreasing latency for guest)
> > +can be enabled via @option{cpu-pm=on} (disabled by default).
> > +ETEXI
> [...]
>
> --
> Eduardo
next prev parent reply other threads:[~2018-06-22 18:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 0:31 [PATCH v4 0/2] kvm: limited x86 CPU power management Michael S. Tsirkin
2018-06-22 0:31 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-22 0:31 ` [PATCH v4 1/2] kvm: support -overcommit cpu-pm=on|off Michael S. Tsirkin
2018-06-22 0:31 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-22 18:22 ` Eduardo Habkost
2018-06-22 18:22 ` [Qemu-devel] " Eduardo Habkost
2018-06-22 18:42 ` Michael S. Tsirkin [this message]
2018-06-22 18:42 ` Michael S. Tsirkin
2018-06-22 18:34 ` Eduardo Habkost
2018-06-22 18:34 ` [Qemu-devel] " Eduardo Habkost
2018-06-22 19:10 ` Michael S. Tsirkin
2018-06-22 19:10 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-22 0:31 ` [PATCH v4 2/2] i386/cpu: make -cpu host support monitor/mwait Michael S. Tsirkin
2018-06-22 0:31 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-22 18:35 ` Eduardo Habkost
2018-06-22 18:35 ` [Qemu-devel] " Eduardo Habkost
2018-06-22 3:01 ` [PATCH v4 0/2] kvm: limited x86 CPU power management no-reply
2018-06-22 3:01 ` [Qemu-devel] " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622214216-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.